• Minhyuk Kim's avatar
    op-signer, op-node: Integrate op-node with op-signer for block payload signing (#12325) · 4de5c8c2
    Minhyuk Kim authored
    * Initial implementation of integrating op-node with op-signer for remote signer configuration for block payload signing
    
    * op-service: remove the requirement for signer.address to be set when using op-service
    
    * op-service: add blockpayload_args to send to rpc opsigner_signBlockPayload
    
    * Implement mock rpc in gossip_test and apply review
    
    * Clean up tests
    4de5c8c2
cli_test.go 1.45 KB
package tls

import (
	"fmt"
	"testing"

	"github.com/stretchr/testify/require"
	"github.com/urfave/cli/v2"
)

func TestDefaultCLIOptionsMatchDefaultConfig(t *testing.T) {
	cfg := configForArgs()
	defaultCfg := NewCLIConfig()
	require.Equal(t, defaultCfg, cfg)
}

func TestDefaultConfigIsValid(t *testing.T) {
	err := NewCLIConfig().Check()
	require.NoError(t, err)
}

func TestInvalidConfig(t *testing.T) {
	tests := []struct {
		name         string
		configChange func(config *CLIConfig)
	}{
		{"MissingCaCert", func(config *CLIConfig) {
			config.TLSCaCert = ""
		}},
		{"MissingCert", func(config *CLIConfig) {
			config.TLSCert = ""
		}},
		{"MissingKey", func(config *CLIConfig) {
			config.TLSKey = ""
		}},
	}
	for _, test := range tests {
		t.Run(test.name, func(t *testing.T) {
			cfg := NewCLIConfig()
			cfg.Enabled = true
			test.configChange(&cfg)
			err := cfg.Check()
			require.ErrorContains(t, err, "all tls flags must be set if at least one is set")
		})
		t.Run(fmt.Sprintf("%sAllowedWhenDisabled", test.name), func(t *testing.T) {
			cfg := NewCLIConfig()
			cfg.Enabled = false
			test.configChange(&cfg)
			require.NoError(t, cfg.Check())
		})
	}
}

func configForArgs(args ...string) CLIConfig {
	app := cli.NewApp()
	app.Flags = CLIFlagsWithFlagPrefix("TEST_", "test", "")
	app.Name = "test"
	var config CLIConfig
	app.Action = func(ctx *cli.Context) error {
		config = ReadCLIConfigWithPrefix(ctx, "test")
		return nil
	}
	_ = app.Run(args)
	return config
}