Commit 017e0480 authored by Maurelian's avatar Maurelian

feat(ctb): Record comment about numsignatures calc

parent 3f7947b7
...@@ -6,7 +6,8 @@ import { SignatureDecoder } from "safe-contracts/common/SignatureDecoder.sol"; ...@@ -6,7 +6,8 @@ import { SignatureDecoder } from "safe-contracts/common/SignatureDecoder.sol";
abstract contract GetSigners is SignatureDecoder { abstract contract GetSigners is SignatureDecoder {
/// @notice Extract the signers from a set of signatures. /// @notice Extract the signers from a set of signatures.
function _getNSigners(bytes32 dataHash, bytes memory signatures) internal pure returns (address[] memory _owners) { function _getNSigners(bytes32 dataHash, bytes memory signatures) internal pure returns (address[] memory _owners) {
uint256 numSignatures = signatures.length / 65; uint256 numSignatures = signatures.length / 65; // this is wrong. There can be extra data appended to the
// signatures for contract signatures. We should use SignatureDecoder to parse the signatures.
_owners = new address[](numSignatures); _owners = new address[](numSignatures);
/// The following code is extracted from the Safe.checkNSignatures() method. It removes the signature /// The following code is extracted from the Safe.checkNSignatures() method. It removes the signature
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment