Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
N
nebula
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
exchain
nebula
Commits
04803ac8
Unverified
Commit
04803ac8
authored
May 31, 2022
by
Maurelian
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
contracts: Fix OZ-M-02 by removing donateEth()
parent
98d0e06e
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
0 additions
and
14 deletions
+0
-14
L1StandardBridge.t.sol
...s/contracts-bedrock/contracts/test/L1StandardBridge.t.sol
+0
-9
StandardBridge.sol
.../contracts-bedrock/contracts/universal/StandardBridge.sol
+0
-5
No files found.
packages/contracts-bedrock/contracts/test/L1StandardBridge.t.sol
View file @
04803ac8
...
@@ -390,13 +390,4 @@ contract L1StandardBridge_Test is Bridge_Initializer {
...
@@ -390,13 +390,4 @@ contract L1StandardBridge_Test is Bridge_Initializer {
hex""
hex""
);
);
}
}
// donateETH
// - can send ETH to the contract
function test_donateETH() external {
assertEq(address(L1Bridge).balance, 0);
vm.prank(alice);
L1Bridge.donateETH{ value: 1000 }();
assertEq(address(L1Bridge).balance, 1000);
}
}
}
packages/contracts-bedrock/contracts/universal/StandardBridge.sol
View file @
04803ac8
...
@@ -128,11 +128,6 @@ abstract contract StandardBridge {
...
@@ -128,11 +128,6 @@ abstract contract StandardBridge {
* Public Functions *
* Public Functions *
********************/
********************/
/**
* @notice Send ETH to this contract. This is used during upgrades
*/
function donateETH() external payable {}
/**
/**
* @notice EOAs can simply send ETH to this contract to have it be deposited
* @notice EOAs can simply send ETH to this contract to have it be deposited
* to L2 through the standard bridge.
* to L2 through the standard bridge.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment