Commit 06d4d206 authored by zhiqiangxu's avatar zhiqiangxu Committed by GitHub

replace original "engine queue" with "ResetEngine" (#10776)

parent 8e154e75
...@@ -12,7 +12,7 @@ import ( ...@@ -12,7 +12,7 @@ import (
"github.com/ethereum-optimism/optimism/op-service/eth" "github.com/ethereum-optimism/optimism/op-service/eth"
) )
// The attributes queue sits in between the batch queue and the engine queue // The attributes queue sits after the batch queue.
// It transforms batches into payload attributes. The outputted payload // It transforms batches into payload attributes. The outputted payload
// attributes cannot be buffered because each batch->attributes transformation // attributes cannot be buffered because each batch->attributes transformation
// pulls in data about the current L2 safe head. // pulls in data about the current L2 safe head.
......
...@@ -15,7 +15,7 @@ import ( ...@@ -15,7 +15,7 @@ import (
// The l1Block specified is the first L1 block that includes sufficient information to derive the new safe head // The l1Block specified is the first L1 block that includes sufficient information to derive the new safe head
type SafeHeadListener interface { type SafeHeadListener interface {
// Enabled reports if this safe head listener is actively using the posted data. This allows the engine queue to // Enabled reports if this safe head listener is actively using the posted data. This allows the ResetEngine to
// optionally skip making calls that may be expensive to prepare. // optionally skip making calls that may be expensive to prepare.
// Callbacks may still be made if Enabled returns false but are not guaranteed. // Callbacks may still be made if Enabled returns false but are not guaranteed.
Enabled() bool Enabled() bool
......
...@@ -79,9 +79,9 @@ func NewDerivationPipeline(log log.Logger, rollupCfg *rollup.Config, l1Fetcher L ...@@ -79,9 +79,9 @@ func NewDerivationPipeline(log log.Logger, rollupCfg *rollup.Config, l1Fetcher L
attrBuilder := NewFetchingAttributesBuilder(rollupCfg, l1Fetcher, l2Source) attrBuilder := NewFetchingAttributesBuilder(rollupCfg, l1Fetcher, l2Source)
attributesQueue := NewAttributesQueue(log, rollupCfg, attrBuilder, batchQueue) attributesQueue := NewAttributesQueue(log, rollupCfg, attrBuilder, batchQueue)
// Reset from engine queue then up from L1 Traversal. The stages do not talk to each other during // Reset from ResetEngine then up from L1 Traversal. The stages do not talk to each other during
// the reset, but after the engine queue, this is the order in which the stages could talk to each other. // the ResetEngine, but after the ResetEngine, this is the order in which the stages could talk to each other.
// Note: The engine queue stage is the only reset that can fail. // Note: The ResetEngine is the only reset that can fail.
stages := []ResettableStage{l1Traversal, l1Src, plasma, frameQueue, bank, chInReader, batchQueue, attributesQueue} stages := []ResettableStage{l1Traversal, l1Src, plasma, frameQueue, bank, chInReader, batchQueue, attributesQueue}
return &DerivationPipeline{ return &DerivationPipeline{
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment