perf: remove defer inside loop (#10497)

0b4077e5 · Kien Trinh · GitHub · 9ef59814 · 0b4077e5
Commit 0b4077e5 authored May 11, 2024 by Kien Trinh Committed by GitHub May 10, 2024
Show whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

fetch.go op-node/cmd/batch_decoder/fetch/fetch.go +2 -1

No files found.
--- a/op-node/cmd/batch_decoder/fetch/fetch.go
+++ b/op-node/cmd/batch_decoder/fetch/fetch.go
@@ -134,11 +134,12 @@ func fetchBatchesPerBlock(ctx context.Context, client *ethclient.Client, number
 			if err != nil {
 				return 0, 0, err
 			}
-			defer file.Close()
 			enc := json.NewEncoder(file)
 			if err := enc.Encode(txm); err != nil {
+				file.Close()
 				return 0, 0, err
 			}
+			file.Close()
 		}
 	}
 	return validBatchCount, invalidBatchCount, nil