Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
N
nebula
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
exchain
nebula
Commits
138a6f0f
Unverified
Commit
138a6f0f
authored
Jan 20, 2023
by
Mark Tyneway
Committed by
GitHub
Jan 20, 2023
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #4741 from ethereum-optimism/willc/unknown-option
fix: Allow unknown options in base service v2
parents
472f809b
f04e5db2
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
1 deletion
+6
-1
rich-trains-exist.md
.changeset/rich-trains-exist.md
+5
-0
base-service-v2.ts
packages/common-ts/src/base-service/base-service-v2.ts
+1
-1
No files found.
.changeset/rich-trains-exist.md
0 → 100644
View file @
138a6f0f
---
'
@eth-optimism/common-ts'
:
patch
---
Fix unknown option error in base service v2
packages/common-ts/src/base-service/base-service-v2.ts
View file @
138a6f0f
...
@@ -156,7 +156,7 @@ export abstract class BaseServiceV2<
...
@@ -156,7 +156,7 @@ export abstract class BaseServiceV2<
// Use commander as a way to communicate info about the service. We don't actually *use*
// Use commander as a way to communicate info about the service. We don't actually *use*
// commander for anything besides the ability to run `ts-node ./service.ts --help`.
// commander for anything besides the ability to run `ts-node ./service.ts --help`.
const
program
=
new
Command
()
const
program
=
new
Command
()
.
allowUnknownOption
(
true
)
for
(
const
[
optionName
,
optionSpec
]
of
Object
.
entries
(
params
.
optionsSpec
))
{
for
(
const
[
optionName
,
optionSpec
]
of
Object
.
entries
(
params
.
optionsSpec
))
{
// Skip options that are not meant to be used by the user.
// Skip options that are not meant to be used by the user.
if
([
'
useEnv
'
,
'
useArgv
'
].
includes
(
optionName
))
{
if
([
'
useEnv
'
,
'
useArgv
'
].
includes
(
optionName
))
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment