Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
N
nebula
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
exchain
nebula
Commits
20497943
Unverified
Commit
20497943
authored
Nov 10, 2021
by
Maurelian
Committed by
Kelvin Fichter
Nov 10, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix: await hardhatnode
parent
0a147680
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
2 additions
and
2 deletions
+2
-2
014-OVM_L1StandardBridge.deploy.ts
packages/contracts/deploy/014-OVM_L1StandardBridge.deploy.ts
+1
-1
hardhat-deploy-ethers.ts
packages/contracts/src/hardhat-deploy-ethers.ts
+1
-1
No files found.
packages/contracts/deploy/014-OVM_L1StandardBridge.deploy.ts
View file @
20497943
...
@@ -86,7 +86,7 @@ const deployFn: DeployFunction = async (hre) => {
...
@@ -86,7 +86,7 @@ const deployFn: DeployFunction = async (hre) => {
// Check if if we're on the hardhat chain ID. This will only happen in CI. If this is the case, we
// Check if if we're on the hardhat chain ID. This will only happen in CI. If this is the case, we
// can skip directly to transferring ownership over to the ChugSplashDictator contract.
// can skip directly to transferring ownership over to the ChugSplashDictator contract.
if
(
isHardhatNode
(
hre
))
{
if
(
await
isHardhatNode
(
hre
))
{
const
owner
=
await
hre
.
ethers
.
getSigner
(
currentOwner
)
const
owner
=
await
hre
.
ethers
.
getSigner
(
currentOwner
)
await
Proxy__OVM_L1StandardBridge
.
connect
(
owner
).
setOwner
(
await
Proxy__OVM_L1StandardBridge
.
connect
(
owner
).
setOwner
(
ChugSplashDictator
.
address
ChugSplashDictator
.
address
...
...
packages/contracts/src/hardhat-deploy-ethers.ts
View file @
20497943
...
@@ -43,7 +43,7 @@ export const deployAndVerifyAndThen = async ({
...
@@ -43,7 +43,7 @@ export const deployAndVerifyAndThen = async ({
await
hre
.
ethers
.
provider
.
waitForTransaction
(
result
.
transactionHash
)
await
hre
.
ethers
.
provider
.
waitForTransaction
(
result
.
transactionHash
)
if
(
result
.
newlyDeployed
)
{
if
(
result
.
newlyDeployed
)
{
if
(
!
isHardhatNode
(
hre
))
{
if
(
!
(
await
isHardhatNode
(
hre
)
))
{
// Verification sometimes fails, even when the contract is correctly deployed and eventually
// Verification sometimes fails, even when the contract is correctly deployed and eventually
// verified. Possibly due to a race condition. We don't want to halt the whole deployment
// verified. Possibly due to a race condition. We don't want to halt the whole deployment
// process just because that happens.
// process just because that happens.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment