Skip to content

N
nebula
Commit 2a40d226 authored by Michael Amadi's avatar Michael Amadi Committed by GitHub
Browse files
Options

improve tests (#12937)

parent be8c3333
Show whitespace changes
Inline Side-by-side
Showing with 16 additions and 0 deletions
packages/contracts-bedrock/test/L1/L1ERC721Bridge.t.sol
View file @ 2a40d226
...@@ -237,6 +237,14 @@ contract L1ERC721Bridge_Test is CommonTest { ...@@ -237,6 +237,14 @@ contract L1ERC721Bridge_Test is CommonTest {
assertEq(localToken.ownerOf(tokenId), alice); assertEq(localToken.ownerOf(tokenId), alice);
} }
/// @dev Tests that `bridgeERC721To` reverts if the to address is the zero address.
function test_bridgeERC721To_toZeroAddress_reverts() external {
// Bridge the token.
vm.prank(bob);
vm.expectRevert("ERC721Bridge: nft recipient cannot be address(0)");
l1ERC721Bridge.bridgeERC721To(address(localToken), address(remoteToken), address(0), tokenId, 1234, hex"5678");
}
/// @dev Tests that the ERC721 bridge successfully finalizes a withdrawal. /// @dev Tests that the ERC721 bridge successfully finalizes a withdrawal.
function test_finalizeBridgeERC721_succeeds() external { function test_finalizeBridgeERC721_succeeds() external {
// Bridge the token. // Bridge the token.
......
packages/contracts-bedrock/test/L2/L2ERC721Bridge.t.sol
View file @ 2a40d226
...@@ -227,6 +227,14 @@ contract L2ERC721Bridge_Test is CommonTest { ...@@ -227,6 +227,14 @@ contract L2ERC721Bridge_Test is CommonTest {
assertEq(localToken.ownerOf(tokenId), alice); assertEq(localToken.ownerOf(tokenId), alice);
} }
/// @dev Tests that `bridgeERC721To` reverts if the to address is the zero address.
function test_bridgeERC721To_toZeroAddress_reverts() external {
// Bridge the token.
vm.prank(bob);
vm.expectRevert("ERC721Bridge: nft recipient cannot be address(0)");
l2ERC721Bridge.bridgeERC721To(address(localToken), address(remoteToken), address(0), tokenId, 1234, hex"5678");
}
/// @dev Tests that `finalizeBridgeERC721` correctly finalizes a bridged token. /// @dev Tests that `finalizeBridgeERC721` correctly finalizes a bridged token.
function test_finalizeBridgeERC721_succeeds() external { function test_finalizeBridgeERC721_succeeds() external {
// Bridge the token. // Bridge the token.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment