[indexer.client] Addressed PR feedback

.vscode/extensions.json

@@ -9,4 +9,4 @@
     "juanblanco.solidity",
     "golang.go",
   ],
-  }
\ No newline at end of file
+}
\ No newline at end of file

.vscode/settings.json

@@ -25,4 +25,4 @@
   "eslint.format.enable": true,
   "editorconfig.generateAuto": false,
   "files.trimTrailingWhitespace": true
-  }
\ No newline at end of file
+}
\ No newline at end of file

indexer/api/routes/deposits.go

@@ -52,24 +52,20 @@ func (h Routes) L1DepositsHandler(w http.ResponseWriter, r *http.Request) {
 	err = h.v.ValidateCursor(cursor)
 	if err != nil {
 		http.Error(w, err.Error(), http.StatusBadRequest)
-		h.logger.Error("Invalid cursor param", "param", cursor)
-		h.logger.Error(err.Error())
-		return
+		h.logger.Error("Invalid cursor param", "param", cursor, "err", err.Error())
 	}
 
 	limit, err := h.v.ParseValidateLimit(limitQuery)
 	if err != nil {
 		http.Error(w, err.Error(), http.StatusBadRequest)
-		h.logger.Error("Invalid limit param", "param", limitQuery)
-		h.logger.Error(err.Error())
+		h.logger.Error("Invalid limit param", "param", limitQuery, "err", err.Error())
 		return
 	}
 
 	deposits, err := h.view.L1BridgeDepositsByAddress(address, cursor, limit)
 	if err != nil {
 		http.Error(w, "Internal server error reading deposits", http.StatusInternalServerError)
-		h.logger.Error("Unable to read deposits from DB")
-		h.logger.Error(err.Error())
+		h.logger.Error("Unable to read deposits from DB", "err", err.Error())
 		return
 	}
 

indexer/api/routes/validator_test.go

@@ -6,7 +6,7 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-func Test_ParseValidateLimit(t *testing.T) {
+func TestParseValidateLimit(t *testing.T) {
 	v := Validator{}
 
 	// (1) Happy case
@@ -25,7 +25,7 @@ func Test_ParseValidateLimit(t *testing.T) {
 	require.Error(t, err, "limit must be an integer value")
 }
 
-func Test_ParseValidateAddress(t *testing.T) {
+func TestParseValidateAddress(t *testing.T) {
 	v := Validator{}
 
 	// (1) Happy case

indexer/api/routes/withdrawals.go

@@ -44,24 +44,21 @@ func (h Routes) L2WithdrawalsHandler(w http.ResponseWriter, r *http.Request) {
 	address, err := h.v.ParseValidateAddress(addressValue)
 	if err != nil {
 		http.Error(w, err.Error(), http.StatusBadRequest)
-		h.logger.Error("Invalid address param", "param", addressValue)
-		h.logger.Error(err.Error())
+		h.logger.Error("Invalid address param", "param", addressValue, "err", err)
 		return
 	}
 
 	err = h.v.ValidateCursor(cursor)
 	if err != nil {
 		http.Error(w, err.Error(), http.StatusBadRequest)
-		h.logger.Error("Invalid cursor param", "param", cursor)
-		h.logger.Error(err.Error())
+		h.logger.Error("Invalid cursor param", "param", cursor, "err", err)
 		return
 	}
 
 	limit, err := h.v.ParseValidateLimit(limitQuery)
 	if err != nil {
 		http.Error(w, err.Error(), http.StatusBadRequest)
-		h.logger.Error("Invalid query params")
-		h.logger.Error(err.Error())
+		h.logger.Error("Invalid query params", "err", err)
 		return
 	}
 

indexer/e2e_tests/bridge_transfers_e2e_test.go

@@ -447,7 +447,7 @@ func TestE2EBridgeTransfersCursoredWithdrawals(t *testing.T) {
 	}
 }
 
-func Test_ClientGetWithdrawals(t *testing.T) {
+func TestClientGetWithdrawals(t *testing.T) {
 	testSuite := createE2ETestSuite(t)
 
 	// (1) Generate contract bindings for the L1 and L2 standard bridges