feat: update interface validation script to check semver (#11740)

Updates the interface validation script to verify that all
interface contracts are using Solidity ^0.8.0 exactly.

packages/contracts-bedrock/scripts/checks/check-interfaces.sh

@@ -24,6 +24,7 @@ EXCLUDE_CONTRACTS=(
     "IERC721"
     "IERC721Enumerable"
     "IERC721Upgradeable"
+    "IERC721Metadata"
     "IERC165"
     "IERC165Upgradeable"
     "ERC721TokenReceiver"
@@ -31,10 +32,12 @@ EXCLUDE_CONTRACTS=(
     "ERC777TokensRecipient"
     "Guard"
     "IProxy"
-
-    # Foundry
     "Vm"
     "VmSafe"
+    "IMulticall3"
+    "IBeacon"
+    "IERC721TokenReceiver"
+    "IProxyCreationCallback"
 
     # EAS
     "IEAS"
@@ -147,6 +150,22 @@ for interface_file in $JSON_FILES; do
         continue
     fi
 
+    # Extract contract semver
+    contract_semver=$(jq -r '.ast.nodes[] | select(.nodeType == "PragmaDirective") | .literals | join("")' "$interface_file")
+
+    # If semver is not exactly "solidity^0.8.0", throw an error
+    if [ "$contract_semver" != "solidity^0.8.0" ]; then
+        if ! grep -q "^$contract_name$" "$REPORTED_INTERFACES_FILE"; then
+            echo "$contract_name" >> "$REPORTED_INTERFACES_FILE"
+            if ! is_excluded "$contract_name"; then
+                echo "Issue found in ABI for interface $contract_name from file $interface_file."
+                echo "Interface $contract_name does not have correct compiler version (MUST be exactly solidity ^0.8.0)."
+                issues_detected=true
+            fi
+        fi
+        continue
+    fi
+
     # Construct the corresponding contract name by removing the leading "I"
     contract_basename=${contract_name:1}
     corresponding_contract_file="$CONTRACTS_BASE/forge-artifacts/$contract_basename.sol/$contract_basename.json"

packages/contracts-bedrock/scripts/interfaces/IGnosisSafe.sol

 // SPDX-License-Identifier: LGPL-3.0-only
-pragma solidity ^0.8.10;
+pragma solidity ^0.8.0;
 
 /// @title Enum - Collection of enums used in Safe contracts.
 /// @author Richard Meissner - @rmeissner

packages/contracts-bedrock/scripts/interfaces/ISystemConfigV0.sol

 // SPDX-License-Identifier: MIT
-pragma solidity 0.8.15;
+pragma solidity ^0.8.0;
 
 import { ResourceMetering } from "src/L1/ResourceMetering.sol";
 

packages/contracts-bedrock/semver-lock.json

@@ -69,7 +69,7 @@
   },
   "src/L2/CrossL2Inbox.sol": {
     "initCodeHash": "0x071b53cd8cf0503af856c4ee0ee34643e85059d53c096453891225472e02abfa",
-    "sourceCodeHash": "0x3c78129b91d9f06afa4787d4b3039f45a3b22b3edf5155ed73d4f0c3ab33c6c8"
+    "sourceCodeHash": "0xc3478a7036b8c58ed1a90ad90556a62c99a4abb124b0fa47f2edfca31eec680f"
   },
   "src/L2/ETHLiquidity.sol": {
     "initCodeHash": "0x98177562fca0de0dfea5313c9acefe2fdbd73dee5ce6c1232055601f208f0177",

packages/contracts-bedrock/src/L2/CrossL2Inbox.sol

@@ -6,16 +6,7 @@ import { TransientContext, TransientReentrancyAware } from "src/libraries/Transi
 import { ISemver } from "src/universal/ISemver.sol";
 import { ICrossL2Inbox } from "src/L2/ICrossL2Inbox.sol";
 import { SafeCall } from "src/libraries/SafeCall.sol";
-
-/// @title IDependencySet
-/// @notice Interface for L1Block with only `isInDependencySet(uint256)` method.
-interface IDependencySet {
-    /// @notice Returns true if the chain associated with input chain ID is in the interop dependency set.
-    ///         Every chain is in the interop dependency set of itself.
-    /// @param _chainId Input chain ID.
-    /// @return True if the input chain ID corresponds to a chain in the interop dependency set, and false otherwise.
-    function isInDependencySet(uint256 _chainId) external view returns (bool);
-}
+import { IDependencySet } from "src/L2/interfaces/IDependencySet.sol";
 
 /// @notice Thrown when the caller is not DEPOSITOR_ACCOUNT when calling `setInteropStart()`
 error NotDepositor();

packages/contracts-bedrock/src/L2/interfaces/IDependencySet.sol

+// SPDX-License-Identifier: MIT
+pragma solidity ^0.8.0;
+
+/// @title IDependencySet
+/// @notice Interface for L1Block with only `isInDependencySet(uint256)` method.
+interface IDependencySet {
+    /// @notice Returns true if the chain associated with input chain ID is in the interop dependency set.
+    ///         Every chain is in the interop dependency set of itself.
+    /// @param _chainId Input chain ID.
+    /// @return True if the input chain ID corresponds to a chain in the interop dependency set, and false otherwise.
+    function isInDependencySet(uint256 _chainId) external view returns (bool);
+}

packages/contracts-bedrock/src/cannon/interfaces/IMIPS.sol

 // SPDX-License-Identifier: MIT
-pragma solidity 0.8.15;
+pragma solidity ^0.8.0;
 
 import { ISemver } from "src/universal/ISemver.sol";
 import { IPreimageOracle } from "src/cannon/interfaces/IPreimageOracle.sol";

packages/contracts-bedrock/src/cannon/interfaces/IMIPS2.sol

 // SPDX-License-Identifier: MIT
-pragma solidity 0.8.15;
+pragma solidity ^0.8.0;
 
 import { ISemver } from "src/universal/ISemver.sol";
 

packages/contracts-bedrock/src/cannon/interfaces/IPreimageOracle.sol

 // SPDX-License-Identifier: MIT
-pragma solidity 0.8.15;
+pragma solidity ^0.8.0;
 
 /// @title IPreimageOracle
 /// @notice Interface for a preimage oracle.

packages/contracts-bedrock/src/legacy/L1ChugSplashProxy.sol

@@ -2,11 +2,7 @@
 pragma solidity 0.8.15;
 
 import { Constants } from "src/libraries/Constants.sol";
-
-/// @title IL1ChugSplashDeployer
-interface IL1ChugSplashDeployer {
-    function isUpgrading() external view returns (bool);
-}
+import { IL1ChugSplashDeployer } from "src/legacy/interfaces/IL1ChugSplashProxy.sol";
 
 /// @custom:legacy
 /// @title L1ChugSplashProxy

packages/contracts-bedrock/src/legacy/interfaces/IL1ChugSplashProxy.sol

@@ -14,3 +14,15 @@ interface IL1ChugSplashProxy {
     function setOwner(address _owner) external;
     function setStorage(bytes32 _key, bytes32 _value) external;
 }
+
+/// @title IStaticL1ChugSplashProxy
+/// @notice IStaticL1ChugSplashProxy is a static version of the ChugSplash proxy interface.
+interface IStaticL1ChugSplashProxy {
+    function getImplementation() external view returns (address);
+    function getOwner() external view returns (address);
+}
+
+/// @title IL1ChugSplashDeployer
+interface IL1ChugSplashDeployer {
+    function isUpgrading() external view returns (bool);
+}

packages/contracts-bedrock/src/periphery/drippie/dripchecks/CheckGelatoLow.sol

@@ -2,11 +2,7 @@
 pragma solidity 0.8.15;
 
 import { IDripCheck } from "../IDripCheck.sol";
-
-interface IGelatoTreasury {
-    function totalDepositedAmount(address _user, address _token) external view returns (uint256);
-    function totalWithdrawnAmount(address _user, address _token) external view returns (uint256);
-}
+import { IGelatoTreasury } from "src/vendor/interfaces/IGelatoTreasury.sol";
 
 /// @title CheckGelatoLow
 /// @notice DripCheck for checking if an account's Gelato ETH balance is below some threshold.

packages/contracts-bedrock/src/periphery/faucet/authmodules/IFaucetAuthModule.sol

 // SPDX-License-Identifier: MIT
-pragma solidity 0.8.15;
+pragma solidity ^0.8.0;
 
 import { Faucet } from "../Faucet.sol";
 

packages/contracts-bedrock/src/universal/ProxyAdmin.sol

@@ -6,22 +6,8 @@ import { Proxy } from "src/universal/Proxy.sol";
 import { AddressManager } from "src/legacy/AddressManager.sol";
 import { L1ChugSplashProxy } from "src/legacy/L1ChugSplashProxy.sol";
 import { Constants } from "src/libraries/Constants.sol";
-
-/// @title IStaticERC1967Proxy
-/// @notice IStaticERC1967Proxy is a static version of the ERC1967 proxy interface.
-interface IStaticERC1967Proxy {
-    function implementation() external view returns (address);
-
-    function admin() external view returns (address);
-}
-
-/// @title IStaticL1ChugSplashProxy
-/// @notice IStaticL1ChugSplashProxy is a static version of the ChugSplash proxy interface.
-interface IStaticL1ChugSplashProxy {
-    function getImplementation() external view returns (address);
-
-    function getOwner() external view returns (address);
-}
+import { IStaticERC1967Proxy } from "src/universal/interfaces/IStaticERC1967Proxy.sol";
+import { IStaticL1ChugSplashProxy } from "src/legacy/interfaces/IL1ChugSplashProxy.sol";
 
 /// @title ProxyAdmin
 /// @notice This is an auxiliary contract meant to be assigned as the admin of an ERC1967 Proxy,

packages/contracts-bedrock/src/universal/interfaces/IEIP712.sol

+// SPDX-License-Identifier: MIT
+pragma solidity ^0.8.0;
+
+/// @title IEIP712
+interface IEIP712 {
+    function DOMAIN_SEPARATOR() external view returns (bytes32);
+}

packages/contracts-bedrock/src/universal/interfaces/IStaticERC1967Proxy.sol

+// SPDX-License-Identifier: MIT
+pragma solidity ^0.8.0;
+
+/// @title IStaticERC1967Proxy
+/// @notice IStaticERC1967Proxy is a static version of the ERC1967 proxy interface.
+interface IStaticERC1967Proxy {
+    function implementation() external view returns (address);
+    function admin() external view returns (address);
+}

packages/contracts-bedrock/src/vendor/interfaces/IGelatoTreasury.sol

+// SPDX-License-Identifier: MIT
+pragma solidity ^0.8.0;
+
+/// @title IGelatoTreasury
+/// @notice Interface for the GelatoTreasury contract.
+interface IGelatoTreasury {
+    function totalDepositedAmount(address _user, address _token) external view returns (uint256);
+    function totalWithdrawnAmount(address _user, address _token) external view returns (uint256);
+}

packages/contracts-bedrock/test/Preinstalls.t.sol

@@ -5,10 +5,7 @@ import { CommonTest } from "test/setup/CommonTest.sol";
 import { Preinstalls } from "src/libraries/Preinstalls.sol";
 import { Bytes } from "src/libraries/Bytes.sol";
 import { console2 as console } from "forge-std/console2.sol";
-
-interface IEIP712 {
-    function DOMAIN_SEPARATOR() external view returns (bytes32);
-}
+import { IEIP712 } from "src/universal/interfaces/IEIP712.sol";
 
 /// @title PreinstallsTest
 contract PreinstallsTest is CommonTest {

packages/contracts-bedrock/test/periphery/op-nft/Optimist.t.sol

@@ -3,6 +3,7 @@ pragma solidity >=0.6.2 <0.9.0;
 
 // Testing utilities
 import { Test } from "forge-std/Test.sol";
+import { IMulticall3 } from "forge-std/interfaces/IMulticall3.sol";
 import { AttestationStation } from "src/periphery/op-nft/AttestationStation.sol";
 import { Optimist } from "src/periphery/op-nft/Optimist.sol";
 import { OptimistAllowlist } from "src/periphery/op-nft/OptimistAllowlist.sol";
@@ -11,21 +12,6 @@ import { OptimistInviterHelper } from "test/mocks/OptimistInviterHelper.sol";
 import { Strings } from "@openzeppelin/contracts/utils/Strings.sol";
 import { IERC721 } from "@openzeppelin/contracts/token/ERC721/IERC721.sol";
 
-interface IMulticall3 {
-    struct Call3 {
-        address target;
-        bool allowFailure;
-        bytes callData;
-    }
-
-    struct Result {
-        bool success;
-        bytes returnData;
-    }
-
-    function aggregate3(Call3[] calldata calls) external payable returns (Result[] memory returnData);
-}
-
 library Multicall {
     bytes internal constant code =
         hex"6080604052600436106100f35760003560e01c80634d2301cc1161008a578063a8b0574e11610059578063a8b0574e1461025a578063bce38bd714610275578063c3077fa914610288578063ee82ac5e1461029b57600080fd5b80634d2301cc146101ec57806372425d9d1461022157806382ad56cb1461023457806386d516e81461024757600080fd5b80633408e470116100c65780633408e47014610191578063399542e9146101a45780633e64a696146101c657806342cbb15c146101d957600080fd5b80630f28c97d146100f8578063174dea711461011a578063252dba421461013a57806327e86d6e1461015b575b600080fd5b34801561010457600080fd5b50425b6040519081526020015b60405180910390f35b61012d610128366004610a85565b6102ba565b6040516101119190610bbe565b61014d610148366004610a85565b6104ef565b604051610111929190610bd8565b34801561016757600080fd5b50437fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff0140610107565b34801561019d57600080fd5b5046610107565b6101b76101b2366004610c60565b610690565b60405161011193929190610cba565b3480156101d257600080fd5b5048610107565b3480156101e557600080fd5b5043610107565b3480156101f857600080fd5b50610107610207366004610ce2565b73ffffffffffffffffffffffffffffffffffffffff163190565b34801561022d57600080fd5b5044610107565b61012d610242366004610a85565b6106ab565b34801561025357600080fd5b5045610107565b34801561026657600080fd5b50604051418152602001610111565b61012d610283366004610c60565b61085a565b6101b7610296366004610a85565b610a1a565b3480156102a757600080fd5b506101076102b6366004610d18565b4090565b60606000828067ffffffffffffffff8111156102d8576102d8610d31565b60405190808252806020026020018201604052801561031e57816020015b6040805180820190915260008152606060208201528152602001906001900390816102f65790505b5092503660005b8281101561047757600085828151811061034157610341610d60565b6020026020010151905087878381811061035d5761035d610d60565b905060200281019061036f9190610d8f565b6040810135958601959093506103886020850185610ce2565b73ffffffffffffffffffffffffffffffffffffffff16816103ac6060870187610dcd565b6040516103ba929190610e32565b60006040518083038185875af1925050503d80600081146103f7576040519150601f19603f3d011682016040523d82523d6000602084013e6103fc565b606091505b50602080850191909152901515808452908501351761046d577f08c379a000000000000000000000000000000000000000000000000000000000600052602060045260176024527f4d756c746963616c6c333a2063616c6c206661696c656400000000000000000060445260846000fd5b5050600101610325565b508234146104e6576040517f08c379a000000000000000000000000000000000000000000000000000000000815260206004820152601a60248201527f4d756c746963616c6c333a2076616c7565206d69736d6174636800000000000060448201526064015b60405180910390fd5b50505092915050565b436060828067ffffffffffffffff81111561050c5761050c610d31565b60405190808252806020026020018201604052801561053f57816020015b606081526020019060019003908161052a5790505b5091503660005b8281101561068657600087878381811061056257610562610d60565b90506020028101906105749190610e42565b92506105836020840184610ce2565b73ffffffffffffffffffffffffffffffffffffffff166105a66020850185610dcd565b6040516105b4929190610e32565b6000604051808303816000865af19150503d80600081146105f1576040519150601f19603f3d011682016040523d82523d6000602084013e6105f6565b606091505b5086848151811061060957610609610d60565b602090810291909101015290508061067d576040517f08c379a000000000000000000000000000000000000000000000000000000000815260206004820152601760248201527f4d756c746963616c6c333a2063616c6c206661696c656400000000000000000060448201526064016104dd565b50600101610546565b5050509250929050565b43804060606106a086868661085a565b905093509350939050565b6060818067ffffffffffffffff8111156106c7576106c7610d31565b60405190808252806020026020018201604052801561070d57816020015b6040805180820190915260008152606060208201528152602001906001900390816106e55790505b5091503660005b828110156104e657600084828151811061073057610730610d60565b6020026020010151905086868381811061074c5761074c610d60565b905060200281019061075e9190610e76565b925061076d6020840184610ce2565b73ffffffffffffffffffffffffffffffffffffffff166107906040850185610dcd565b60405161079e929190610e32565b6000604051808303816000865af19150503d80600081146107db576040519150601f19603f3d011682016040523d82523d6000602084013e6107e0565b606091505b506020808401919091529015158083529084013517610851577f08c379a000000000000000000000000000000000000000000000000000000000600052602060045260176024527f4d756c746963616c6c333a2063616c6c206661696c656400000000000000000060445260646000fd5b50600101610714565b6060818067ffffffffffffffff81111561087657610876610d31565b6040519080825280602002602001820160405280156108bc57816020015b6040805180820190915260008152606060208201528152602001906001900390816108945790505b5091503660005b82811015610a105760008482815181106108df576108df610d60565b602002602001015190508686838181106108fb576108fb610d60565b905060200281019061090d9190610e42565b925061091c6020840184610ce2565b73ffffffffffffffffffffffffffffffffffffffff1661093f6020850185610dcd565b60405161094d929190610e32565b6000604051808303816000865af19150503d806000811461098a576040519150601f19603f3d011682016040523d82523d6000602084013e61098f565b606091505b506020830152151581528715610a07578051610a07576040517f08c379a000000000000000000000000000000000000000000000000000000000815260206004820152601760248201527f4d756c746963616c6c333a2063616c6c206661696c656400000000000000000060448201526064016104dd565b506001016108c3565b5050509392505050565b6000806060610a2b60018686610690565b919790965090945092505050565b60008083601f840112610a4b57600080fd5b50813567ffffffffffffffff811115610a6357600080fd5b6020830191508360208260051b8501011115610a7e57600080fd5b9250929050565b60008060208385031215610a9857600080fd5b823567ffffffffffffffff811115610aaf57600080fd5b610abb85828601610a39565b90969095509350505050565b6000815180845260005b81811015610aed57602081850181015186830182015201610ad1565b81811115610aff576000602083870101525b50601f017fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffe0169290920160200192915050565b600082825180855260208086019550808260051b84010181860160005b84811015610bb1578583037fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffe001895281518051151584528401516040858501819052610b9d81860183610ac7565b9a86019a9450505090830190600101610b4f565b5090979650505050505050565b602081526000610bd16020830184610b32565b9392505050565b600060408201848352602060408185015281855180845260608601915060608160051b870101935082870160005b82811015610c52577fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffa0888703018452610c40868351610ac7565b95509284019290840190600101610c06565b509398975050505050505050565b600080600060408486031215610c7557600080fd5b83358015158114610c8557600080fd5b9250602084013567ffffffffffffffff811115610ca157600080fd5b610cad86828701610a39565b9497909650939450505050565b838152826020820152606060408201526000610cd96060830184610b32565b95945050505050565b600060208284031215610cf457600080fd5b813573ffffffffffffffffffffffffffffffffffffffff81168114610bd157600080fd5b600060208284031215610d2a57600080fd5b5035919050565b7f4e487b7100000000000000000000000000000000000000000000000000000000600052604160045260246000fd5b7f4e487b7100000000000000000000000000000000000000000000000000000000600052603260045260246000fd5b600082357fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff81833603018112610dc357600080fd5b9190910192915050565b60008083357fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffe1843603018112610e0257600080fd5b83018035915067ffffffffffffffff821115610e1d57600080fd5b602001915036819003821315610a7e57600080fd5b8183823760009101908152919050565b600082357fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffc1833603018112610dc357600080fd5b600082357fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffa1833603018112610dc357600080fdfea2646970667358221220bb2b5c71a328032f97c676ae39a1ec2148d3e5d6f73d95e9b17910152d61f16264736f6c634300080c0033";