Commit 38bf4582 authored by sam-goldman's avatar sam-goldman Committed by GitHub

nft: N-10 Undocumented implicit approval requirements (#3490)

Co-authored-by: default avatarmergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
parent 787564c5
...@@ -95,7 +95,9 @@ contract L1ERC721Bridge is Semver, CrossDomainEnabled, OwnableUpgradeable { ...@@ -95,7 +95,9 @@ contract L1ERC721Bridge is Semver, CrossDomainEnabled, OwnableUpgradeable {
} }
/** /**
* @notice Initiates a bridge of an NFT to the caller's account on L2. * @notice Initiates a bridge of an NFT to the caller's account on L2. Note that the current
* owner of the token on this chain must approve this contract to operate the NFT before
* it can be bridged.
* *
* @param _localToken Address of the ERC721 on this domain. * @param _localToken Address of the ERC721 on this domain.
* @param _remoteToken Address of the ERC721 on the remote domain. * @param _remoteToken Address of the ERC721 on the remote domain.
...@@ -128,7 +130,9 @@ contract L1ERC721Bridge is Semver, CrossDomainEnabled, OwnableUpgradeable { ...@@ -128,7 +130,9 @@ contract L1ERC721Bridge is Semver, CrossDomainEnabled, OwnableUpgradeable {
} }
/** /**
* @notice Initiates a bridge of an NFT to some recipient's account on L2. * @notice Initiates a bridge of an NFT to some recipient's account on L2. Note that the current
* owner of the token on this chain must approve this contract to operate the NFT before
* it can be bridged.
* *
* @param _localToken Address of the ERC721 on this domain. * @param _localToken Address of the ERC721 on this domain.
* @param _remoteToken Address of the ERC721 on the remote domain. * @param _remoteToken Address of the ERC721 on the remote domain.
......
...@@ -109,7 +109,9 @@ contract L2ERC721Bridge is Semver, CrossDomainEnabled, OwnableUpgradeable { ...@@ -109,7 +109,9 @@ contract L2ERC721Bridge is Semver, CrossDomainEnabled, OwnableUpgradeable {
} }
/** /**
* @notice Initiates a bridge of an NFT to the caller's account on L1. * @notice Initiates a bridge of an NFT to the caller's account on L1. Note that the current
* owner of the token on this chain must approve this contract to operate the NFT before
* it can be bridged.
* *
* @param _localToken Address of the ERC721 on this domain. * @param _localToken Address of the ERC721 on this domain.
* @param _remoteToken Address of the ERC721 on the remote domain. * @param _remoteToken Address of the ERC721 on the remote domain.
...@@ -142,7 +144,9 @@ contract L2ERC721Bridge is Semver, CrossDomainEnabled, OwnableUpgradeable { ...@@ -142,7 +144,9 @@ contract L2ERC721Bridge is Semver, CrossDomainEnabled, OwnableUpgradeable {
} }
/** /**
* @notice Initiates a bridge of an NFT to some recipient's account on L1. * @notice Initiates a bridge of an NFT to some recipient's account on L1. Note that the current
* owner of the token on this chain must approve this contract to operate the NFT before
* it can be bridged.
* *
* @param _localToken Address of the ERC721 on this domain. * @param _localToken Address of the ERC721 on this domain.
* @param _remoteToken Address of the ERC721 on the remote domain. * @param _remoteToken Address of the ERC721 on the remote domain.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment