Commit 44655464 authored by coolhill's avatar coolhill

mute boolean-equal, missing-zero-check

parent d35dbe0b
......@@ -44,7 +44,6 @@ contract AddressDictator {
address[] memory _addresses
) {
manager = _manager;
// slither-disable-next-line missing-zero-check
finalOwner = _finalOwner;
require(
_names.length == _addresses.length,
......
......@@ -38,7 +38,6 @@ contract ChugSplashDictator is iL1ChugSplashDeployer {
bytes32 _bridgeSlotVal
) {
target = _target;
// slither-disable-next-line missing-zero-check
finalOwner = _finalOwner;
codeHash = _codeHash;
messengerSlotKey = _messengerSlotKey;
......
......@@ -176,7 +176,6 @@ contract L1CrossDomainMessenger is
_messageNonce
);
// slither-disable-next-line boolean-equal
require(
_verifyXDomainMessage(xDomainCalldata, _proof) == true,
"Provided message could not be verified."
......@@ -184,13 +183,11 @@ contract L1CrossDomainMessenger is
bytes32 xDomainCalldataHash = keccak256(xDomainCalldata);
// slither-disable-next-line boolean-equal
require(
successfulMessages[xDomainCalldataHash] == false,
"Provided message has already been received."
);
// slither-disable-next-line boolean-equal
require(
blockedMessages[xDomainCalldataHash] == false,
"Provided message has been blocked."
......@@ -201,7 +198,6 @@ contract L1CrossDomainMessenger is
"Cannot send L2->L1 messages to L1 system contracts."
);
// slither-disable-next-line missing-zero-check
xDomainMsgSender = _sender;
// slither-disable-next-line reentrancy-no-eth
// slither-disable-next-line reentrancy-events
......@@ -212,7 +208,6 @@ contract L1CrossDomainMessenger is
// Mark the message as received if the call was successful. Ensures that a message can be
// relayed multiple times in the case that the call reverted.
// slither-disable-next-line boolean-equal
if (success == true) {
// slither-disable-next-line reentrancy-no-eth
successfulMessages[xDomainCalldataHash] = true;
......@@ -299,7 +294,6 @@ contract L1CrossDomainMessenger is
* @param _proof Message inclusion proof.
* @return Whether or not the provided proof is valid.
*/
// slither-disable-next-line boolean-equal
function _verifyStateRootProof(L2MessageInclusionProof memory _proof)
internal
view
......@@ -346,7 +340,6 @@ contract L1CrossDomainMessenger is
_proof.stateRoot
);
// slither-disable-next-line boolean-equal
require(
exists == true,
"Message passing predeploy has not been initialized or invalid proof provided."
......
......@@ -50,9 +50,7 @@ contract L1StandardBridge is IL1StandardBridge, CrossDomainEnabled {
// slither-disable-next-line external-function
function initialize(address _l1messenger, address _l2TokenBridge) public {
require(messenger == address(0), "Contract has already been initialized.");
// slither-disable-next-line missing-zero-check
messenger = _l1messenger;
// slither-disable-next-line missing-zero-check
l2TokenBridge = _l2TokenBridge;
}
......@@ -226,7 +224,6 @@ contract L1StandardBridge is IL1StandardBridge, CrossDomainEnabled {
bytes calldata _data
) external onlyFromCrossDomainAccount(l2TokenBridge) {
// slither-disable-next-line reentrancy-events
// slither-disable-next-line missing-zero-check
(bool success, ) = _to.call{ value: _amount }(new bytes(0));
require(success, "TransferHelper::safeTransferETH: ETH transfer failed");
......
......@@ -34,7 +34,6 @@ contract L2CrossDomainMessenger is IL2CrossDomainMessenger {
***************/
constructor(address _l1CrossDomainMessenger) {
// slither-disable-next-line missing-zero-check
l1CrossDomainMessenger = _l1CrossDomainMessenger;
}
......@@ -111,7 +110,6 @@ contract L2CrossDomainMessenger is IL2CrossDomainMessenger {
bytes32 xDomainCalldataHash = keccak256(xDomainCalldata);
// slither-disable-next-line boolean-equal
require(
successfulMessages[xDomainCalldataHash] == false,
"Provided message has already been received."
......@@ -126,7 +124,6 @@ contract L2CrossDomainMessenger is IL2CrossDomainMessenger {
return;
}
// slither-disable-next-line missing-zero-check
xDomainMsgSender = _sender;
// slither-disable-next-line reentrancy-no-eth
// slither-disable-next-line reentrancy-events
......@@ -137,7 +134,6 @@ contract L2CrossDomainMessenger is IL2CrossDomainMessenger {
// Mark the message as received if the call was successful. Ensures that a message can be
// relayed multiple times in the case that the call reverted.
// slither-disable-next-line boolean-equal
if (success == true) {
// slither-disable-next-line reentrancy-no-eth
successfulMessages[xDomainCalldataHash] = true;
......
......@@ -41,7 +41,6 @@ contract L2StandardBridge is IL2ERC20Bridge, CrossDomainEnabled {
constructor(address _l2CrossDomainMessenger, address _l1TokenBridge)
CrossDomainEnabled(_l2CrossDomainMessenger)
{
// slither-disable-next-line missing-zero-check
l1TokenBridge = _l1TokenBridge;
}
......
......@@ -37,7 +37,6 @@ contract OVM_SequencerFeeVault {
* the genesis block. This is ONLY for testing purposes.
*/
constructor(address _l1FeeWallet) {
// slither-disable-next-line missing-zero-check
l1FeeWallet = _l1FeeWallet;
}
......
......@@ -26,7 +26,6 @@ contract CrossDomainEnabled {
* @param _messenger Address of the CrossDomainMessenger on the current layer.
*/
constructor(address _messenger) {
// slither-disable-next-line missing-zero-check
messenger = _messenger;
}
......
......@@ -50,7 +50,6 @@ contract Lib_ResolvedDelegateProxy {
// slither-disable-next-line controlled-delegatecall
(bool success, bytes memory returndata) = target.delegatecall(msg.data);
// slither-disable-next-line boolean-equal
if (success == true) {
assembly {
return(add(returndata, 0x20), mload(returndata))
......
......@@ -20,9 +20,7 @@ contract L2StandardERC20 is IL2StandardERC20, ERC20 {
string memory _name,
string memory _symbol
) ERC20(_name, _symbol) {
// slither-disable-next-line missing-zero-check
l1Token = _l1Token;
// slither-disable-next-line missing-zero-check
l2Bridge = _l2Bridge;
}
......
{
"detectors_to_exclude": "conformance-to-solidity-naming-conventions,assembly-usage,low-level-calls,block-timestamp,pragma,solc-version,too-many-digits",
"detectors_to_exclude": "conformance-to-solidity-naming-conventions,assembly-usage,low-level-calls,block-timestamp,pragma,solc-version,too-many-digits,boolean-equal,missing-zero-check",
"exclude_informational": false,
"exclude_low": false,
"exclude_medium": false,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment