Merge pull request #2366 from ethereum-optimism/sc/fix-base-service-options

fix(cmn): have BaseService throw on missing options

.changeset/sharp-terms-pay.md

+---
+'@eth-optimism/common-ts': patch
+---
+
+Have BaseServiceV2 throw when options are undefined

packages/common-ts/src/base-service/base-service-v2.ts

@@ -218,6 +218,16 @@ export abstract class BaseServiceV2<
       return acc
     }, {}) as TOptions
 
+    // Make sure all options are defined.
+    for (const [optionName, optionSpec] of Object.entries(params.optionsSpec)) {
+      if (
+        optionSpec.default === undefined &&
+        this.options[optionName] === undefined
+      ) {
+        throw new Error(`missing required option: ${optionName}`)
+      }
+    }
+
     // Create the metrics objects.
     this.metrics = Object.keys(params.metricsSpec || {}).reduce((acc, key) => {
       const spec = params.metricsSpec[key]