Commit 5050e0fb authored by smartcontracts's avatar smartcontracts Committed by GitHub

style(ctb): remove errs in virtual fns (#2975)

Removes "not implemented" errors in virtual functions. By removing these
errors, developers will get compile-time errors instead of runtime
errors which are easier to catch.
Co-authored-by: default avatarmergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
parent 3c5726d4
---
'@eth-optimism/contracts-bedrock': patch
---
Remove "not implemented" errors in virtual functions
......@@ -333,9 +333,7 @@ abstract contract CrossDomainMessenger is
* contracts because the logic for this depends on the network where the messenger is
* being deployed.
*/
function _isSystemMessageSender() internal view virtual returns (bool) {
revert("CrossDomainMessenger: child contract must implement");
}
function _isSystemMessageSender() internal view virtual returns (bool);
/**
* @notice Sends a low-level message to the other messenger. Needs to be implemented by child
......@@ -347,7 +345,5 @@ abstract contract CrossDomainMessenger is
uint64 _gasLimit,
uint256 _value,
bytes memory _data
) internal virtual {
revert("CrossDomainMessenger: child contract must implement");
}
) internal virtual;
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment