Commit 599101ca authored by clabby's avatar clabby

Fix John's nits

parent 9f02838a
This diff is collapsed.
This diff is collapsed.
...@@ -197,7 +197,7 @@ contract OptimismPortal is Initializable, ResourceMetering, Semver { ...@@ -197,7 +197,7 @@ contract OptimismPortal is Initializable, ResourceMetering, Semver {
provenWithdrawal.timestamp == 0 || provenWithdrawal.timestamp == 0 ||
(_l2BlockNumber == provenWithdrawal.l2BlockNumber && (_l2BlockNumber == provenWithdrawal.l2BlockNumber &&
outputRoot != provenWithdrawal.outputRoot), outputRoot != provenWithdrawal.outputRoot),
"OptimismPortal: withdrawalHash has already been proven" "OptimismPortal: withdrawal hash has already been proven"
); );
// Verify that the hash of this withdrawal was stored in the L2toL1MessagePasser contract on // Verify that the hash of this withdrawal was stored in the L2toL1MessagePasser contract on
...@@ -214,7 +214,7 @@ contract OptimismPortal is Initializable, ResourceMetering, Semver { ...@@ -214,7 +214,7 @@ contract OptimismPortal is Initializable, ResourceMetering, Semver {
// Designate the withdrawalHash as proven by storing the `outputRoot`, `timestamp`, // Designate the withdrawalHash as proven by storing the `outputRoot`, `timestamp`,
// and `l2BlockNumber` in the `provenWithdrawals` mapping. A withdrawalHash can only // and `l2BlockNumber` in the `provenWithdrawals` mapping. A withdrawalHash can only
// be proven one time to prevent a censorship attack unless it is submitted again // be proven once to prevent a censorship attack unless it is submitted again
// with a different outputRoot. // with a different outputRoot.
provenWithdrawals[withdrawalHash] = ProvenWithdrawal({ provenWithdrawals[withdrawalHash] = ProvenWithdrawal({
outputRoot: outputRoot, outputRoot: outputRoot,
......
...@@ -383,7 +383,7 @@ contract OptimismPortal_FinalizeWithdrawal_Test is Portal_Initializer { ...@@ -383,7 +383,7 @@ contract OptimismPortal_FinalizeWithdrawal_Test is Portal_Initializer {
_withdrawalProof _withdrawalProof
); );
vm.expectRevert("OptimismPortal: withdrawalHash has already been proven"); vm.expectRevert("OptimismPortal: withdrawal hash has already been proven");
op.proveWithdrawalTransaction( op.proveWithdrawalTransaction(
_defaultTx, _defaultTx,
_proposedBlockNumber, _proposedBlockNumber,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment