Merge pull request #4333 from ethereum-optimism/sc/cmn-options-fix

fix(cmn): BaseServiceV2 options parsing bug

.changeset/cool-bears-return.md

+---
+'@eth-optimism/common-ts': patch
+---
+
+Fixes a bug in BaseServiceV2 where options were not being parsed correctly when passed into the constructor rather than via environment variables or command line arguments

packages/common-ts/src/base-service/base-service-v2.ts

@@ -281,17 +281,13 @@ export abstract class BaseServiceV2<
     // names into lower case for the validation step. We'll turn the names back into their original
     // names when we're done.
     const cleaned = cleanEnv<TOptions>(
-      { ...config.env, ...config.args },
+      { ...config.env, ...config.args, ...(params.options || {}) },
       Object.entries(params.optionsSpec || {}).reduce((acc, [key, val]) => {
         acc[key.toLowerCase()] = val.validator({
           desc: val.desc,
           default: val.default,
         })
         return acc
-      }, {}) as any,
-      Object.entries(params.options || {}).reduce((acc, [key, val]) => {
-        acc[key.toLowerCase()] = val
-        return acc
       }, {}) as any
     )