Merge pull request #7455 from ethereum-optimism/fix-global-test-log

op-e2e: move global logger init, detach from tests

op-e2e/config/init.go

@@ -16,6 +16,7 @@ import (
 
 	"github.com/ethereum-optimism/optimism/op-chain-ops/genesis"
 	"github.com/ethereum-optimism/optimism/op-e2e/external"
+	oplog "github.com/ethereum-optimism/optimism/op-service/log"
 )
 
 var (
@@ -65,6 +66,23 @@ func init() {
 	testing.Init() // Register test flags before parsing
 	flag.Parse()
 
+	// Setup global logger
+	lvl := log.Lvl(EthNodeVerbosity)
+	if lvl < log.LvlCrit {
+		log.Root().SetHandler(log.DiscardHandler())
+	} else if lvl > log.LvlTrace { // clip to trace level
+		lvl = log.LvlTrace
+	}
+	// We cannot attach a testlog logger,
+	// because the global logger is shared between different independent parallel tests.
+	// Tests that write to a testlogger of another finished test fail.
+	h := oplog.NewLogHandler(os.Stdout, oplog.CLIConfig{
+		Level:  lvl,
+		Color:  false, // some CI logs do not handle colors well
+		Format: oplog.FormatTerminal,
+	})
+	oplog.SetGlobalLogHandler(h)
+
 	if err := allExist(l1AllocsPath, l1DeploymentsPath, deployConfigPath); err != nil {
 		return
 	}

op-e2e/helper.go

@@ -3,12 +3,6 @@ package op_e2e
 import (
 	"os"
 	"testing"
-
-	"github.com/ethereum/go-ethereum/log"
-
-	"github.com/ethereum-optimism/optimism/op-e2e/config"
-	oplog "github.com/ethereum-optimism/optimism/op-service/log"
-	"github.com/ethereum-optimism/optimism/op-service/testlog"
 )
 
 var enableParallelTesting bool = os.Getenv("OP_E2E_DISABLE_PARALLEL") != "true"
@@ -18,12 +12,4 @@ func InitParallel(t *testing.T) {
 	if enableParallelTesting {
 		t.Parallel()
 	}
-	lvl := log.Lvl(config.EthNodeVerbosity)
-	if lvl < log.LvlCrit {
-		log.Root().SetHandler(log.DiscardHandler())
-	} else if lvl > log.LvlTrace { // clip to trace level
-		lvl = log.LvlTrace
-	}
-	h := testlog.Handler(t, lvl, log.TerminalFormat(false)) // some CI logs do not handle colors well
-	oplog.SetGlobalLogHandler(h)
 }