Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
N
nebula
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
exchain
nebula
Commits
6368229c
Unverified
Commit
6368229c
authored
Oct 24, 2023
by
Maurelian
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
refactor(ctb): Make function _isAboveMinOwners
parent
7f474593
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
4 deletions
+4
-4
LivenessModule.sol
packages/contracts-bedrock/src/Safe/LivenessModule.sol
+4
-4
No files found.
packages/contracts-bedrock/src/Safe/LivenessModule.sol
View file @
6368229c
...
...
@@ -79,7 +79,7 @@ contract LivenessModule is ISemver {
address[] memory owners = safe.getOwners();
uint256 numOwners = owners.length - 1;
uint256 thresholdAfter;
if (
has
MinOwners(numOwners)) {
if (
_isAbove
MinOwners(numOwners)) {
// Call the Safe to remove the owner and update the threshold
thresholdAfter = get75PercentThreshold(numOwners);
address prevOwner = _getPrevOwner(owner, owners);
...
...
@@ -135,8 +135,8 @@ contract LivenessModule is ISemver {
address[] memory owners = safe.getOwners();
uint256 numOwners = owners.length;
require(
has
MinOwners(numOwners) || (numOwners == 1 && owners[0] == fallbackOwner),
"LivenessModule: Safe must have the minimum number of owners
,
or be owned solely by the fallback owner"
_isAbove
MinOwners(numOwners) || (numOwners == 1 && owners[0] == fallbackOwner),
"LivenessModule: Safe must have the minimum number of owners or be owned solely by the fallback owner"
);
// Check that the threshold is correct. This check is also correct when there is a single
...
...
@@ -180,7 +180,7 @@ contract LivenessModule is ISemver {
/// @notice Check if the number of owners is greater than or equal to the minimum number of owners.
/// @param numOwners The number of owners.
/// @return A boolean indicating if the number of owners is greater than or equal to the minimum number of owners.
function
hasMinOwners(uint256 numOwners) public
view returns (bool) {
function
_isAboveMinOwners(uint256 numOwners) internal
view returns (bool) {
return numOwners >= minOwners;
}
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment