ci: enable devnet deploy (#4059)

.circleci/config.yml

@@ -844,9 +844,9 @@ workflows:
       - depcheck:
           requires:
             - yarn-monorepo
-      # - devnet:
-      #     name: devnet (with deployed contracts)
-      #     deploy: true
+      - devnet:
+          name: devnet (with deployed contracts)
+          deploy: true
       - devnet:
           name: devnet (with genesis contracts)
           deploy: false

bedrock-devnet/devnet/__init__.py

@@ -80,8 +80,8 @@ def main():
             'CanonicalTransactionChain': '0x0000000000000000000000000000000000000000',
             'BondManager': '0x0000000000000000000000000000000000000000',
         })
-        sdk_addresses['L1CrossDomainMessenger'] = addresses['L1CrossDomainMessengerProxy']
-        sdk_addresses['L1StandardBridge'] = addresses['L1StandardBridgeProxy']
+        sdk_addresses['L1CrossDomainMessenger'] = addresses['Proxy__OVM_L1CrossDomainMessenger']
+        sdk_addresses['L1StandardBridge'] = addresses['Proxy__OVM_L1StandardBridge']
         sdk_addresses['OptimismPortal'] = addresses['OptimismPortalProxy']
         sdk_addresses['L2OutputOracle'] = addresses['L2OutputOracleProxy']
         write_json(addresses_json_path, addresses)

packages/contracts-bedrock/deploy/018-MigrationSystemDictatorSteps.ts

@@ -37,6 +37,22 @@ const deployFn: DeployFunction = async (hre) => {
     }
   }
 
+  let finalOwner = hre.deployConfig.finalSystemOwner
+  if (finalOwner === ethers.constants.AddressZero) {
+    if (hre.network.config.live === false) {
+      console.log(`WARNING!!!`)
+      console.log(`WARNING!!!`)
+      console.log(`WARNING!!!`)
+      console.log(`WARNING!!! A proxy admin owner address was not provided.`)
+      console.log(
+        `WARNING!!! Make sure you are ONLY doing this on a test network.`
+      )
+      finalOwner = deployer
+    } else {
+      throw new Error(`must specify the finalSystemOwner on live networks`)
+    }
+  }
+
   // Set up required contract references.
   const [
     MigrationSystemDictator,
@@ -378,17 +394,9 @@ const deployFn: DeployFunction = async (hre) => {
       return MigrationSystemDictator.finalized()
     })
 
-    await assertContractVariable(
-      L1CrossDomainMessenger,
-      'owner',
-      hre.deployConfig.finalSystemOwner
-    )
+    await assertContractVariable(L1CrossDomainMessenger, 'owner', finalOwner)
 
-    await assertContractVariable(
-      ProxyAdmin,
-      'owner',
-      hre.deployConfig.finalSystemOwner
-    )
+    await assertContractVariable(ProxyAdmin, 'owner', finalOwner)
   }
 }