Merge pull request #4326 from ethereum-optimism/fix/migration-gaslimit

fix: migration gaslimit

.changeset/perfect-guests-relax.md

+---
+'@eth-optimism/sdk': patch
+---
+
+Don't pass 0 gasLimit for migrated withdrawals

op-chain-ops/crossdomain/migrate.go

@@ -64,6 +64,8 @@ func MigrateWithdrawal(withdrawal *LegacyWithdrawal, l1CrossDomainMessenger *com
 	}
 
 	versionedNonce := EncodeVersionedNonce(withdrawal.Nonce, common.Big1)
+	// Encode the call to `relayMessage` on the `CrossDomainMessenger`.
+	// The minGasLimit can safely be 0 here.
 	data, err := abi.Pack(
 		"relayMessage",
 		versionedNonce,
@@ -77,12 +79,15 @@ func MigrateWithdrawal(withdrawal *LegacyWithdrawal, l1CrossDomainMessenger *com
 		return nil, fmt.Errorf("cannot abi encode relayMessage: %w", err)
 	}
 
+	// Set the outer gas limit. This cannot be zero
+	gasLimit := uint64(len(data)*16 + 200_000)
+
 	w := NewWithdrawal(
 		withdrawal.Nonce,
 		&predeploys.L2CrossDomainMessengerAddr,
 		l1CrossDomainMessenger,
 		value,
-		new(big.Int),
+		new(big.Int).SetUint64(gasLimit),
 		data,
 	)
 	return w, nil

packages/sdk/src/cross-chain-messenger.ts

@@ -18,6 +18,7 @@ import {
   sleep,
   remove0x,
   toHexString,
+  fromHexString,
   toRpcHexString,
   hashCrossDomainMessage,
   encodeCrossDomainMessageV0,
@@ -351,10 +352,12 @@ export class CrossChainMessenger {
       }
     }
 
+    const minGasLimit = fromHexString(resolved.message).length * 16 + 200_000
+
     return {
       ...resolved,
       value,
-      minGasLimit: BigNumber.from(0),
+      minGasLimit: BigNumber.from(minGasLimit),
       messageNonce: encodeVersionedNonce(
         BigNumber.from(1),
         resolved.messageNonce