Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
N
nebula
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
exchain
nebula
Commits
77d35a51
Unverified
Commit
77d35a51
authored
Nov 26, 2024
by
Matthew Slipper
Committed by
GitHub
Nov 26, 2024
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
op-batcher: Don't log DA post failures on context cancel (#13089)
This was causing flakes.
parent
f25db964
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
8 additions
and
2 deletions
+8
-2
driver.go
op-batcher/batcher/driver.go
+5
-1
concurrent_test.go
op-e2e/system/altda/concurrent_test.go
+3
-1
No files found.
op-batcher/batcher/driver.go
View file @
77d35a51
...
...
@@ -782,7 +782,11 @@ func (l *BatchSubmitter) publishToAltDAAndL1(txdata txData, queue *txmgr.Queue[t
// So we prefer to mimic the behavior of txmgr and cancel all pending DA/txmgr requests when the batcher is stopped.
comm
,
err
:=
l
.
AltDA
.
SetInput
(
l
.
shutdownCtx
,
txdata
.
CallData
())
if
err
!=
nil
{
// Don't log context cancelled events because they are expected,
// and can happen after tests complete which causes a panic.
if
!
errors
.
Is
(
err
,
context
.
Canceled
)
{
l
.
Log
.
Error
(
"Failed to post input to Alt DA"
,
"error"
,
err
)
}
// requeue frame if we fail to post to the DA Provider so it can be retried
// note: this assumes that the da server caches requests, otherwise it might lead to resubmissions of the blobs
l
.
recordFailedDARequest
(
txdata
.
ID
(),
err
)
...
...
op-e2e/system/altda/concurrent_test.go
View file @
77d35a51
...
...
@@ -34,7 +34,9 @@ func TestBatcherConcurrentAltDARequests(t *testing.T) {
cfg
.
DisableBatcher
=
true
sys
,
err
:=
cfg
.
Start
(
t
)
require
.
NoError
(
t
,
err
,
"Error starting up system"
)
defer
sys
.
Close
()
t
.
Cleanup
(
func
()
{
sys
.
Close
()
})
// make every request take 5 seconds, such that only concurrent requests will be able to make progress fast enough
sys
.
FakeAltDAServer
.
SetPutRequestLatency
(
5
*
time
.
Second
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment