Update TestUniqueFlags to check for uniqueness in aliases (#8661)

op-batcher/flags/flags_test.go

@@ -26,13 +26,14 @@ func TestOptionalFlagsDontSetRequired(t *testing.T) {
 func TestUniqueFlags(t *testing.T) {
 	seenCLI := make(map[string]struct{})
 	for _, flag := range Flags {
-		name := flag.Names()[0]
+		for _, name := range flag.Names() {
 			if _, ok := seenCLI[name]; ok {
 				t.Errorf("duplicate flag %s", name)
 				continue
 			}
 			seenCLI[name] = struct{}{}
 		}
+	}
 }
 
 // TestBetaFlags test that all flags starting with "beta." have "BETA_" in the env var, and vice versa.

op-challenger/flags/flags_test.go

@@ -17,13 +17,14 @@ import (
 func TestUniqueFlags(t *testing.T) {
 	seenCLI := make(map[string]struct{})
 	for _, flag := range Flags {
-		name := flag.Names()[0]
+		for _, name := range flag.Names() {
 			if _, ok := seenCLI[name]; ok {
 				t.Errorf("duplicate flag %s", name)
 				continue
 			}
 			seenCLI[name] = struct{}{}
 		}
+	}
 }
 
 // TestUniqueEnvVars asserts that all flag env vars are unique, to avoid accidental conflicts between the many flags.

op-node/flags/flags_test.go

@@ -25,13 +25,14 @@ func TestOptionalFlagsDontSetRequired(t *testing.T) {
 func TestUniqueFlags(t *testing.T) {
 	seenCLI := make(map[string]struct{})
 	for _, flag := range Flags {
-		name := flag.Names()[0]
+		for _, name := range flag.Names() {
 			if _, ok := seenCLI[name]; ok {
 				t.Errorf("duplicate flag %s", name)
 				continue
 			}
 			seenCLI[name] = struct{}{}
 		}
+	}
 }
 
 // TestBetaFlags test that all flags starting with "beta." have "BETA_" in the env var, and vice versa.

op-program/host/flags/flags_test.go

@@ -12,13 +12,14 @@ import (
 func TestUniqueFlags(t *testing.T) {
 	seenCLI := make(map[string]struct{})
 	for _, flag := range Flags {
-		name := flag.Names()[0]
+		for _, name := range flag.Names() {
 			if _, ok := seenCLI[name]; ok {
 				t.Errorf("duplicate flag %s", name)
 				continue
 			}
 			seenCLI[name] = struct{}{}
 		}
+	}
 }
 
 // TestUniqueEnvVars asserts that all flag env vars are unique, to avoid accidental conflicts between the many flags.

op-proposer/flags/flags_test.go

@@ -26,13 +26,14 @@ func TestOptionalFlagsDontSetRequired(t *testing.T) {
 func TestUniqueFlags(t *testing.T) {
 	seenCLI := make(map[string]struct{})
 	for _, flag := range Flags {
-		name := flag.Names()[0]
+		for _, name := range flag.Names() {
 			if _, ok := seenCLI[name]; ok {
 				t.Errorf("duplicate flag %s", name)
 				continue
 			}
 			seenCLI[name] = struct{}{}
 		}
+	}
 }
 
 // TestBetaFlags test that all flags starting with "beta." have "BETA_" in the env var, and vice versa.