Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
N
nebula
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
exchain
nebula
Commits
9aaaf1f4
Commit
9aaaf1f4
authored
Dec 03, 2022
by
Matthew Slipper
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
op-chain-ops: Remove inconsistent ownership config fields
parent
621cb287
Changes
6
Show whitespace changes
Inline
Side-by-side
Showing
6 changed files
with
11 additions
and
14 deletions
+11
-14
config.go
op-chain-ops/genesis/config.go
+6
-6
layer_one.go
op-chain-ops/genesis/layer_one.go
+1
-1
test-deploy-config-full.json
op-chain-ops/genesis/testdata/test-deploy-config-full.json
+2
-2
setup.go
op-e2e/e2eutils/setup.go
+0
-1
setup.go
op-e2e/setup.go
+0
-2
devnetL1.json
packages/contracts-bedrock/deploy-config/devnetL1.json
+2
-2
No files found.
op-chain-ops/genesis/config.go
View file @
9aaaf1f4
...
...
@@ -72,8 +72,8 @@ type DeployConfig struct {
// Owner of the ProxyAdmin predeploy
ProxyAdminOwner
common
.
Address
`json:"proxyAdminOwner"`
// Owner of the
L1CrossDomainMessenger predeploy
L2CrossDomainMessengerOwner
common
.
Address
`json:"l2CrossDomainMessenger
Owner"`
// Owner of the
system on L1
FinalSystemOwner
common
.
Address
`json:"finalSystem
Owner"`
// L1 recipient of fees accumulated in the BaseFeeVault
BaseFeeVaultRecipient
common
.
Address
`json:"baseFeeVaultRecipient"`
// L1 recipient of fees accumulated in the L1FeeVault
...
...
@@ -149,12 +149,12 @@ func (d *DeployConfig) Check() error {
if
d
.
SystemConfigOwner
==
(
common
.
Address
{})
{
return
fmt
.
Errorf
(
"%w: SystemConfigOwner cannot be address(0)"
,
ErrInvalidDeployConfig
)
}
if
d
.
FinalSystemOwner
==
(
common
.
Address
{})
{
return
fmt
.
Errorf
(
"%w: FinalSystemOwner cannot be address(0)"
,
ErrInvalidDeployConfig
)
}
if
d
.
ProxyAdminOwner
==
(
common
.
Address
{})
{
return
fmt
.
Errorf
(
"%w: ProxyAdminOwner cannot be address(0)"
,
ErrInvalidDeployConfig
)
}
if
d
.
L2CrossDomainMessengerOwner
==
(
common
.
Address
{})
{
return
fmt
.
Errorf
(
"%w: L2CrossDomainMessengerOwner cannot be address(0)"
,
ErrInvalidDeployConfig
)
}
if
d
.
BaseFeeVaultRecipient
==
(
common
.
Address
{})
{
log
.
Warn
(
"BaseFeeVaultRecipient is address(0)"
)
}
...
...
@@ -385,7 +385,7 @@ func NewL2StorageConfig(config *DeployConfig, block *types.Block) (state.Storage
}
storage
[
"L2CrossDomainMessenger"
]
=
state
.
StorageValues
{
"_initialized"
:
1
,
"_owner"
:
config
.
L2CrossDomainMessenger
Owner
,
"_owner"
:
config
.
ProxyAdmin
Owner
,
// re-entrency lock
"_status"
:
1
,
"_initializing"
:
false
,
...
...
op-chain-ops/genesis/layer_one.go
View file @
9aaaf1f4
...
...
@@ -141,7 +141,7 @@ func BuildL1DeveloperGenesis(config *DeployConfig) (*core.Genesis, error) {
}
data
,
err
=
l1XDMABI
.
Pack
(
"initialize"
,
config
.
ProxyAdmin
Owner
,
config
.
FinalSystem
Owner
,
)
if
err
!=
nil
{
return
nil
,
err
...
...
op-chain-ops/genesis/testdata/test-deploy-config-full.json
View file @
9aaaf1f4
...
...
@@ -19,6 +19,7 @@
"cliqueSignerAddress"
:
"0x0000000000000000000000000000000000000000"
,
"l1GenesisBlockGasLimit"
:
"0xe4e1c0"
,
"l1GenesisBlockDifficulty"
:
"0x1"
,
"finalSystemOwner"
:
"0x0000000000000000000000000000000000000111"
,
"finalizationPeriodSeconds"
:
2
,
"l1GenesisBlockMixHash"
:
"0x0000000000000000000000000000000000000000000000000000000000000000"
,
"l1GenesisBlockCoinbase"
:
"0x0000000000000000000000000000000000000000"
,
...
...
@@ -37,7 +38,6 @@
"l2GenesisBlockGasUsed"
:
"0x0"
,
"l2GenesisBlockParentHash"
:
"0x0000000000000000000000000000000000000000000000000000000000000000"
,
"l2GenesisBlockBaseFeePerGas"
:
"0x3b9aca00"
,
"l2CrossDomainMessengerOwner"
:
"0x42000000000000000000000000000000000000f2"
,
"baseFeeVaultRecipient"
:
"0x42000000000000000000000000000000000000f5"
,
"l1FeeVaultRecipient"
:
"0x42000000000000000000000000000000000000f6"
,
"sequencerFeeVaultRecipient"
:
"0x42000000000000000000000000000000000000f7"
,
...
...
@@ -46,7 +46,7 @@
"l1ERC721BridgeProxy"
:
"0x4200000000000000000000000000000000000060"
,
"systemConfigProxy"
:
"0x4200000000000000000000000000000000000061"
,
"optimismPortalProxy"
:
"0x4200000000000000000000000000000000000062"
,
"proxyAdminOwner"
:
"0x0000000000000000000000000000000000000
000
"
,
"proxyAdminOwner"
:
"0x0000000000000000000000000000000000000
222
"
,
"gasPriceOracleOverhead"
:
2100
,
"gasPriceOracleScalar"
:
1000000
,
"deploymentWaitConfirmations"
:
1
,
...
...
op-e2e/e2eutils/setup.go
View file @
9aaaf1f4
...
...
@@ -98,7 +98,6 @@ func MakeDeployParams(t require.TestingT, tp *TestParams) *DeployParams {
L2GenesisBlockParentHash
:
common
.
Hash
{},
L2GenesisBlockBaseFeePerGas
:
uint64ToBig
(
1000
_000_000
),
L2CrossDomainMessengerOwner
:
common
.
Address
{
0
:
0x42
,
19
:
0xf2
},
// tbd
GasPriceOracleOverhead
:
2100
,
GasPriceOracleScalar
:
1000
_000
,
DeploymentWaitConfirmations
:
1
,
...
...
op-e2e/setup.go
View file @
9aaaf1f4
...
...
@@ -90,8 +90,6 @@ func DefaultSystemConfig(t *testing.T) SystemConfig {
L2GenesisBlockParentHash
:
common
.
Hash
{},
L2GenesisBlockBaseFeePerGas
:
uint642big
(
7
),
L2CrossDomainMessengerOwner
:
common
.
Address
{
0
:
0x52
,
19
:
0xf3
},
// tbd
GasPriceOracleOverhead
:
2100
,
GasPriceOracleScalar
:
1
_000_000
,
...
...
packages/contracts-bedrock/deploy-config/devnetL1.json
View file @
9aaaf1f4
...
...
@@ -21,7 +21,7 @@
"l1FeeVaultRecipient"
:
"0x71bE63f3384f5fb98995898A86B02Fb2426c5788"
,
"sequencerFeeVaultRecipient"
:
"0xfabb0ac9d68b0b445fb7357272ff202c5651694a"
,
"proxyAdminOwner"
:
"0xBcd4042DE499D14e55001CcbB24a551F3b954096"
,
"
l2CrossDomainMessenger
Owner"
:
"0xBcd4042DE499D14e55001CcbB24a551F3b954096"
,
"
finalSystem
Owner"
:
"0xBcd4042DE499D14e55001CcbB24a551F3b954096"
,
"finalizationPeriodSeconds"
:
2
,
"deploymentWaitConfirmations"
:
1
,
"fundDevAccounts"
:
true
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment