From ac02d49ee6f712d2891b092e2aae30c876225bf2 Mon Sep 17 00:00:00 2001
From: clabby <ben@clab.by>
Date: Mon, 31 Jul 2023 15:11:39 -0400
Subject: [PATCH] review: Add comment about bubbled up revert in
`FaultDisputeGame.initialize`
---
packages/contracts-bedrock/src/dispute/FaultDisputeGame.sol | 3 +++
1 file changed, 3 insertions(+)
diff --git a/packages/contracts-bedrock/src/dispute/FaultDisputeGame.sol b/packages/contracts-bedrock/src/dispute/FaultDisputeGame.sol
index 29e7dfbcf..a377f4c97 100644
--- a/packages/contracts-bedrock/src/dispute/FaultDisputeGame.sol
+++ b/packages/contracts-bedrock/src/dispute/FaultDisputeGame.sol
@@ -439,6 +439,9 @@ contract FaultDisputeGame is IFaultDisputeGame, Clone, Semver {
);
// Set the L1 head hash to the block hash of the L1 block number provided.
+ // This call can revert if the block hash oracle does not have information
+ // about the block number provided to it. This revert will bubble up to the
+ // DisputeGameFactory and prevent the game from being created.
l1Head = BLOCK_HASH_ORACLE.load(_getArgUint256(0x40));
}
--
2.23.0