ctb: Fix L2OutputOracle test names

packages/contracts-bedrock/.gas-snapshot

@@ -69,46 +69,46 @@ L1StandardBridge_FinalizeETHWithdrawal_Test:test_finalizeETHWithdrawal_succeeds(
 L1StandardBridge_Getter_Test:test_getters_succeeds() (gas: 31449)
 L1StandardBridge_Initialize_Test:test_initialize_succeeds() (gas: 22005)
 L1StandardBridge_Receive_Test:test_receive_succeeds() (gas: 514475)
-L2CrossDomainMessenger_Test:testCannot_L2MessengerPause() (gas: 10860)
-L2CrossDomainMessenger_Test:test_L1MessengerRelayMessageRevertsOnReentrancy() (gas: 167775)
-L2CrossDomainMessenger_Test:test_L2MessengerMessageVersion() (gas: 8389)
-L2CrossDomainMessenger_Test:test_L2MessengerPause() (gas: 31802)
-L2CrossDomainMessenger_Test:test_L2MessengerRelayMessageFirstStuckSecondSucceeds() (gas: 168269)
-L2CrossDomainMessenger_Test:test_L2MessengerRelayMessageSucceeds() (gas: 53204)
-L2CrossDomainMessenger_Test:test_L2MessengerRelayMessageToSystemContract() (gas: 36172)
-L2CrossDomainMessenger_Test:test_L2MessengerRelayMessageV0Fails() (gas: 18870)
-L2CrossDomainMessenger_Test:test_L2MessengerRelayShouldRevertIfPaused() (gas: 41596)
-L2CrossDomainMessenger_Test:test_L2MessengerSendMessage() (gas: 122533)
-L2CrossDomainMessenger_Test:test_L2MessengerTwiceSendMessage() (gas: 134716)
-L2CrossDomainMessenger_Test:test_L2MessengerXDomainSenderReverts() (gas: 10568)
-L2CrossDomainMessenger_Test:test_L2MessengerxDomainMessageSenderResets() (gas: 52615)
-L2OutputOracleTest:testCannot_ProposeWithUnmatchedBlockhash() (gas: 29434)
-L2OutputOracleTest:testCannot_constructWithBadTimestamp() (gas: 70674)
-L2OutputOracleTest:testCannot_deleteL2Outputs_afterLatest() (gas: 200324)
-L2OutputOracleTest:testCannot_deleteL2Outputs_ifNotChallenger() (gas: 18915)
-L2OutputOracleTest:testCannot_deleteL2Outputs_nonExistent() (gas: 103509)
-L2OutputOracleTest:testCannot_proposeEmptyOutput() (gas: 26721)
-L2OutputOracleTest:testCannot_proposeFutureTimetamp() (gas: 28678)
-L2OutputOracleTest:testCannot_proposeL2Output_ifNotProposer() (gas: 25782)
-L2OutputOracleTest:testCannot_proposeOnWrongFork() (gas: 28941)
-L2OutputOracleTest:testCannot_proposeUnexpectedBlockNumber() (gas: 28382)
-L2OutputOracleTest:test_computeL2Timestamp() (gas: 37185)
-L2OutputOracleTest:test_constructor() (gas: 33715)
-L2OutputOracleTest:test_deleteOutputs_multipleOutputs() (gas: 286718)
-L2OutputOracleTest:test_deleteOutputs_singleOutput() (gas: 173018)
-L2OutputOracleTest:test_getL2Output() (gas: 101700)
-L2OutputOracleTest:test_getL2OutputIndexAfter_multipleOutputsExist() (gas: 267181)
-L2OutputOracleTest:test_getL2OutputIndexAfter_noOutputsExist() (gas: 17938)
+L2CrossDomainMessenger_Test:test_messageVersion_succeeds() (gas: 8367)
+L2CrossDomainMessenger_Test:test_pause_notOwner_reverts() (gas: 10859)
+L2CrossDomainMessenger_Test:test_pause_succeeds() (gas: 31846)
+L2CrossDomainMessenger_Test:test_relayMessage_paused_reverts() (gas: 41596)
+L2CrossDomainMessenger_Test:test_relayMessage_reentrancy_reverts() (gas: 167766)
+L2CrossDomainMessenger_Test:test_relayMessage_retry_succeeds() (gas: 168292)
+L2CrossDomainMessenger_Test:test_relayMessage_succeeds() (gas: 53183)
+L2CrossDomainMessenger_Test:test_relayMessage_toSystemContract_reverts() (gas: 36194)
+L2CrossDomainMessenger_Test:test_relayMessage_v0_reverts() (gas: 18870)
+L2CrossDomainMessenger_Test:test_sendMessage_succeeds() (gas: 122533)
+L2CrossDomainMessenger_Test:test_sendMessage_twice_succeeds() (gas: 134671)
+L2CrossDomainMessenger_Test:test_xDomainMessageSender_reset_succeeds() (gas: 52594)
+L2CrossDomainMessenger_Test:test_xDomainSender_senderNotSet_reverts() (gas: 10524)
+L2OutputOracleTest:test_computeL2Timestamp_succeeds() (gas: 37184)
+L2OutputOracleTest:test_constructor_badTimestamp_reverts() (gas: 70717)
+L2OutputOracleTest:test_constructor_succeeds() (gas: 33760)
+L2OutputOracleTest:test_deleteL2Outputs_afterLatest_reverts() (gas: 200230)
+L2OutputOracleTest:test_deleteL2Outputs_ifNotChallenger_reverts() (gas: 18883)
+L2OutputOracleTest:test_deleteL2Outputs_nonExistent_reverts() (gas: 103402)
+L2OutputOracleTest:test_deleteOutputs_multipleOutputs_succeeds() (gas: 286560)
+L2OutputOracleTest:test_deleteOutputs_singleOutput_succeeds() (gas: 172876)
+L2OutputOracleTest:test_getL2OutputIndexAfter_multipleOutputsExist_succeeds() (gas: 267182)
+L2OutputOracleTest:test_getL2OutputIndexAfter_noOutputsExis_reverts() (gas: 17914)
 L2OutputOracleTest:test_getL2OutputIndexAfter_previousBlock_succeeds() (gas: 96086)
 L2OutputOracleTest:test_getL2OutputIndexAfter_sameBlock_succeeds() (gas: 95994)
-L2OutputOracleTest:test_latestBlockNumber() (gas: 96937)
-L2OutputOracleTest:test_nextBlockNumber() (gas: 17468)
-L2OutputOracleTest:test_proposeWithBlockhashAndHeight() (gas: 95251)
-L2OutputOracleTest:test_proposingAnotherOutput() (gas: 97175)
-L2OutputOracleUpgradeable_Test:test_cannotInitImpl() (gas: 15171)
-L2OutputOracleUpgradeable_Test:test_cannotInitProxy() (gas: 20152)
-L2OutputOracleUpgradeable_Test:test_initValuesOnProxy() (gas: 26052)
-L2OutputOracleUpgradeable_Test:test_upgrading() (gas: 180457)
+L2OutputOracleTest:test_getL2Output_succeeds() (gas: 101699)
+L2OutputOracleTest:test_latestBlockNumber_succeeds() (gas: 96983)
+L2OutputOracleTest:test_nextBlockNumber_succeeds() (gas: 17468)
+L2OutputOracleTest:test_proposeL2Output_emptyOutput_reverts() (gas: 26688)
+L2OutputOracleTest:test_proposeL2Output_futureTimetamp_reverts() (gas: 28646)
+L2OutputOracleTest:test_proposeL2Output_notProposer_reverts() (gas: 25782)
+L2OutputOracleTest:test_proposeL2Output_proposeAnotherOutput_succeeds() (gas: 97137)
+L2OutputOracleTest:test_proposeL2Output_unexpectedBlockNumber_reverts() (gas: 28402)
+L2OutputOracleTest:test_proposeL2Output_unmatchedBlockhash_reverts() (gas: 29446)
+L2OutputOracleTest:test_proposeL2Output_wrongFork_reverts() (gas: 29005)
+L2OutputOracleTest:test_proposeWithBlockhashAndHeight_succeeds() (gas: 95296)
+L2OutputOracleUpgradeable_Test:test_initValuesOnProxy_succeeds() (gas: 26096)
+L2OutputOracleUpgradeable_Test:test_initializeImpl_alreadyInitialized_reverts() (gas: 15149)
+L2OutputOracleUpgradeable_Test:test_initializeProxy_alreadyInitialized_reverts() (gas: 20131)
+L2OutputOracleUpgradeable_Test:test_upgrading_succeeds() (gas: 180413)
 L2StandardBridge_Test:test_finalizeBridgeETH_incorrectValue_reverts() (gas: 23788)
 L2StandardBridge_Test:test_finalizeBridgeETH_sendToMessenger_reverts() (gas: 23927)
 L2StandardBridge_Test:test_finalizeBridgeETH_sendToSelf_reverts() (gas: 23838)
@@ -122,30 +122,30 @@ L2StandardBridge_Test:test_withdraw_succeeds() (gas: 343975)
 L2ToL1MessagePasserTest:test_burn_succeeds() (gas: 112572)
 L2ToL1MessagePasserTest:test_initiateWithdrawal_fromContract_succeeds() (gas: 70423)
 L2ToL1MessagePasserTest:test_initiateWithdrawal_fromEOA_succeeds() (gas: 75874)
-LegacyERC20ETH_Test:test_approve() (gas: 10723)
-LegacyERC20ETH_Test:test_burn() (gas: 10615)
-LegacyERC20ETH_Test:test_crossDomain() (gas: 6339)
-LegacyERC20ETH_Test:test_decreaseAllowance() (gas: 10657)
-LegacyERC20ETH_Test:test_increaseAllowance() (gas: 10667)
-LegacyERC20ETH_Test:test_metadata() (gas: 15414)
-LegacyERC20ETH_Test:test_mint() (gas: 10649)
-LegacyERC20ETH_Test:test_transfer() (gas: 10711)
-LegacyERC20ETH_Test:test_transferFrom() (gas: 12887)
+LegacyERC20ETH_Test:test_approve_doesNotExist_reverts() (gas: 10701)
+LegacyERC20ETH_Test:test_burn_doesNotExist_reverts() (gas: 10615)
+LegacyERC20ETH_Test:test_crossDomain_succeeds() (gas: 6362)
+LegacyERC20ETH_Test:test_decreaseAllowance_doesNotExist_reverts() (gas: 10679)
+LegacyERC20ETH_Test:test_increaseAllowance_doesNotExist_reverts() (gas: 10689)
+LegacyERC20ETH_Test:test_metadata_succeeds() (gas: 15414)
+LegacyERC20ETH_Test:test_mint_doesNotExist_reverts() (gas: 10649)
+LegacyERC20ETH_Test:test_transferFrom_doesNotExist_reverts() (gas: 12887)
+LegacyERC20ETH_Test:test_transfer_doesNotExist_reverts() (gas: 10733)
 LegacyMessagePasser_Test:test_LegacyMessagePasser_passMessageToL1_Succeeds() (gas: 34519)
-OptimismMintableERC20_Test:test_bridge() (gas: 7599)
-OptimismMintableERC20_Test:test_burn() (gas: 51031)
-OptimismMintableERC20_Test:test_burnRevertsFromNotBridge() (gas: 11164)
-OptimismMintableERC20_Test:test_erc165_supportsInterface() (gas: 7765)
-OptimismMintableERC20_Test:test_l1Token() (gas: 7622)
-OptimismMintableERC20_Test:test_l2Bridge() (gas: 7688)
-OptimismMintableERC20_Test:test_legacy() (gas: 14300)
-OptimismMintableERC20_Test:test_mint() (gas: 63609)
-OptimismMintableERC20_Test:test_mintRevertsFromNotBridge() (gas: 11098)
-OptimismMintableERC20_Test:test_remoteToken() (gas: 7644)
-OptimismMintableTokenFactory_Test:test_bridge() (gas: 7577)
-OptimismMintableTokenFactory_Test:test_createStandardL2Token() (gas: 1095274)
-OptimismMintableTokenFactory_Test:test_createStandardL2TokenSameTwice() (gas: 2176691)
-OptimismMintableTokenFactory_Test:test_createStandardL2TokenShouldRevertIfRemoteIsZero() (gas: 9413)
+OptimismMintableERC20_Test:test_bridge_succeeds() (gas: 7643)
+OptimismMintableERC20_Test:test_burn_notBridge_reverts() (gas: 11165)
+OptimismMintableERC20_Test:test_burn_succeeds() (gas: 51013)
+OptimismMintableERC20_Test:test_erc165_supportsInterface_succeeds() (gas: 7742)
+OptimismMintableERC20_Test:test_l1Token_succeeds() (gas: 7599)
+OptimismMintableERC20_Test:test_l2Bridge_succeeds() (gas: 7665)
+OptimismMintableERC20_Test:test_legacy_succeeds() (gas: 14344)
+OptimismMintableERC20_Test:test_mint_notBridge_reverts() (gas: 11121)
+OptimismMintableERC20_Test:test_mint_succeeds() (gas: 63609)
+OptimismMintableERC20_Test:test_remoteToken_succeeds() (gas: 7622)
+OptimismMintableTokenFactory_Test:test_bridge_succeeds() (gas: 7577)
+OptimismMintableTokenFactory_Test:test_createStandardL2Token_remoteIsZero_succeeds() (gas: 9413)
+OptimismMintableTokenFactory_Test:test_createStandardL2Token_sameTwice_succeeds() (gas: 2176713)
+OptimismMintableTokenFactory_Test:test_createStandardL2Token_succeeds() (gas: 1095296)
 OptimismPortalUpgradeable_Test:test_initialize_cannotInitImpl_reverts() (gas: 10791)
 OptimismPortalUpgradeable_Test:test_initialize_cannotInitProxy_reverts() (gas: 15833)
 OptimismPortalUpgradeable_Test:test_params_initValuesOnProxy_succeeds() (gas: 16011)

packages/contracts-bedrock/contracts/test/LegacyERC20ETH.t.sol

@@ -12,48 +12,48 @@ contract LegacyERC20ETH_Test is CommonTest {
         eth = new LegacyERC20ETH();
     }
 
-    function test_metadata() external {
+    function test_metadata_succeeds() external {
         assertEq(eth.name(), "Ether");
         assertEq(eth.symbol(), "ETH");
         assertEq(eth.decimals(), 18);
     }
 
-    function test_crossDomain() external {
+    function test_crossDomain_succeeds() external {
         assertEq(eth.l2Bridge(), Predeploys.L2_STANDARD_BRIDGE);
         assertEq(eth.l1Token(), address(0));
     }
 
-    function test_transfer() external {
+    function test_transfer_doesNotExist_reverts() external {
         vm.expectRevert("LegacyERC20ETH: transfer is disabled");
         eth.transfer(alice, 100);
     }
 
-    function test_approve() external {
+    function test_approve_doesNotExist_reverts() external {
         vm.expectRevert("LegacyERC20ETH: approve is disabled");
         eth.approve(alice, 100);
     }
 
-    function test_transferFrom() external {
+    function test_transferFrom_doesNotExist_reverts() external {
         vm.expectRevert("LegacyERC20ETH: transferFrom is disabled");
         eth.transferFrom(bob, alice, 100);
     }
 
-    function test_increaseAllowance() external {
+    function test_increaseAllowance_doesNotExist_reverts() external {
         vm.expectRevert("LegacyERC20ETH: increaseAllowance is disabled");
         eth.increaseAllowance(alice, 100);
     }
 
-    function test_decreaseAllowance() external {
+    function test_decreaseAllowance_doesNotExist_reverts() external {
         vm.expectRevert("LegacyERC20ETH: decreaseAllowance is disabled");
         eth.decreaseAllowance(alice, 100);
     }
 
-    function test_mint() external {
+    function test_mint_doesNotExist_reverts() external {
         vm.expectRevert("LegacyERC20ETH: mint is disabled");
         eth.mint(alice, 100);
     }
 
-    function test_burn() external {
+    function test_burn_doesNotExist_reverts() external {
         vm.expectRevert("LegacyERC20ETH: burn is disabled");
         eth.burn(alice, 100);
     }

packages/contracts-bedrock/contracts/test/OptimismMintableERC20.t.sol

@@ -13,23 +13,23 @@ contract OptimismMintableERC20_Test is Bridge_Initializer {
         super.setUp();
     }
 
-    function test_remoteToken() external {
+    function test_remoteToken_succeeds() external {
         assertEq(L2Token.remoteToken(), address(L1Token));
     }
 
-    function test_bridge() external {
+    function test_bridge_succeeds() external {
         assertEq(L2Token.bridge(), address(L2Bridge));
     }
 
-    function test_l1Token() external {
+    function test_l1Token_succeeds() external {
         assertEq(L2Token.l1Token(), address(L1Token));
     }
 
-    function test_l2Bridge() external {
+    function test_l2Bridge_succeeds() external {
         assertEq(L2Token.l2Bridge(), address(L2Bridge));
     }
 
-    function test_legacy() external {
+    function test_legacy_succeeds() external {
         // Getters for the remote token
         assertEq(L2Token.REMOTE_TOKEN(), address(L1Token));
         assertEq(L2Token.remoteToken(), address(L1Token));
@@ -40,7 +40,7 @@ contract OptimismMintableERC20_Test is Bridge_Initializer {
         assertEq(L2Token.l2Bridge(), address(L2Bridge));
     }
 
-    function test_mint() external {
+    function test_mint_succeeds() external {
         vm.expectEmit(true, true, true, true);
         emit Mint(alice, 100);
 
@@ -50,14 +50,14 @@ contract OptimismMintableERC20_Test is Bridge_Initializer {
         assertEq(L2Token.balanceOf(alice), 100);
     }
 
-    function test_mintRevertsFromNotBridge() external {
+    function test_mint_notBridge_reverts() external {
         // NOT the bridge
         vm.expectRevert("OptimismMintableERC20: only bridge can mint and burn");
         vm.prank(address(alice));
         L2Token.mint(alice, 100);
     }
 
-    function test_burn() external {
+    function test_burn_succeeds() external {
         vm.prank(address(L2Bridge));
         L2Token.mint(alice, 100);
 
@@ -70,14 +70,14 @@ contract OptimismMintableERC20_Test is Bridge_Initializer {
         assertEq(L2Token.balanceOf(alice), 0);
     }
 
-    function test_burnRevertsFromNotBridge() external {
+    function test_burn_notBridge_reverts() external {
         // NOT the bridge
         vm.expectRevert("OptimismMintableERC20: only bridge can mint and burn");
         vm.prank(address(alice));
         L2Token.burn(alice, 100);
     }
 
-    function test_erc165_supportsInterface() external {
+    function test_erc165_supportsInterface_succeeds() external {
         // The assertEq calls in this test are comparing the manual calculation of the iface,
         // with what is returned by the solidity's type().interfaceId, just to be safe.
         bytes4 iface1 = bytes4(keccak256("supportsInterface(bytes4)"));

packages/contracts-bedrock/contracts/test/OptimismMintableERC20Factory.t.sol

@@ -16,11 +16,11 @@ contract OptimismMintableTokenFactory_Test is Bridge_Initializer {
         super.setUp();
     }
 
-    function test_bridge() external {
+    function test_bridge_succeeds() external {
         assertEq(address(L2TokenFactory.bridge()), address(L2Bridge));
     }
 
-    function test_createStandardL2Token() external {
+    function test_createStandardL2Token_succeeds() external {
         address remote = address(4);
         address local = LibRLP.computeAddress(address(L2TokenFactory), 2);
 
@@ -34,7 +34,7 @@ contract OptimismMintableTokenFactory_Test is Bridge_Initializer {
         L2TokenFactory.createStandardL2Token(remote, "Beep", "BOOP");
     }
 
-    function test_createStandardL2TokenSameTwice() external {
+    function test_createStandardL2Token_sameTwice_succeeds() external {
         address remote = address(4);
 
         vm.prank(alice);
@@ -52,7 +52,7 @@ contract OptimismMintableTokenFactory_Test is Bridge_Initializer {
         L2TokenFactory.createStandardL2Token(remote, "Beep", "BOOP");
     }
 
-    function test_createStandardL2TokenShouldRevertIfRemoteIsZero() external {
+    function test_createStandardL2Token_remoteIsZero_succeeds() external {
         address remote = address(0);
         vm.expectRevert("OptimismMintableERC20Factory: must provide remote token address");
         L2TokenFactory.createStandardL2Token(remote, "Beep", "BOOP");