Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
N
nebula
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
exchain
nebula
Commits
d71d82c0
Unverified
Commit
d71d82c0
authored
Jan 31, 2024
by
refcell.eth
Committed by
GitHub
Jan 31, 2024
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix(op-challenger): preimage scheduler nits (#9277)
parent
3d99b857
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
5 additions
and
6 deletions
+5
-6
scheduler.go
op-challenger/game/keccak/scheduler.go
+5
-6
No files found.
op-challenger/game/keccak/scheduler.go
View file @
d71d82c0
...
@@ -2,6 +2,7 @@ package keccak
...
@@ -2,6 +2,7 @@ package keccak
import
(
import
(
"context"
"context"
"errors"
"sync"
"sync"
keccakTypes
"github.com/ethereum-optimism/optimism/op-challenger/game/keccak/types"
keccakTypes
"github.com/ethereum-optimism/optimism/op-challenger/game/keccak/types"
...
@@ -52,7 +53,7 @@ func (s *LargePreimageScheduler) run(ctx context.Context) {
...
@@ -52,7 +53,7 @@ func (s *LargePreimageScheduler) run(ctx context.Context) {
return
return
case
blockHash
:=
<-
s
.
ch
:
case
blockHash
:=
<-
s
.
ch
:
if
err
:=
s
.
verifyPreimages
(
ctx
,
blockHash
);
err
!=
nil
{
if
err
:=
s
.
verifyPreimages
(
ctx
,
blockHash
);
err
!=
nil
{
s
.
log
.
Error
(
"Failed to verify large preimages"
,
"err"
,
err
)
s
.
log
.
Error
(
"Failed to verify large preimages"
,
"
blockHash"
,
blockHash
,
"
err"
,
err
)
}
}
}
}
}
}
...
@@ -63,18 +64,16 @@ func (s *LargePreimageScheduler) Schedule(blockHash common.Hash, _ uint64) error
...
@@ -63,18 +64,16 @@ func (s *LargePreimageScheduler) Schedule(blockHash common.Hash, _ uint64) error
case
s
.
ch
<-
blockHash
:
case
s
.
ch
<-
blockHash
:
default
:
default
:
s
.
log
.
Trace
(
"Skipping preimage check while already processing"
)
s
.
log
.
Trace
(
"Skipping preimage check while already processing"
)
// Already busy processing, skip this update
}
}
return
nil
return
nil
}
}
func
(
s
*
LargePreimageScheduler
)
verifyPreimages
(
ctx
context
.
Context
,
blockHash
common
.
Hash
)
error
{
func
(
s
*
LargePreimageScheduler
)
verifyPreimages
(
ctx
context
.
Context
,
blockHash
common
.
Hash
)
error
{
var
err
error
for
_
,
oracle
:=
range
s
.
oracles
{
for
_
,
oracle
:=
range
s
.
oracles
{
if
err
:=
s
.
verifyOraclePreimages
(
ctx
,
oracle
,
blockHash
);
err
!=
nil
{
err
=
errors
.
Join
(
err
,
s
.
verifyOraclePreimages
(
ctx
,
oracle
,
blockHash
))
s
.
log
.
Error
(
"Failed to verify preimages in oracle %v: %w"
,
oracle
.
Addr
(),
err
)
}
}
}
return
err
return
nil
}
}
func
(
s
*
LargePreimageScheduler
)
verifyOraclePreimages
(
ctx
context
.
Context
,
oracle
keccakTypes
.
LargePreimageOracle
,
blockHash
common
.
Hash
)
error
{
func
(
s
*
LargePreimageScheduler
)
verifyOraclePreimages
(
ctx
context
.
Context
,
oracle
keccakTypes
.
LargePreimageOracle
,
blockHash
common
.
Hash
)
error
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment