Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
N
nebula
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
exchain
nebula
Commits
d80c145e
Unverified
Commit
d80c145e
authored
Jul 02, 2023
by
OptimismBot
Committed by
GitHub
Jul 02, 2023
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #6164 from pengin7384/resettable_typo
fix: typo
parents
b7fd37ee
c1103906
Changes
6
Show whitespace changes
Inline
Side-by-side
Showing
6 changed files
with
17 additions
and
7 deletions
+17
-7
little-scissors-own.md
.changeset/little-scissors-own.md
+10
-0
channel_bank.go
op-node/rollup/derive/channel_bank.go
+1
-1
channel_in_reader.go
op-node/rollup/derive/channel_in_reader.go
+1
-1
l1_retrieval.go
op-node/rollup/derive/l1_retrieval.go
+1
-1
l1_traversal.go
op-node/rollup/derive/l1_traversal.go
+1
-1
pipeline.go
op-node/rollup/derive/pipeline.go
+3
-3
No files found.
.changeset/little-scissors-own.md
0 → 100644
View file @
d80c145e
---
'
@eth-optimism/contracts-periphery'
:
patch
'
@eth-optimism/contracts-bedrock'
:
patch
'
@eth-optimism/fault-detector'
:
patch
'
@eth-optimism/core-utils'
:
patch
'
@eth-optimism/endpoint-monitor'
:
patch
'
@eth-optimism/sdk'
:
patch
---
fix typo
op-node/rollup/derive/channel_bank.go
View file @
d80c145e
...
@@ -39,7 +39,7 @@ type ChannelBank struct {
...
@@ -39,7 +39,7 @@ type ChannelBank struct {
fetcher
L1Fetcher
fetcher
L1Fetcher
}
}
var
_
ResetableStage
=
(
*
ChannelBank
)(
nil
)
var
_
Reset
t
ableStage
=
(
*
ChannelBank
)(
nil
)
// NewChannelBank creates a ChannelBank, which should be Reset(origin) before use.
// NewChannelBank creates a ChannelBank, which should be Reset(origin) before use.
func
NewChannelBank
(
log
log
.
Logger
,
cfg
*
rollup
.
Config
,
prev
NextFrameProvider
,
fetcher
L1Fetcher
)
*
ChannelBank
{
func
NewChannelBank
(
log
log
.
Logger
,
cfg
*
rollup
.
Config
,
prev
NextFrameProvider
,
fetcher
L1Fetcher
)
*
ChannelBank
{
...
...
op-node/rollup/derive/channel_in_reader.go
View file @
d80c145e
...
@@ -24,7 +24,7 @@ type ChannelInReader struct {
...
@@ -24,7 +24,7 @@ type ChannelInReader struct {
metrics
Metrics
metrics
Metrics
}
}
var
_
ResetableStage
=
(
*
ChannelInReader
)(
nil
)
var
_
Reset
t
ableStage
=
(
*
ChannelInReader
)(
nil
)
// NewChannelInReader creates a ChannelInReader, which should be Reset(origin) before use.
// NewChannelInReader creates a ChannelInReader, which should be Reset(origin) before use.
func
NewChannelInReader
(
log
log
.
Logger
,
prev
*
ChannelBank
,
metrics
Metrics
)
*
ChannelInReader
{
func
NewChannelInReader
(
log
log
.
Logger
,
prev
*
ChannelBank
,
metrics
Metrics
)
*
ChannelInReader
{
...
...
op-node/rollup/derive/l1_retrieval.go
View file @
d80c145e
...
@@ -28,7 +28,7 @@ type L1Retrieval struct {
...
@@ -28,7 +28,7 @@ type L1Retrieval struct {
datas
DataIter
datas
DataIter
}
}
var
_
ResetableStage
=
(
*
L1Retrieval
)(
nil
)
var
_
Reset
t
ableStage
=
(
*
L1Retrieval
)(
nil
)
func
NewL1Retrieval
(
log
log
.
Logger
,
dataSrc
DataAvailabilitySource
,
prev
NextBlockProvider
)
*
L1Retrieval
{
func
NewL1Retrieval
(
log
log
.
Logger
,
dataSrc
DataAvailabilitySource
,
prev
NextBlockProvider
)
*
L1Retrieval
{
return
&
L1Retrieval
{
return
&
L1Retrieval
{
...
...
op-node/rollup/derive/l1_traversal.go
View file @
d80c145e
...
@@ -31,7 +31,7 @@ type L1Traversal struct {
...
@@ -31,7 +31,7 @@ type L1Traversal struct {
cfg
*
rollup
.
Config
cfg
*
rollup
.
Config
}
}
var
_
ResetableStage
=
(
*
L1Traversal
)(
nil
)
var
_
Reset
t
ableStage
=
(
*
L1Traversal
)(
nil
)
func
NewL1Traversal
(
log
log
.
Logger
,
cfg
*
rollup
.
Config
,
l1Blocks
L1BlockRefByNumberFetcher
)
*
L1Traversal
{
func
NewL1Traversal
(
log
log
.
Logger
,
cfg
*
rollup
.
Config
,
l1Blocks
L1BlockRefByNumberFetcher
)
*
L1Traversal
{
return
&
L1Traversal
{
return
&
L1Traversal
{
...
...
op-node/rollup/derive/pipeline.go
View file @
d80c145e
...
@@ -34,7 +34,7 @@ type ResettableEngineControl interface {
...
@@ -34,7 +34,7 @@ type ResettableEngineControl interface {
Reset
()
Reset
()
}
}
type
ResetableStage
interface
{
type
Reset
t
ableStage
interface
{
// Reset resets a pull stage. `base` refers to the L1 Block Reference to reset to, with corresponding configuration.
// Reset resets a pull stage. `base` refers to the L1 Block Reference to reset to, with corresponding configuration.
Reset
(
ctx
context
.
Context
,
base
eth
.
L1BlockRef
,
baseCfg
eth
.
SystemConfig
)
error
Reset
(
ctx
context
.
Context
,
base
eth
.
L1BlockRef
,
baseCfg
eth
.
SystemConfig
)
error
}
}
...
@@ -65,7 +65,7 @@ type DerivationPipeline struct {
...
@@ -65,7 +65,7 @@ type DerivationPipeline struct {
// Index of the stage that is currently being reset.
// Index of the stage that is currently being reset.
// >= len(stages) if no additional resetting is required
// >= len(stages) if no additional resetting is required
resetting
int
resetting
int
stages
[]
ResetableStage
stages
[]
Reset
t
ableStage
// Special stages to keep track of
// Special stages to keep track of
traversal
*
L1Traversal
traversal
*
L1Traversal
...
@@ -94,7 +94,7 @@ func NewDerivationPipeline(log log.Logger, cfg *rollup.Config, l1Fetcher L1Fetch
...
@@ -94,7 +94,7 @@ func NewDerivationPipeline(log log.Logger, cfg *rollup.Config, l1Fetcher L1Fetch
// Reset from engine queue then up from L1 Traversal. The stages do not talk to each other during
// Reset from engine queue then up from L1 Traversal. The stages do not talk to each other during
// the reset, but after the engine queue, this is the order in which the stages could talk to each other.
// the reset, but after the engine queue, this is the order in which the stages could talk to each other.
// Note: The engine queue stage is the only reset that can fail.
// Note: The engine queue stage is the only reset that can fail.
stages
:=
[]
ResetableStage
{
eng
,
l1Traversal
,
l1Src
,
frameQueue
,
bank
,
chInReader
,
batchQueue
,
attributesQueue
}
stages
:=
[]
Reset
t
ableStage
{
eng
,
l1Traversal
,
l1Src
,
frameQueue
,
bank
,
chInReader
,
batchQueue
,
attributesQueue
}
return
&
DerivationPipeline
{
return
&
DerivationPipeline
{
log
:
log
,
log
:
log
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment