Commit e2e4fa41 authored by Maurelian's avatar Maurelian

contracts: Fix OZ-N-05 Misleading or unclear comments

Also fixes OZ-N-06 which was a single typo.
parent 5385d3f3
...@@ -73,6 +73,7 @@ contract L2OutputOracle is Ownable { ...@@ -73,6 +73,7 @@ contract L2OutputOracle is Ownable {
* @param _historicalTotalBlocks The number of blocks that preceding the * @param _historicalTotalBlocks The number of blocks that preceding the
* initialization of the L2 chain. * initialization of the L2 chain.
* @param _startingBlockTimestamp The timestamp to start L2 block at. * @param _startingBlockTimestamp The timestamp to start L2 block at.
* @param sequencer The address of the sequencer.
*/ */
constructor( constructor(
uint256 _submissionInterval, uint256 _submissionInterval,
......
...@@ -94,7 +94,8 @@ contract OptimismPortal is ResourceMetering { ...@@ -94,7 +94,8 @@ contract OptimismPortal is ResourceMetering {
/** /**
* @notice Accepts value so that users can send ETH directly to this contract and have the * @notice Accepts value so that users can send ETH directly to this contract and have the
* funds be deposited to their address on L2. This is intended as a convenience * funds be deposited to their address on L2. This is intended as a convenience
* function for EOAs. Contracts should call the depositTransaction() function directly. * function for EOAs. Contracts should call the depositTransaction() function directly
* otherwise any deposited funds will be lost due to address aliasing.
*/ */
receive() external payable { receive() external payable {
depositTransaction(msg.sender, msg.value, RECEIVE_DEFAULT_GAS_LIMIT, false, bytes("")); depositTransaction(msg.sender, msg.value, RECEIVE_DEFAULT_GAS_LIMIT, false, bytes(""));
......
...@@ -41,6 +41,7 @@ contract OptimismMintableTokenFactory { ...@@ -41,6 +41,7 @@ contract OptimismMintableTokenFactory {
* @param _remoteToken Address of the corresponding L1 token. * @param _remoteToken Address of the corresponding L1 token.
* @param _name ERC20 name. * @param _name ERC20 name.
* @param _symbol ERC20 symbol. * @param _symbol ERC20 symbol.
* @return Address of the new token.
*/ */
function createStandardL2Token( function createStandardL2Token(
address _remoteToken, address _remoteToken,
......
...@@ -217,7 +217,7 @@ abstract contract StandardBridge { ...@@ -217,7 +217,7 @@ abstract contract StandardBridge {
emit ETHBridgeFinalized(_from, _to, _amount, _data); emit ETHBridgeFinalized(_from, _to, _amount, _data);
(bool success, ) = _to.call{ value: _amount }(new bytes(0)); (bool success, ) = _to.call{ value: _amount }(new bytes(0));
require(success, "TransferHelper::safeTransferETH: ETH transfer failed"); require(success, "ETH transfer failed.");
} }
/** /**
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment