maintenance[contracts]: use dashes in chain container names (#819)

* maintenance: use dashes in chain container names

* chore: add changeset

.changeset/eight-bobcats-turn.md

+---
+'@eth-optimism/batch-submitter': patch
+'@eth-optimism/contracts': patch
+---
+
+Use dashes instead of colons in contract names

packages/batch-submitter/src/batch-submitter/tx-batch-submitter.ts

@@ -619,7 +619,7 @@ export class TransactionBatchSubmitter extends BatchSubmitter {
     )
 
     const addr = await manager.getAddress(
-      'OVM_ChainStorageContainer:CTC:batches'
+      'OVM_ChainStorageContainer-CTC-batches'
     )
     const container = new Contract(
       addr,

packages/contracts/contracts/optimistic-ethereum/OVM/chain/OVM_CanonicalTransactionChain.sol

@@ -94,7 +94,7 @@ contract OVM_CanonicalTransactionChain is iOVM_CanonicalTransactionChain, Lib_Ad
         )
     {
         return iOVM_ChainStorageContainer(
-            resolve("OVM_ChainStorageContainer:CTC:batches")
+            resolve("OVM_ChainStorageContainer-CTC-batches")
         );
     }
 
@@ -111,7 +111,7 @@ contract OVM_CanonicalTransactionChain is iOVM_CanonicalTransactionChain, Lib_Ad
         )
     {
         return iOVM_ChainStorageContainer(
-            resolve("OVM_ChainStorageContainer:CTC:queue")
+            resolve("OVM_ChainStorageContainer-CTC-queue")
         );
     }
 

packages/contracts/contracts/optimistic-ethereum/OVM/chain/OVM_StateCommitmentChain.sol

@@ -72,7 +72,7 @@ contract OVM_StateCommitmentChain is iOVM_StateCommitmentChain, Lib_AddressResol
         )
     {
         return iOVM_ChainStorageContainer(
-            resolve("OVM_ChainStorageContainer:SCC:batches")
+            resolve("OVM_ChainStorageContainer-SCC-batches")
         );
     }
 

packages/contracts/deploy/001-OVM_ChainStorageContainer_ctc_batches.deploy.ts

@@ -15,7 +15,7 @@ const deployFn: DeployFunction = async (hre) => {
 
   await deployAndRegister({
     hre,
-    name: 'OVM_ChainStorageContainer:CTC:batches',
+    name: 'OVM_ChainStorageContainer-CTC-batches',
     contract: 'OVM_ChainStorageContainer',
     args: [Lib_AddressManager.address, 'OVM_CanonicalTransactionChain'],
   })

packages/contracts/deploy/002-OVM_ChainStorageContainer_ctc_queue.deploy.ts

@@ -15,7 +15,7 @@ const deployFn: DeployFunction = async (hre) => {
 
   await deployAndRegister({
     hre,
-    name: 'OVM_ChainStorageContainer:CTC:queue',
+    name: 'OVM_ChainStorageContainer-CTC-queue',
     contract: 'OVM_ChainStorageContainer',
     args: [Lib_AddressManager.address, 'OVM_CanonicalTransactionChain'],
   })

packages/contracts/deploy/003-OVM_ChainStorageContainer_scc_batches.deploy.ts

@@ -15,7 +15,7 @@ const deployFn: DeployFunction = async (hre) => {
 
   await deployAndRegister({
     hre,
-    name: 'OVM_ChainStorageContainer:SCC:batches',
+    name: 'OVM_ChainStorageContainer-SCC-batches',
     contract: 'OVM_ChainStorageContainer',
     args: [Lib_AddressManager.address, 'OVM_StateCommitmentChain'],
   })

packages/contracts/src/contract-deployment/config.ts

@@ -233,15 +233,15 @@ export const makeContractDeployConfig = async (
         '0x0000000000000000000000000000000000000000', // will be overridden by geth when state dump is ingested.  Storage key: 0x0000000000000000000000000000000000000000000000000000000000000008
       ],
     },
-    'OVM_ChainStorageContainer:CTC:batches': {
+    'OVM_ChainStorageContainer-CTC-batches': {
       factory: getContractFactory('OVM_ChainStorageContainer'),
       params: [AddressManager.address, 'OVM_CanonicalTransactionChain'],
     },
-    'OVM_ChainStorageContainer:CTC:queue': {
+    'OVM_ChainStorageContainer-CTC-queue': {
       factory: getContractFactory('OVM_ChainStorageContainer'),
       params: [AddressManager.address, 'OVM_CanonicalTransactionChain'],
     },
-    'OVM_ChainStorageContainer:SCC:batches': {
+    'OVM_ChainStorageContainer-SCC-batches': {
       factory: getContractFactory('OVM_ChainStorageContainer'),
       params: [AddressManager.address, 'OVM_StateCommitmentChain'],
     },

packages/contracts/test/contracts/OVM/chain/OVM_CanonicalTransactionChain.gas.spec.ts

@@ -114,12 +114,12 @@ describe('[GAS BENCHMARK] OVM_CanonicalTransactionChain', () => {
     )
 
     await AddressManager.setAddress(
-      'OVM_ChainStorageContainer:CTC:batches',
+      'OVM_ChainStorageContainer-CTC-batches',
       batches.address
     )
 
     await AddressManager.setAddress(
-      'OVM_ChainStorageContainer:CTC:queue',
+      'OVM_ChainStorageContainer-CTC-queue',
       queue.address
     )
 

packages/contracts/test/contracts/OVM/chain/OVM_CanonicalTransactionChain.spec.ts

@@ -164,12 +164,12 @@ describe('OVM_CanonicalTransactionChain', () => {
     )
 
     await AddressManager.setAddress(
-      'OVM_ChainStorageContainer:CTC:batches',
+      'OVM_ChainStorageContainer-CTC-batches',
       batches.address
     )
 
     await AddressManager.setAddress(
-      'OVM_ChainStorageContainer:CTC:queue',
+      'OVM_ChainStorageContainer-CTC-queue',
       queue.address
     )
 

packages/contracts/test/contracts/OVM/chain/OVM_StateCommitmentChain.spec.ts

@@ -83,7 +83,7 @@ describe('OVM_StateCommitmentChain', () => {
     )
 
     await AddressManager.setAddress(
-      'OVM_ChainStorageContainer:SCC:batches',
+      'OVM_ChainStorageContainer-SCC-batches',
       batches.address
     )