fix: logging error messages and stack (#843)

* batch-submitter: log error explicitly

* data-transport-layer: log error explicitly

* message-relayer: log error explicitly

* chore: add changeset

.changeset/short-ducks-type.md

+---
+'@eth-optimism/batch-submitter': patch
+'@eth-optimism/data-transport-layer': patch
+'@eth-optimism/message-relayer': patch
+---
+
+Explicitly log error messages so that they do not show as empty objects

packages/batch-submitter/src/exec/run-batch-submitter.ts

@@ -286,7 +286,11 @@ export const run = async () => {
           }
         }
       } catch (err) {
-        logger.error('Cannot clear transactions', { err })
+        logger.error('Cannot clear transactions', {
+          message: err.toString(),
+          stack: err.stack,
+          code: err.code,
+        })
         process.exit(1)
       }
     }
@@ -295,7 +299,11 @@ export const run = async () => {
       try {
         await func()
       } catch (err) {
-        logger.error('Error submitting batch', { err })
+        logger.error('Error submitting batch', {
+          message: err.toString(),
+          stack: err.stack,
+          code: err.code,
+        })
         logger.info('Retrying...')
       }
       // Sleep

packages/data-transport-layer/src/services/l2-ingestion/service.ts

@@ -115,10 +115,13 @@ export class L2IngestionService extends BaseService<L2IngestionServiceOptions> {
         }
       } catch (err) {
         if (!this.running || this.options.dangerouslyCatchAllErrors) {
-          this.logger.error('Caught an unhandled error', { err })
+          this.logger.error('Caught an unhandled error', {
+            message: err.toString(),
+            stack: err.stack,
+            code: err.code,
+          })
           await sleep(this.options.pollingInterval)
         } else {
-          // TODO: Is this the best thing to do here?
           throw err
         }
       }

packages/message-relayer/src/service.ts

@@ -243,7 +243,11 @@ export class MessageRelayerService extends BaseService<MessageRelayerOptions> {
           }
         )
       } catch (err) {
-        this.logger.error('Caught an unhandled error', { err })
+        this.logger.error('Caught an unhandled error', {
+          message: err.toString(),
+          stack: err.stack,
+          code: err.code,
+        })
       }
     }
   }
@@ -490,7 +494,11 @@ export class MessageRelayerService extends BaseService<MessageRelayerOptions> {
           'Proof should succeed. Submitting for real this time...'
         )
       } catch (err) {
-        this.logger.error('Proof would fail, skipping', { err })
+        this.logger.error('Proof would fail, skipping', {
+          message: err.toString(),
+          stack: err.stack,
+          code: err.code,
+        })
         return
       }
 
@@ -522,7 +530,11 @@ export class MessageRelayerService extends BaseService<MessageRelayerOptions> {
           status: receipt.status,
         })
       } catch (err) {
-        this.logger.error('Real relay attempt failed, skipping.', { err })
+        this.logger.error('Real relay attempt failed, skipping.', {
+          message: err.toString(),
+          stack: err.stack,
+          code: err.code,
+        })
         return
       }
       this.logger.info('Message successfully relayed to Layer 1!')