fix: avoid running BestV3Trade when tokens are the same (#2172)

* avoid running BestV3Trade when tokens are the same * flipped condition

fix: avoid running BestV3Trade when tokens are the same (#2172)
* avoid running BestV3Trade when tokens are the same * flipped condition
a48b7ce7 · Justin Domingue · GitHub · fc08d1fc · a48b7ce7
Commit a48b7ce7 authored Aug 09, 2021 by Justin Domingue Committed by GitHub Aug 09, 2021
Show whitespace changes
Inline Side-by-side

Showing with 13 additions and 2 deletions

useBestV3Trade.ts src/hooks/useBestV3Trade.ts +13 -2

No files found.
--- a/src/hooks/useBestV3Trade.ts
+++ b/src/hooks/useBestV3Trade.ts
@@ -48,7 +48,12 @@ export function useBestV3TradeExactIn(
  })

  return useMemo(() => {
-    if (!amountIn || !currencyOut) {
+    if (
+      !amountIn ||
+      !currencyOut ||
+      // skip when tokens are the same
+      amountIn.currency.equals(currencyOut)
+    ) {
      return {
        state: V3TradeState.INVALID,
        trade: null,
@@ -132,7 +137,13 @@ export function useBestV3TradeExactOut(
  })

  return useMemo(() => {
-    if (!amountOut || !currencyIn || quotesResults.some(({ valid }) => !valid)) {
+    if (
+      !amountOut ||
+      !currencyIn ||
+      quotesResults.some(({ valid }) => !valid) ||
+      // skip when tokens are the same
+      amountOut.currency.equals(currencyIn)
+    ) {
      return {
        state: V3TradeState.INVALID,
        trade: null,