Commit 9413fbf1 authored by guillaume.bouvignies's avatar guillaume.bouvignies

Address PR comments

parent 918e08ae
...@@ -40,12 +40,7 @@ Kurtosis will create a new enclave to house the services of the Ethereum network ...@@ -40,12 +40,7 @@ Kurtosis will create a new enclave to house the services of the Ethereum network
Configuration Configuration
------------- -------------
To configure the package behaviour, you can modify your `eth2-package-params.yaml` file. The full YAML schema that can be passed in is as follows with the defaults ([from here](https://github.com/kurtosis-tech/eth2-package/blob/master/types.proto) provided: To configure the package behaviour, you can modify your `eth2-package-params.yaml` file. The full YAML schema that can be passed in is as follows with the defaults provided:
Note: Following an update starting the network post-merge, `erigon`, `nimbus` and `prysm` clients don't work anymore. Fixes are tracked in the following Github issues:
- Prysm: [#11508][prysm-issue]
- Nimbus: [#4193][nimbus-issue]
- Erigon: [#154][erigon-issue]
<details> <details>
<summary>Click to show all configuration options</summary> <summary>Click to show all configuration options</summary>
...@@ -170,6 +165,11 @@ Note: Following an update starting the network post-merge, `erigon`, `nimbus` an ...@@ -170,6 +165,11 @@ Note: Following an update starting the network post-merge, `erigon`, `nimbus` an
``` ```
</details> </details>
Note: Following an update starting the network post-merge, `erigon`, `nimbus` and `prysm` clients don't work anymore. Fixes are tracked in the following Github issues:
- Prysm: [#11508][prysm-issue]
- Nimbus: [#4193][nimbus-issue]
- Erigon: [#154][erigon-issue]
You can find the latest Kiln compatible docker images here: https://notes.ethereum.org/@launchpad/kiln You can find the latest Kiln compatible docker images here: https://notes.ethereum.org/@launchpad/kiln
Developing On This Package Developing On This Package
......
...@@ -3,6 +3,7 @@ ...@@ -3,6 +3,7 @@
### Changes ### Changes
- Replaced 'module' with 'package' where relevant - Replaced 'module' with 'package' where relevant
- Removed protobuf types as they are now unsupported in Kurtosis. - Removed protobuf types as they are now unsupported in Kurtosis.
- Renamed `kurtotis.mod` to `kurtosis.yml`
### Fixes ### Fixes
- Fixed a bug in `run` of `main.star` where we'd refer to `module_io` instead of `package_io` - Fixed a bug in `run` of `main.star` where we'd refer to `module_io` instead of `package_io`
......
...@@ -19,7 +19,6 @@ HTTP_PORT_ID_FOR_FACT = "http" ...@@ -19,7 +19,6 @@ HTTP_PORT_ID_FOR_FACT = "http"
def run(input_args): def run(input_args):
input_args_with_right_defaults = parse_input.parse_input(input_args) input_args_with_right_defaults = parse_input.parse_input(input_args)
print(input_args_with_right_defaults)
num_participants = len(input_args_with_right_defaults.participants) num_participants = len(input_args_with_right_defaults.participants)
network_params = input_args_with_right_defaults.network_params network_params = input_args_with_right_defaults.network_params
......
...@@ -19,7 +19,7 @@ NETHERMIND_NODE_NAME = "nethermind" ...@@ -19,7 +19,7 @@ NETHERMIND_NODE_NAME = "nethermind"
ATTR_TO_BE_SKIPPED_AT_ROOT = ("network_params", "participants") ATTR_TO_BE_SKIPPED_AT_ROOT = ("network_params", "participants")
def parse_input(input_args): def parse_input(input_args):
result = default_module_input() result = default_input_args()
for attr in dir(input_args): for attr in dir(input_args):
value = getattr(input_args, attr) value = getattr(input_args, attr)
# if its insterted we use the value inserted # if its insterted we use the value inserted
...@@ -131,7 +131,7 @@ def get_client_log_level_or_default(participant_log_level, global_log_level, cli ...@@ -131,7 +131,7 @@ def get_client_log_level_or_default(participant_log_level, global_log_level, cli
fail("No participant log level defined, and the client log level has no mapping for global log level '{0}'".format(global_log_level)) fail("No participant log level defined, and the client log level has no mapping for global log level '{0}'".format(global_log_level))
return log_level return log_level
def default_module_input(): def default_input_args():
network_params = default_network_params() network_params = default_network_params()
participants = [default_participant()] participants = [default_participant()]
return { return {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment