Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
F
frontend
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
vicotor
frontend
Commits
8d48fe74
Commit
8d48fe74
authored
Apr 18, 2025
by
tom
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix the delay behavior of tooltips
parent
55e0f223
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
44 additions
and
11 deletions
+44
-11
tooltip.tsx
toolkit/chakra/tooltip.tsx
+43
-8
GasInfoTooltip.tsx
ui/shared/gas/GasInfoTooltip.tsx
+0
-2
Tooltip.tsx
ui/showcases/Tooltip.tsx
+1
-1
No files found.
toolkit/chakra/tooltip.tsx
View file @
8d48fe74
...
@@ -35,14 +35,30 @@ export const Tooltip = React.forwardRef<HTMLDivElement, TooltipProps>(
...
@@ -35,14 +35,30 @@ export const Tooltip = React.forwardRef<HTMLDivElement, TooltipProps>(
lazyMount
=
true
,
lazyMount
=
true
,
unmountOnExit
=
true
,
unmountOnExit
=
true
,
triggerProps
,
triggerProps
,
closeDelay
,
closeDelay
=
100
,
openDelay
=
100
,
interactive
,
...
rest
...
rest
}
=
props
;
}
=
props
;
const
[
open
,
setOpen
]
=
React
.
useState
<
boolean
>
(
defaultOpen
);
const
[
open
,
setOpen
]
=
React
.
useState
<
boolean
>
(
defaultOpen
);
const
timeoutRef
=
React
.
useRef
<
number
|
null
>
(
null
);
const
isMobile
=
useIsMobile
();
const
isMobile
=
useIsMobile
();
const
triggerRef
=
useClickAway
<
HTMLButtonElement
>
(()
=>
setOpen
(
false
));
const
handleClickAway
=
React
.
useCallback
((
event
:
Event
)
=>
{
if
(
interactive
)
{
const
closest
=
(
event
.
target
as
HTMLElement
)?.
closest
(
'
.chakra-tooltip__positioner
'
);
if
(
closest
)
{
return
;
}
}
timeoutRef
.
current
=
window
.
setTimeout
(()
=>
{
setOpen
(
false
);
},
closeDelay
);
},
[
closeDelay
,
interactive
]);
const
triggerRef
=
useClickAway
<
HTMLButtonElement
>
(
handleClickAway
);
const
handleOpenChange
=
React
.
useCallback
((
details
:
{
open
:
boolean
})
=>
{
const
handleOpenChange
=
React
.
useCallback
((
details
:
{
open
:
boolean
})
=>
{
setOpen
(
details
.
open
);
setOpen
(
details
.
open
);
...
@@ -50,8 +66,25 @@ export const Tooltip = React.forwardRef<HTMLDivElement, TooltipProps>(
...
@@ -50,8 +66,25 @@ export const Tooltip = React.forwardRef<HTMLDivElement, TooltipProps>(
},
[
onOpenChange
]);
},
[
onOpenChange
]);
const
handleTriggerClick
=
React
.
useCallback
(()
=>
{
const
handleTriggerClick
=
React
.
useCallback
(()
=>
{
if
(
timeoutRef
.
current
)
{
window
.
clearTimeout
(
timeoutRef
.
current
);
}
timeoutRef
.
current
=
window
.
setTimeout
(()
=>
{
setOpen
((
prev
)
=>
!
prev
);
setOpen
((
prev
)
=>
!
prev
);
},
[
]);
},
open
?
closeDelay
:
openDelay
);
},
[
open
,
openDelay
,
closeDelay
]);
const
handleContentClick
=
React
.
useCallback
((
event
:
React
.
MouseEvent
<
HTMLDivElement
>
)
=>
{
event
.
stopPropagation
();
},
[]);
React
.
useEffect
(()
=>
{
return
()
=>
{
if
(
timeoutRef
.
current
)
{
clearTimeout
(
timeoutRef
.
current
);
}
};
},
[]);
if
(
disabled
||
(
disableOnMobile
&&
isMobile
))
return
children
;
if
(
disabled
||
(
disableOnMobile
&&
isMobile
))
return
children
;
...
@@ -69,22 +102,23 @@ export const Tooltip = React.forwardRef<HTMLDivElement, TooltipProps>(
...
@@ -69,22 +102,23 @@ export const Tooltip = React.forwardRef<HTMLDivElement, TooltipProps>(
return
(
return
(
<
ChakraTooltip
.
Root
<
ChakraTooltip
.
Root
openDelay=
{
100
}
openDelay=
{
openDelay
}
// FIXME: chakra closes tooltip too fast, so Playwright is not able to make a screenshot of its content
// FIXME: chakra closes tooltip too fast, so Playwright is not able to make a screenshot of its content
// so we need to increase the close delay in Playwright environment
// so we need to increase the close delay in Playwright environment
closeDelay=
{
config
.
app
.
isPw
?
10
_000
:
closeDelay
??
100
}
closeDelay=
{
config
.
app
.
isPw
?
10
_000
:
closeDelay
}
open=
{
open
}
open=
{
open
}
onOpenChange=
{
handleOpenChange
}
onOpenChange=
{
handleOpenChange
}
closeOnClick=
{
false
}
closeOnClick=
{
false
}
closeOnPointerDown=
{
tru
e
}
closeOnPointerDown=
{
fals
e
}
variant=
{
variant
}
variant=
{
variant
}
lazyMount=
{
lazyMount
}
lazyMount=
{
lazyMount
}
unmountOnExit=
{
unmountOnExit
}
unmountOnExit=
{
unmountOnExit
}
interactive=
{
interactive
}
{
...
rest
}
{
...
rest
}
positioning=
{
positioning
}
positioning=
{
positioning
}
>
>
<
ChakraTooltip
.
Trigger
<
ChakraTooltip
.
Trigger
ref=
{
triggerRef
}
ref=
{
open
?
triggerRef
:
null
}
asChild
asChild
onClick=
{
isMobile
?
handleTriggerClick
:
undefined
}
onClick=
{
isMobile
?
handleTriggerClick
:
undefined
}
{
...
triggerProps
}
{
...
triggerProps
}
...
@@ -95,6 +129,7 @@ export const Tooltip = React.forwardRef<HTMLDivElement, TooltipProps>(
...
@@ -95,6 +129,7 @@ export const Tooltip = React.forwardRef<HTMLDivElement, TooltipProps>(
<
ChakraTooltip
.
Positioner
>
<
ChakraTooltip
.
Positioner
>
<
ChakraTooltip
.
Content
<
ChakraTooltip
.
Content
ref=
{
ref
}
ref=
{
ref
}
onClick=
{
interactive
?
handleContentClick
:
undefined
}
{
...
(
selected
?
{
'
data
-
selected
':
true
}
:
{})
}
{
...
(
selected
?
{
'
data
-
selected
':
true
}
:
{})
}
{
...
contentProps
}
{
...
contentProps
}
>
>
...
...
ui/shared/gas/GasInfoTooltip.tsx
View file @
8d48fe74
...
@@ -11,7 +11,6 @@ import type { ExcludeUndefined } from 'types/utils';
...
@@ -11,7 +11,6 @@ import type { ExcludeUndefined } from 'types/utils';
import
{
route
}
from
'
nextjs-routes
'
;
import
{
route
}
from
'
nextjs-routes
'
;
import
config
from
'
configs/app
'
;
import
config
from
'
configs/app
'
;
import
{
SECOND
}
from
'
lib/consts
'
;
import
dayjs
from
'
lib/date/dayjs
'
;
import
dayjs
from
'
lib/date/dayjs
'
;
import
{
Link
}
from
'
toolkit/chakra/link
'
;
import
{
Link
}
from
'
toolkit/chakra/link
'
;
import
type
{
TooltipProps
}
from
'
toolkit/chakra/tooltip
'
;
import
type
{
TooltipProps
}
from
'
toolkit/chakra/tooltip
'
;
...
@@ -71,7 +70,6 @@ const GasInfoTooltip = ({ children, data, dataUpdatedAt, placement }: Props) =>
...
@@ -71,7 +70,6 @@ const GasInfoTooltip = ({ children, data, dataUpdatedAt, placement }: Props) =>
interactive
interactive
showArrow=
{
false
}
showArrow=
{
false
}
contentProps=
{
{
p
:
4
,
borderRadius
:
'
md
'
}
}
contentProps=
{
{
p
:
4
,
borderRadius
:
'
md
'
}
}
closeDelay=
{
SECOND
}
>
>
{
children
}
{
children
}
</
Tooltip
>
</
Tooltip
>
...
...
ui/showcases/Tooltip.tsx
View file @
8d48fe74
...
@@ -15,7 +15,7 @@ const TooltipShowcase = () => {
...
@@ -15,7 +15,7 @@ const TooltipShowcase = () => {
<
Tooltip
content=
"Tooltip content"
>
<
Tooltip
content=
"Tooltip content"
>
<
span
>
Default
</
span
>
<
span
>
Default
</
span
>
</
Tooltip
>
</
Tooltip
>
<
Tooltip
content=
"Tooltip content"
>
<
Tooltip
content=
"Tooltip content"
interactive
>
<
Utilization
value=
{
0.5
}
/>
<
Utilization
value=
{
0.5
}
/>
</
Tooltip
>
</
Tooltip
>
</
Sample
>
</
Sample
>
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment