use testInfo helper function in handshake tests

pkg/p2p/libp2p/internal/handshake/handshake.go

@@ -97,8 +97,3 @@ type Info struct {
 	NetworkID int32
 	Light     bool
 }
-
-// Equal returns true if two info objects are identical.
-func (a Info) Equal(b Info) bool {
-	return a.Address.Equal(b.Address) && a.NetworkID == b.NetworkID && a.Light == b.Light
-}

pkg/p2p/libp2p/internal/handshake/handshake_test.go

@@ -101,9 +101,7 @@ func TestHandshake(t *testing.T) {
 			t.Fatal(err)
 		}
 
-		if !res.Equal(expectedInfo) {
-			t.Fatalf("got %+v, expected %+v", res, info)
-		}
+		testInfo(t, *res, expectedInfo)
 
 		if err := r.ReadMsg(&pb.Ack{}); err != nil {
 			t.Fatal(err)
@@ -220,9 +218,7 @@ func TestHandle(t *testing.T) {
 			t.Fatal(err)
 		}
 
-		if !res.Equal(node2Info) {
-			t.Fatalf("got %+v, expected %+v", res, node2Info)
-		}
+		testInfo(t, *res, node2Info)
 
 		_, r := protobuf.NewWriterAndReader(stream2)
 		var got pb.ShakeHandAck
@@ -230,13 +226,11 @@ func TestHandle(t *testing.T) {
 			t.Fatal(err)
 		}
 
-		if !nodeInfo.Equal(Info{
+		testInfo(t, nodeInfo, Info{
 			Address:   swarm.NewAddress(got.ShakeHand.Address),
 			NetworkID: got.ShakeHand.NetworkID,
 			Light:     got.ShakeHand.Light,
-		}) {
-			t.Fatalf("got %+v, expected %+v", got, node2Info)
-		}
+		})
 	})
 
 	t.Run("ERROR - read error ", func(t *testing.T) {
@@ -312,3 +306,12 @@ func TestHandle(t *testing.T) {
 		}
 	})
 }
+
+// testInfo validates if two Info instances are equal.
+func testInfo(t *testing.T, got, want Info) {
+	t.Helper()
+
+	if !got.Address.Equal(want.Address) || got.NetworkID != want.NetworkID || got.Light != want.Light {
+		t.Fatalf("got info %+v, want %+v", got, want)
+	}
+}