update attacker client

attacker/client/src/main/java/tech/pegasys/teku/attacker/AttackService.java

@@ -11,11 +11,15 @@ public class AttackService {
     private final JsonRpcHttpClient jsonRpcClient;
 
     public AttackService() {
-        this.jsonRpcClient = JsonRpcClientUtil.getJsonRpcClient();
+        this.jsonRpcClient = JsonRpcClientUtil.getInstance().getJsonRpcClient();
     }
 
     public AttackService(final String url) {
-        this.jsonRpcClient = JsonRpcClientUtil.getJsonRpcClientByUrl(url);
+        this.jsonRpcClient = JsonRpcClientUtil.getInstance().getJsonRpcClientByUrl(url);
+    }
+
+    public boolean enabled() {
+        return this.jsonRpcClient != null;
     }
 
     private SafeFuture<AttackerResponse> invokeRpc(final String method, final Object[] params) {

attacker/client/src/main/java/tech/pegasys/teku/attacker/JsonRpcClientUtil.java

@@ -7,28 +7,34 @@ import java.net.URI;
 
 public class JsonRpcClientUtil {
 
-    private JsonRpcClientUtil(){
+    private static final JsonRpcClientUtil INSTANCE = new JsonRpcClientUtil();
 
+    private JsonRpcClientUtil() {
+        // Private constructor to prevent instantiation
     }
-    public static JsonRpcHttpClient getJsonRpcClient(){
-        return JsonRpcHttpClientSingleton.singleton("");
+
+    public static JsonRpcClientUtil getInstance() {
+        return INSTANCE;
+    }
+
+    public JsonRpcHttpClient getJsonRpcClient() {
+        return createJsonRpcClient("");
     }
-    public static JsonRpcHttpClient getJsonRpcClientByUrl(final String url){
-        return JsonRpcHttpClientSingleton.singleton(url);
+
+    public JsonRpcHttpClient getJsonRpcClientByUrl(final String url) {
+        return createJsonRpcClient(url);
     }
-    private static class JsonRpcHttpClientSingleton{
-        private static JsonRpcHttpClient singleton(final String url){
-            JsonRpcHttpClient client = null;
+
+    private JsonRpcHttpClient createJsonRpcClient(final String url) {
         try {
-                String real = url;
-                if (url.isEmpty()) {
-                    real = System.getenv("ATTACKER_SERVICE_URL");
+            String realUrl = url.isEmpty() ? System.getenv("ATTACKER_SERVICE_URL") : url;
+            if (realUrl == null || realUrl.isEmpty()) {
+                return null;
+            } else {
+                return new JsonRpcHttpClient(URI.create(realUrl).toURL());
             }
-                client = new JsonRpcHttpClient(URI.create(real).toURL());
         } catch (MalformedURLException e) {
             throw new RuntimeException(e);
         }
-            return client;
-        }
     }
 }
\ No newline at end of file

attacker/client/src/test/java/tech/pegasys/teku/attacker/AttackServiceTest.java

@@ -2,6 +2,7 @@ package tech.pegasys.teku.attacker;
 
 import static org.assertj.core.api.Assertions.assertThat;
 
+import org.checkerframework.checker.units.qual.A;
 import org.junit.jupiter.api.Test;
 import tech.pegasys.teku.infrastructure.async.SafeFuture;
 
@@ -9,16 +10,59 @@ import java.util.concurrent.ExecutionException;
 
 public class AttackServiceTest {
 
-    private AttackService attackService;
+    @Test
+    public void attackIsNotEnabled() {
+        AttackService s = new AttackService();
+        assertThat(s.enabled()).isEqualTo(false);
+    }
+
+    @Test
+    public void attackIsEnabled() {
+        AttackService s = new AttackService("http://127.0.0.1:12000");
+        assertThat(s.enabled()).isEqualTo(true);
+    }
 
     @Test
     public void blockGetNewParentRoot() throws ExecutionException, InterruptedException {
-        attackService = new AttackService("http://127.0.0.1:12000");
+        AttackService s = new AttackService("http://127.0.0.1:12000");
         long slot = 1L;
         String pub = "";
         String parentRoot = "";
-        SafeFuture<AttackerResponse> attackerResponse = attackService.blockGetNewParentRoot(slot, pub, parentRoot);
+        SafeFuture<AttackerResponse> attackerResponse = s.blockGetNewParentRoot(slot, pub, parentRoot);
         assertThat(attackerResponse.get().getCmd().getValue())
                 .isEqualTo(AttackerCommand.CMD_NULL.getValue());
     }
+    public void blockBeforeBroadcast() {
+        AttackService s = new AttackService("http://127.0.0.1:12000");
+        long slot = 1L;
+        boolean skipBroadCast = false;
+
+        try {
+            AttackerResponse attackerResponse = s.blockBeforeBroadcast(slot).get(); // Blocking call to get the result
+            switch (attackerResponse.getCmd()) {
+                case CMD_EXIT:
+                case CMD_ABORT:
+                    System.exit(-1); // Terminate the process
+                    break;
+                case CMD_SKIP:
+                    skipBroadCast = true; // Skip broadcast
+                    break;
+                case CMD_RETURN:
+                    // Simulate returning a response (adjust as per actual method requirements)
+                    return; // Exit the method
+                case CMD_NULL:
+                case CMD_CONTINUE:
+                    // Do nothing
+                    break;
+                default:
+                    throw new IllegalStateException("Unexpected command received: " + attackerResponse.getCmd());
+            }
+        } catch (Exception e) {
+            e.printStackTrace();
+            throw new RuntimeException("Failed to process attacker response", e);
+        }
+
+        System.out.println("Block before broadcast completed for slot: " + slot);
+        // then sleep 10s
+    }
 }
\ No newline at end of file