fix(cmn): BSV2 exposes default options in metadata (#2752)

Fix for BSV2 to expose default options in the metadata metric.
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

.changeset/weak-needles-jam.md

+---
+'@eth-optimism/common-ts': patch
+---
+
+Include default options in metadata metric

packages/common-ts/src/base-service/base-service-v2.ts

@@ -155,11 +155,7 @@ export abstract class BaseServiceV2<
     this.loop = params.loop !== undefined ? params.loop : true
     this.state = {} as TServiceState
 
-    // Add default options to options spec.
-    ;(params.optionsSpec as any) = {
-      ...(params.optionsSpec || {}),
-
-      // Users cannot set these options.
+    const stdOptionsSpec: OptionsSpec<StandardOptions> = {
       loopIntervalMs: {
         validator: validators.num,
         desc: 'Loop interval in milliseconds',
@@ -177,6 +173,12 @@ export abstract class BaseServiceV2<
       },
     }
 
+    // Add default options to options spec.
+    ;(params.optionsSpec as any) = {
+      ...(params.optionsSpec || {}),
+      ...stdOptionsSpec,
+    }
+
     // List of options that can safely be logged.
     const publicOptionNames = Object.entries(params.optionsSpec)
       .filter(([, spec]) => {
@@ -348,7 +350,11 @@ export abstract class BaseServiceV2<
         name: params.name,
         version: params.version,
         ...publicOptionNames.reduce((acc, key) => {
-          acc[key] = config.str(key)
+          if (key in stdOptionsSpec) {
+            acc[key] = this.options[key].toString()
+          } else {
+            acc[key] = config.str(key)
+          }
           return acc
         }, {}),
       },