Skip to content

N
nebula
Commit 0933da49 authored by George Knee's avatar George Knee Committed by GitHub
Browse files
Options

fix: op-batcher batch-tx-submitted metric double count (#12975) 

Co-authored-by: default avatarSamuel Laferriere <samlaf92@gmail.com>
parent 9144db1b
Hide whitespace changes
Inline Side-by-side
Showing with 1 addition and 1 deletion
op-batcher/batcher/channel.go
View file @ 0933da49
...@@ -64,7 +64,7 @@ func (c *channel) TxFailed(id string) { ...@@ -64,7 +64,7 @@ func (c *channel) TxFailed(id string) {
// TxConfirmed marks a transaction as confirmed on L1. Returns a bool indicating // TxConfirmed marks a transaction as confirmed on L1. Returns a bool indicating
// whether the channel timed out on chain. // whether the channel timed out on chain.
func (c *channel) TxConfirmed(id string, inclusionBlock eth.BlockID) bool { func (c *channel) TxConfirmed(id string, inclusionBlock eth.BlockID) bool {
c.metr.RecordBatchTxSubmitted() c.metr.RecordBatchTxSuccess()
c.log.Debug("marked transaction as confirmed", "id", id, "block", inclusionBlock) c.log.Debug("marked transaction as confirmed", "id", id, "block", inclusionBlock)
if _, ok := c.pendingTransactions[id]; !ok { if _, ok := c.pendingTransactions[id]; !ok {
c.log.Warn("unknown transaction marked as confirmed", "id", id, "block", inclusionBlock) c.log.Warn("unknown transaction marked as confirmed", "id", id, "block", inclusionBlock)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment