Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
N
nebula
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
exchain
nebula
Commits
0cd44702
Unverified
Commit
0cd44702
authored
Oct 26, 2023
by
Maurelian
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
specs: Define deployment order for liveness contracts
parent
57cfa4d3
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
12 additions
and
1 deletion
+12
-1
LivenessModule.t.sol
packages/contracts-bedrock/test/LivenessModule.t.sol
+1
-1
safe-liveness-checking.md
specs/safe-liveness-checking.md
+11
-0
No files found.
packages/contracts-bedrock/test/LivenessModule.t.sol
View file @
0cd44702
...
@@ -106,8 +106,8 @@ contract LivenessModule_TestInit is Test, SafeTestTools {
...
@@ -106,8 +106,8 @@ contract LivenessModule_TestInit is Test, SafeTestTools {
_minOwners: minOwners,
_minOwners: minOwners,
_fallbackOwner: fallbackOwner
_fallbackOwner: fallbackOwner
});
});
safeInstance.enableModule(address(livenessModule));
safeInstance.setGuard(address(livenessGuard));
safeInstance.setGuard(address(livenessGuard));
safeInstance.enableModule(address(livenessModule));
}
}
}
}
...
...
specs/safe-liveness-checking.md
View file @
0cd44702
...
@@ -86,3 +86,14 @@ The following security properties must be upheld:
...
@@ -86,3 +86,14 @@ The following security properties must be upheld:
5.
The module implements the correct checks prior to removing a signer.
5.
The module implements the correct checks prior to removing a signer.
6.
The module sets the correct threshold upon removing a signer.
6.
The module sets the correct threshold upon removing a signer.
7.
During a shutdown the module correctly removes all signers, and converts the safe to a 1 of 1.
7.
During a shutdown the module correctly removes all signers, and converts the safe to a 1 of 1.
### Deployment
The module are guard are intended to be deployed and installed on the safe in the following sequence:
1.
Deploy the guard contract, this will set a timestamp for each existing owner on the Safe.
1.
Deploy the module.
1.
Enable the module on the safe.
1.
Set the guard on the safe.
This order of operations is necessary to satisfy the constructor checks in the module, and is
intended to prevent owners from being immediately removable.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment