Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
N
nebula
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
exchain
nebula
Commits
0e203024
Unverified
Commit
0e203024
authored
Oct 06, 2023
by
Maurelian
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
feat(ctb): Remove notes/poc of guard removal prevention
parent
0b690016
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
0 additions
and
14 deletions
+0
-14
LivenessGuard.sol
packages/contracts-bedrock/src/Safe/LivenessGuard.sol
+0
-14
No files found.
packages/contracts-bedrock/src/Safe/LivenessGuard.sol
View file @
0e203024
...
...
@@ -42,20 +42,6 @@ contract LivenessGuard is SignatureDecoder, BaseGuard {
{
require(msg.sender == address(safe), "LivenessGuard: only Safe can call this function");
// There are a number of ways in which we need to constrain this safe so that it cannot remove
// this guard, nor the LivenessModule.
// TODO(Maurelian): Figure out how to best address this. The following is just intended to outline the
// known mathods by which a Safe could remove the liveness checks.
// TODO(Maurelian): Do we _need_ to have this feature at all?
bytes4 dataSig = bytes4(data);
if (
to == address(safe)
&& (dataSig == GuardManager.setGuard.selector || dataSig == ModuleManager.enableModule.selector)
|| operation == Enum.Operation.DelegateCall
) {
revert("LivenessGuard: cannot remove LivenessGuard or LivenessModule");
}
// This call will reenter to the Safe which is calling it. This is OK because it is only reading the
// nonce, and using the getTransactionHash() method.
bytes32 txHash = Safe(payable(msg.sender)).getTransactionHash(
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment