Commit 14243701 authored by Liam Horne's avatar Liam Horne

fix: use -z flag for var unset in canary

parent 2378711b
...@@ -74,11 +74,11 @@ jobs: ...@@ -74,11 +74,11 @@ jobs:
- name: Docker Image Name - name: Docker Image Name
id: docker_image_name id: docker_image_name
run: | run: |
if [ $CUSTOM_IMAGE_NAME == '' ] if [ -z "${CUSTOM_IMAGE_NAME}" ]
then then
echo "::set-output name=canary-docker-tag::${GITHUB_SHA::8}" echo "::set-output name=canary-docker-tag::${GITHUB_SHA::8}"
else else
echo "::set-output name=canary-docker-tag::prerelease-$CUSTOM_IMAGE_NAME" echo "::set-output name=canary-docker-tag::prerelease-${CUSTOM_IMAGE_NAME}"
fi fi
env: env:
CUSTOM_IMAGE_NAME: ${{ github.event.inputs.customImageName }} CUSTOM_IMAGE_NAME: ${{ github.event.inputs.customImageName }}
...@@ -112,7 +112,7 @@ jobs: ...@@ -112,7 +112,7 @@ jobs:
context: . context: .
file: ./ops/docker/Dockerfile.geth file: ./ops/docker/Dockerfile.geth
push: true push: true
tags: ethereumoptimism/l2geth:${{ needs.canary-publish.outputs.l2geth }} tags: ethereumoptimism/l2geth:${{ steps.docker_image_name.outputs.canary-docker-tag }}
# pushes the base builder image to dockerhub # pushes the base builder image to dockerhub
builder: builder:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment