Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
N
nebula
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
exchain
nebula
Commits
169a0d75
Unverified
Commit
169a0d75
authored
Jan 17, 2023
by
Mark Tyneway
Committed by
GitHub
Jan 17, 2023
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #4721 from ethereum-optimism/sc/dtl-deposit-shutoff-bug
fix(dtl): sync beyond deposit shutoff block
parents
bd925190
4396e187
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
15 additions
and
10 deletions
+15
-10
unlucky-rats-sit.md
.changeset/unlucky-rats-sit.md
+5
-0
service.ts
...data-transport-layer/src/services/l1-ingestion/service.ts
+10
-10
No files found.
.changeset/unlucky-rats-sit.md
0 → 100644
View file @
169a0d75
---
'
@eth-optimism/data-transport-layer'
:
patch
---
Fixes a bug in the DTL that would cause it to not be able to sync beyond the deposit shutoff block.
packages/data-transport-layer/src/services/l1-ingestion/service.ts
View file @
169a0d75
...
@@ -268,16 +268,16 @@ export class L1IngestionService extends BaseService<L1IngestionServiceOptions> {
...
@@ -268,16 +268,16 @@ export class L1IngestionService extends BaseService<L1IngestionServiceOptions> {
)
)
}
}
//
I prefer to do this in serial to avoid non-determinism. We could have a discussion about
//
We should not sync TransactionEnqueued events beyond the deposit shutoff block.
// using Promise.all if necessary, but I don't see a good reason to do so unless parsing is
if
(
depositTargetL1Block
>=
highestSyncedL1Block
)
{
// really, really slow for all event types.
await
this
.
_syncEvents
(
await
this
.
_syncEvents
(
'
CanonicalTransactionChain
'
,
'
CanonicalTransactionChain
'
,
'
TransactionEnqueued
'
,
'
TransactionEnqueued
'
,
highestSyncedL1Block
,
highestSynced
L1Block
,
depositTarget
L1Block
,
depositTargetL1Block
,
handleEventsTransactionEnqueued
handleEventsTransactionEnqueued
)
)
}
await
this
.
_syncEvents
(
await
this
.
_syncEvents
(
'
CanonicalTransactionChain
'
,
'
CanonicalTransactionChain
'
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment