Commit 19e70598 authored by Will Cory's avatar Will Cory

add a comment about the cleanup

parent 11c4569e
...@@ -409,6 +409,8 @@ export class CrossChainMessenger { ...@@ -409,6 +409,8 @@ export class CrossChainMessenger {
updated.message updated.message
) )
// EVERYTHING following here is basically repeating the logic from getMessagesByTransaction
// consider cleaning this up
// We need to figure out the final withdrawal data that was used to compute the withdrawal hash // We need to figure out the final withdrawal data that was used to compute the withdrawal hash
// inside the L2ToL1Message passer contract. Exact mechanism here depends on whether or not // inside the L2ToL1Message passer contract. Exact mechanism here depends on whether or not
// this is a legacy message or a new Bedrock message. // this is a legacy message or a new Bedrock message.
...@@ -1098,13 +1100,13 @@ export class CrossChainMessenger { ...@@ -1098,13 +1100,13 @@ export class CrossChainMessenger {
const challengePeriod = const challengePeriod =
oracleVersion === '1.0.0' oracleVersion === '1.0.0'
? // The ABI in the SDK does not contain FINALIZATION_PERIOD_SECONDS ? // The ABI in the SDK does not contain FINALIZATION_PERIOD_SECONDS
// in OptimismPortal, so making an explicit call instead. // in OptimismPortal, so making an explicit call instead.
BigNumber.from( BigNumber.from(
await this.contracts.l1.OptimismPortal.provider.call({ await this.contracts.l1.OptimismPortal.provider.call({
to: this.contracts.l1.OptimismPortal.address, to: this.contracts.l1.OptimismPortal.address,
data: '0xf4daa291', // FINALIZATION_PERIOD_SECONDS data: '0xf4daa291', // FINALIZATION_PERIOD_SECONDS
}) })
) )
: await this.contracts.l1.L2OutputOracle.FINALIZATION_PERIOD_SECONDS() : await this.contracts.l1.L2OutputOracle.FINALIZATION_PERIOD_SECONDS()
return challengePeriod.toNumber() return challengePeriod.toNumber()
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment