Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
N
nebula
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
exchain
nebula
Commits
205d51ff
Commit
205d51ff
authored
Oct 16, 2021
by
George Hotz
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
make update work with the magic of proof generation
parent
139a4b4f
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
17 additions
and
19 deletions
+17
-19
MIPSMemory.sol
contracts/MIPSMemory.sol
+1
-4
Lib_MerkleTrie.sol
contracts/lib/Lib_MerkleTrie.sol
+16
-15
No files found.
contracts/MIPSMemory.sol
View file @
205d51ff
...
@@ -84,10 +84,7 @@ contract MIPSMemory {
...
@@ -84,10 +84,7 @@ contract MIPSMemory {
function WriteMemory(bytes32 stateHash, uint32 addr, uint32 value) public view returns (bytes32) {
function WriteMemory(bytes32 stateHash, uint32 addr, uint32 value) public view returns (bytes32) {
require(addr & 3 == 0, "write memory must be 32-bit aligned");
require(addr & 3 == 0, "write memory must be 32-bit aligned");
return Lib_MerkleTrie.update(tb(addr>>2), tb(value), trie, stateHash);
// TODO: this can't delete nodes. modify the client to never delete
//return Lib_MerkleTrie.update(tb(addr), tb(value), proofs[stateHash][addr], stateHash);
return stateHash;
}
}
function WriteBytes32(bytes32 stateHash, uint32 addr, bytes32 val) public view returns (bytes32) {
function WriteBytes32(bytes32 stateHash, uint32 addr, bytes32 val) public view returns (bytes32) {
...
...
contracts/lib/Lib_MerkleTrie.sol
View file @
205d51ff
...
@@ -62,9 +62,7 @@ library Lib_MerkleTrie {
...
@@ -62,9 +62,7 @@ library Lib_MerkleTrie {
* @notice Updates a Merkle trie and returns a new root hash.
* @notice Updates a Merkle trie and returns a new root hash.
* @param _key Key of the node to update, as a hex string.
* @param _key Key of the node to update, as a hex string.
* @param _value Value of the node to update, as a hex string.
* @param _value Value of the node to update, as a hex string.
* @param _proof Merkle trie inclusion proof for the node *nearest* the
* @param trie Merkle trie
* target node. If the key exists, we can simply update the value.
* Otherwise, we need to modify the trie to handle the new k/v pair.
* @param _root Known root of the Merkle trie. Used to verify that the
* @param _root Known root of the Merkle trie. Used to verify that the
* included proof is correctly constructed.
* included proof is correctly constructed.
* @return _updatedRoot Root hash of the newly constructed trie.
* @return _updatedRoot Root hash of the newly constructed trie.
...
@@ -72,25 +70,24 @@ library Lib_MerkleTrie {
...
@@ -72,25 +70,24 @@ library Lib_MerkleTrie {
function update(
function update(
bytes memory _key,
bytes memory _key,
bytes memory _value,
bytes memory _value,
bytes memory _proof
,
mapping(bytes32 => bytes) storage trie
,
bytes32 _root
bytes32 _root
)
)
internal
internal
pure
view
returns (
returns (
bytes32 _updatedRoot
bytes32 _updatedRoot
)
)
{
{
// Special case when inserting the very first node.
// Special case when inserting the very first node.
/*
if (_root == KECCAK256_RLP_NULL_BYTES) {
if (_root == KECCAK256_RLP_NULL_BYTES) {
return getSingleNodeRootHash(_key, _value);
return getSingleNodeRootHash(_key, _value);
}
}
TrieNode[] memory proof = _parseProof(_proof);
(TrieNode[] memory proof, uint256 pathLength, bytes memory keyRemainder, ) = _walkNodePath(trie, _key, _root);
(uint256 pathLength, bytes memory keyRemainder, ) = _walkNodePath(proof, _key, _root);
TrieNode[] memory newPath = _getNewPath(proof, pathLength, keyRemainder, _value);
TrieNode[] memory newPath = _getNewPath(proof, pathLength, keyRemainder, _value);
return _getUpdatedTrieRoot(newPath, _key);
*/
return _getUpdatedTrieRoot(newPath, _key);
}
}
function getRawNode(bytes memory encoded) private view returns (TrieNode memory) {
function getRawNode(bytes memory encoded) private view returns (TrieNode memory) {
...
@@ -124,7 +121,7 @@ library Lib_MerkleTrie {
...
@@ -124,7 +121,7 @@ library Lib_MerkleTrie {
bytes memory _value
bytes memory _value
)
)
{
{
(
uint256 pathLength, bytes memory keyRemainder, bool isFinalNode, TrieNode memory f
inalNode) = _walkNodePath(trie, _key, _root);
(
TrieNode[] memory proof, uint256 pathLength, bytes memory keyRemainder, bool isF
inalNode) = _walkNodePath(trie, _key, _root);
bool exists = keyRemainder.length == 0;
bool exists = keyRemainder.length == 0;
...
@@ -133,7 +130,7 @@ library Lib_MerkleTrie {
...
@@ -133,7 +130,7 @@ library Lib_MerkleTrie {
"Provided proof is invalid."
"Provided proof is invalid."
);
);
bytes memory value = exists ? _getNodeValue(
finalNode
) : bytes('');
bytes memory value = exists ? _getNodeValue(
proof[pathLength - 1]
) : bytes('');
return (
return (
exists,
exists,
...
@@ -173,10 +170,10 @@ library Lib_MerkleTrie {
...
@@ -173,10 +170,10 @@ library Lib_MerkleTrie {
* @param trie Merkle trie
* @param trie Merkle trie
* @param _key Key to use for the walk.
* @param _key Key to use for the walk.
* @param _root Known root of the trie.
* @param _root Known root of the trie.
* @return _proof The proof
* @return _pathLength Length of the final path
* @return _pathLength Length of the final path
* @return _keyRemainder Portion of the key remaining after the walk.
* @return _keyRemainder Portion of the key remaining after the walk.
* @return _isFinalNode Whether or not we've hit a dead end.
* @return _isFinalNode Whether or not we've hit a dead end.
* @return _finalNode The final node
*/
*/
function _walkNodePath(
function _walkNodePath(
mapping(bytes32 => bytes) storage trie,
mapping(bytes32 => bytes) storage trie,
...
@@ -186,12 +183,15 @@ library Lib_MerkleTrie {
...
@@ -186,12 +183,15 @@ library Lib_MerkleTrie {
private
private
view
view
returns (
returns (
TrieNode[] memory _proof,
uint256 _pathLength,
uint256 _pathLength,
bytes memory _keyRemainder,
bytes memory _keyRemainder,
bool _isFinalNode,
bool _isFinalNode
TrieNode memory _finalNode
)
)
{
{
// TODO: this is max length
_proof = new TrieNode[](16);
uint256 pathLength = 0;
uint256 pathLength = 0;
bytes memory key = Lib_BytesUtils.toNibbles(_key);
bytes memory key = Lib_BytesUtils.toNibbles(_key);
...
@@ -212,6 +212,7 @@ library Lib_MerkleTrie {
...
@@ -212,6 +212,7 @@ library Lib_MerkleTrie {
// Keep track of the proof elements we actually need.
// Keep track of the proof elements we actually need.
// It's expensive to resize arrays, so this simply reduces gas costs.
// It's expensive to resize arrays, so this simply reduces gas costs.
_proof[pathLength] = currentNode;
pathLength += 1;
pathLength += 1;
if (currentKeyIndex == 0) {
if (currentKeyIndex == 0) {
...
@@ -291,7 +292,7 @@ library Lib_MerkleTrie {
...
@@ -291,7 +292,7 @@ library Lib_MerkleTrie {
// If our node ID is NULL, then we're at a dead end.
// If our node ID is NULL, then we're at a dead end.
bool isFinalNode = currentNodeID == bytes32(RLP_NULL);
bool isFinalNode = currentNodeID == bytes32(RLP_NULL);
return (
pathLength, Lib_BytesUtils.slice(key, currentKeyIndex), isFinalNode, current
Node);
return (
_proof, pathLength, Lib_BytesUtils.slice(key, currentKeyIndex), isFinal
Node);
}
}
/**
/**
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment