Commit 209b8096 authored by Maurelian's avatar Maurelian

ctb: Apply suggestions from code review

parent fed16f5a
...@@ -401,7 +401,7 @@ contract Deploy is Deployer { ...@@ -401,7 +401,7 @@ contract Deploy is Deployer {
_l2Oracle: l2OutputOracle, _l2Oracle: l2OutputOracle,
_guardian: guardian, _guardian: guardian,
_paused: true, _paused: true,
_config: systemConfig _systemConfig: systemConfig
}); });
require(address(portal.L2_ORACLE()) == address(l2OutputOracle)); require(address(portal.L2_ORACLE()) == address(l2OutputOracle));
......
...@@ -19,8 +19,8 @@ contract L1CrossDomainMessenger is CrossDomainMessenger, ISemver { ...@@ -19,8 +19,8 @@ contract L1CrossDomainMessenger is CrossDomainMessenger, ISemver {
OptimismPortal public immutable PORTAL; OptimismPortal public immutable PORTAL;
/// @notice Semantic version. /// @notice Semantic version.
/// @custom:semver 1.5.0 /// @custom:semver 1.8.0
string public constant version = "1.5.0"; string public constant version = "1.8.0";
/// @notice Constructs the L1CrossDomainMessenger contract. /// @notice Constructs the L1CrossDomainMessenger contract.
/// @param _portal Address of the OptimismPortal contract on this network. /// @param _portal Address of the OptimismPortal contract on this network.
......
...@@ -19,8 +19,8 @@ contract L1ERC721Bridge is ERC721Bridge, ISemver { ...@@ -19,8 +19,8 @@ contract L1ERC721Bridge is ERC721Bridge, ISemver {
mapping(address => mapping(address => mapping(uint256 => bool))) public deposits; mapping(address => mapping(address => mapping(uint256 => bool))) public deposits;
/// @notice Semantic version. /// @notice Semantic version.
/// @custom:semver 1.5.1 /// @custom:semver 1.5.0
string public constant version = "1.5.1"; string public constant version = "1.5.0";
/// @notice Constructs the L1ERC721Bridge contract. /// @notice Constructs the L1ERC721Bridge contract.
/// @param _messenger Address of the CrossDomainMessenger on this network. /// @param _messenger Address of the CrossDomainMessenger on this network.
......
...@@ -15,13 +15,16 @@ contract L2OutputOracle is Initializable, ISemver { ...@@ -15,13 +15,16 @@ contract L2OutputOracle is Initializable, ISemver {
/// @notice The interval in L2 blocks at which checkpoints must be submitted. /// @notice The interval in L2 blocks at which checkpoints must be submitted.
/// Although this is immutable, it can safely be modified by upgrading the /// Although this is immutable, it can safely be modified by upgrading the
/// implementation contract. /// implementation contract.
/// Public getter is legacy and will be removed in the future. Use `submissionInterval`
/// instead.
/// @custom:legacy
uint256 public immutable SUBMISSION_INTERVAL; uint256 public immutable SUBMISSION_INTERVAL;
/// @notice The time between L2 blocks in seconds. Once set, this value MUST NOT be modified. /// @notice The time between L2 blocks in seconds. Once set, this value MUST NOT be modified.
uint256 public immutable L2_BLOCK_TIME; uint256 public immutable L2_BLOCK_TIME;
/// @notice The address of the challenger. Can be updated via upgrade. This will be removed in the /// @notice The address of the challenger. Can be updated via upgrade. This will be removed in the
/// future, use `proposer` instead. /// future, use `challenger` instead.
/// @custom:legacy /// @custom:legacy
address public immutable CHALLENGER; address public immutable CHALLENGER;
......
...@@ -109,11 +109,11 @@ contract OptimismPortal is Initializable, ResourceMetering, ISemver { ...@@ -109,11 +109,11 @@ contract OptimismPortal is Initializable, ResourceMetering, ISemver {
/// @param _l2Oracle Address of the L2OutputOracle contract. /// @param _l2Oracle Address of the L2OutputOracle contract.
/// @param _guardian Address that can pause withdrawals. /// @param _guardian Address that can pause withdrawals.
/// @param _paused Sets the contract's pausability state. /// @param _paused Sets the contract's pausability state.
/// @param _config Address of the SystemConfig contract. /// @param _systemConfig Address of the SystemConfig contract.
constructor(L2OutputOracle _l2Oracle, address _guardian, bool _paused, SystemConfig _config) { constructor(L2OutputOracle _l2Oracle, address _guardian, bool _paused, SystemConfig _systemConfig) {
L2_ORACLE = _l2Oracle; L2_ORACLE = _l2Oracle;
GUARDIAN = _guardian; GUARDIAN = _guardian;
SYSTEM_CONFIG = _config; SYSTEM_CONFIG = _systemConfig;
initialize(_paused); initialize(_paused);
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment