Commit 21dbe75d authored by Adrian Sutton's avatar Adrian Sutton Committed by GitHub

op-challenger: Set the default trace type to cannon. (#8881)

parent e9d8927c
...@@ -75,8 +75,10 @@ func TestL1ETHRPCAddress(t *testing.T) { ...@@ -75,8 +75,10 @@ func TestL1ETHRPCAddress(t *testing.T) {
} }
func TestTraceType(t *testing.T) { func TestTraceType(t *testing.T) {
t.Run("Required", func(t *testing.T) { t.Run("Default", func(t *testing.T) {
verifyArgsInvalid(t, "flag trace-type is required", addRequiredArgsExcept("", "--trace-type")) expectedDefault := config.TraceTypeCannon
cfg := configForArgs(t, addRequiredArgsExcept(expectedDefault, "--trace-type"))
require.Equal(t, []config.TraceType{expectedDefault}, cfg.TraceTypes)
}) })
for _, traceType := range config.TraceTypes { for _, traceType := range config.TraceTypes {
......
...@@ -49,6 +49,7 @@ var ( ...@@ -49,6 +49,7 @@ var (
Name: "trace-type", Name: "trace-type",
Usage: "The trace types to support. Valid options: " + openum.EnumString(config.TraceTypes), Usage: "The trace types to support. Valid options: " + openum.EnumString(config.TraceTypes),
EnvVars: prefixEnvVars("TRACE_TYPE"), EnvVars: prefixEnvVars("TRACE_TYPE"),
Value: cli.NewStringSlice(config.TraceTypeCannon.String()),
} }
DatadirFlag = &cli.StringFlag{ DatadirFlag = &cli.StringFlag{
Name: "datadir", Name: "datadir",
...@@ -135,12 +136,12 @@ var ( ...@@ -135,12 +136,12 @@ var (
var requiredFlags = []cli.Flag{ var requiredFlags = []cli.Flag{
L1EthRpcFlag, L1EthRpcFlag,
FactoryAddressFlag, FactoryAddressFlag,
TraceTypeFlag,
DatadirFlag, DatadirFlag,
} }
// optionalFlags is a list of unchecked cli flags // optionalFlags is a list of unchecked cli flags
var optionalFlags = []cli.Flag{ var optionalFlags = []cli.Flag{
TraceTypeFlag,
MaxConcurrencyFlag, MaxConcurrencyFlag,
HTTPPollInterval, HTTPPollInterval,
RollupRpcFlag, RollupRpcFlag,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment