Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
N
nebula
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
exchain
nebula
Commits
21dbe75d
Unverified
Commit
21dbe75d
authored
Jan 08, 2024
by
Adrian Sutton
Committed by
GitHub
Jan 08, 2024
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
op-challenger: Set the default trace type to cannon. (#8881)
parent
e9d8927c
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
3 deletions
+6
-3
main_test.go
op-challenger/cmd/main_test.go
+4
-2
flags.go
op-challenger/flags/flags.go
+2
-1
No files found.
op-challenger/cmd/main_test.go
View file @
21dbe75d
...
@@ -75,8 +75,10 @@ func TestL1ETHRPCAddress(t *testing.T) {
...
@@ -75,8 +75,10 @@ func TestL1ETHRPCAddress(t *testing.T) {
}
}
func
TestTraceType
(
t
*
testing
.
T
)
{
func
TestTraceType
(
t
*
testing
.
T
)
{
t
.
Run
(
"Required"
,
func
(
t
*
testing
.
T
)
{
t
.
Run
(
"Default"
,
func
(
t
*
testing
.
T
)
{
verifyArgsInvalid
(
t
,
"flag trace-type is required"
,
addRequiredArgsExcept
(
""
,
"--trace-type"
))
expectedDefault
:=
config
.
TraceTypeCannon
cfg
:=
configForArgs
(
t
,
addRequiredArgsExcept
(
expectedDefault
,
"--trace-type"
))
require
.
Equal
(
t
,
[]
config
.
TraceType
{
expectedDefault
},
cfg
.
TraceTypes
)
})
})
for
_
,
traceType
:=
range
config
.
TraceTypes
{
for
_
,
traceType
:=
range
config
.
TraceTypes
{
...
...
op-challenger/flags/flags.go
View file @
21dbe75d
...
@@ -49,6 +49,7 @@ var (
...
@@ -49,6 +49,7 @@ var (
Name
:
"trace-type"
,
Name
:
"trace-type"
,
Usage
:
"The trace types to support. Valid options: "
+
openum
.
EnumString
(
config
.
TraceTypes
),
Usage
:
"The trace types to support. Valid options: "
+
openum
.
EnumString
(
config
.
TraceTypes
),
EnvVars
:
prefixEnvVars
(
"TRACE_TYPE"
),
EnvVars
:
prefixEnvVars
(
"TRACE_TYPE"
),
Value
:
cli
.
NewStringSlice
(
config
.
TraceTypeCannon
.
String
()),
}
}
DatadirFlag
=
&
cli
.
StringFlag
{
DatadirFlag
=
&
cli
.
StringFlag
{
Name
:
"datadir"
,
Name
:
"datadir"
,
...
@@ -135,12 +136,12 @@ var (
...
@@ -135,12 +136,12 @@ var (
var
requiredFlags
=
[]
cli
.
Flag
{
var
requiredFlags
=
[]
cli
.
Flag
{
L1EthRpcFlag
,
L1EthRpcFlag
,
FactoryAddressFlag
,
FactoryAddressFlag
,
TraceTypeFlag
,
DatadirFlag
,
DatadirFlag
,
}
}
// optionalFlags is a list of unchecked cli flags
// optionalFlags is a list of unchecked cli flags
var
optionalFlags
=
[]
cli
.
Flag
{
var
optionalFlags
=
[]
cli
.
Flag
{
TraceTypeFlag
,
MaxConcurrencyFlag
,
MaxConcurrencyFlag
,
HTTPPollInterval
,
HTTPPollInterval
,
RollupRpcFlag
,
RollupRpcFlag
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment