Commit 22f6efe1 authored by Maurelian's avatar Maurelian Committed by GitHub

Merge pull request #8537 from ethereum-optimism/cl/ctb/test-lint

chore(ctb): fmt
parents aa40d189 c4b83516
3e962e2efe17396886fcb1fd141ccf4204cd3a21 f460583ba4ea5fc7d3917eb071c544c1fbd3eadd
...@@ -380,9 +380,7 @@ contract Deploy is Deployer { ...@@ -380,9 +380,7 @@ contract Deploy is Deployer {
/// @notice Deploy the ProxyAdmin /// @notice Deploy the ProxyAdmin
function deployProxyAdmin() public broadcast returns (address addr_) { function deployProxyAdmin() public broadcast returns (address addr_) {
console.log("Deploying ProxyAdmin"); console.log("Deploying ProxyAdmin");
ProxyAdmin admin = new ProxyAdmin({ ProxyAdmin admin = new ProxyAdmin({ _owner: msg.sender });
_owner: msg.sender
});
require(admin.owner() == msg.sender); require(admin.owner() == msg.sender);
AddressManager addressManager = AddressManager(mustGetAddress("AddressManager")); AddressManager addressManager = AddressManager(mustGetAddress("AddressManager"));
...@@ -440,9 +438,7 @@ contract Deploy is Deployer { ...@@ -440,9 +438,7 @@ contract Deploy is Deployer {
function deployERC1967Proxy(string memory _name) public broadcast returns (address addr_) { function deployERC1967Proxy(string memory _name) public broadcast returns (address addr_) {
console.log(string.concat("Deploying ERC1967 proxy for", _name, "")); console.log(string.concat("Deploying ERC1967 proxy for", _name, ""));
address proxyAdmin = mustGetAddress("ProxyAdmin"); address proxyAdmin = mustGetAddress("ProxyAdmin");
Proxy proxy = new Proxy({ Proxy proxy = new Proxy({ _admin: proxyAdmin });
_admin: proxyAdmin
});
address admin = address(uint160(uint256(vm.load(address(proxy), OWNER_KEY)))); address admin = address(uint160(uint256(vm.load(address(proxy), OWNER_KEY))));
require(admin == proxyAdmin); require(admin == proxyAdmin);
...@@ -472,9 +468,8 @@ contract Deploy is Deployer { ...@@ -472,9 +468,8 @@ contract Deploy is Deployer {
function deployL1CrossDomainMessenger() public broadcast returns (address addr_) { function deployL1CrossDomainMessenger() public broadcast returns (address addr_) {
console.log("Deploying L1CrossDomainMessenger implementation"); console.log("Deploying L1CrossDomainMessenger implementation");
address portal = mustGetAddress("OptimismPortalProxy"); address portal = mustGetAddress("OptimismPortalProxy");
L1CrossDomainMessenger messenger = new L1CrossDomainMessenger{ salt: _implSalt() }({ L1CrossDomainMessenger messenger =
_portal: OptimismPortal(payable(portal)) new L1CrossDomainMessenger{ salt: _implSalt() }({ _portal: OptimismPortal(payable(portal)) });
});
save("L1CrossDomainMessenger", address(messenger)); save("L1CrossDomainMessenger", address(messenger));
console.log("L1CrossDomainMessenger deployed at %s", address(messenger)); console.log("L1CrossDomainMessenger deployed at %s", address(messenger));
...@@ -498,10 +493,8 @@ contract Deploy is Deployer { ...@@ -498,10 +493,8 @@ contract Deploy is Deployer {
L2OutputOracle l2OutputOracle = L2OutputOracle(mustGetAddress("L2OutputOracleProxy")); L2OutputOracle l2OutputOracle = L2OutputOracle(mustGetAddress("L2OutputOracleProxy"));
SystemConfig systemConfig = SystemConfig(mustGetAddress("SystemConfigProxy")); SystemConfig systemConfig = SystemConfig(mustGetAddress("SystemConfigProxy"));
OptimismPortal portal = new OptimismPortal{ salt: _implSalt() }({ OptimismPortal portal =
_l2Oracle: l2OutputOracle, new OptimismPortal{ salt: _implSalt() }({ _l2Oracle: l2OutputOracle, _systemConfig: systemConfig });
_systemConfig: systemConfig
});
save("OptimismPortal", address(portal)); save("OptimismPortal", address(portal));
console.log("OptimismPortal deployed at %s", address(portal)); console.log("OptimismPortal deployed at %s", address(portal));
...@@ -551,7 +544,7 @@ contract Deploy is Deployer { ...@@ -551,7 +544,7 @@ contract Deploy is Deployer {
console.log("Deploying OptimismMintableERC20Factory implementation"); console.log("Deploying OptimismMintableERC20Factory implementation");
address l1standardBridgeProxy = mustGetAddress("L1StandardBridgeProxy"); address l1standardBridgeProxy = mustGetAddress("L1StandardBridgeProxy");
OptimismMintableERC20Factory factory = OptimismMintableERC20Factory factory =
new OptimismMintableERC20Factory{ salt: _implSalt() }({_bridge: l1standardBridgeProxy}); new OptimismMintableERC20Factory{ salt: _implSalt() }({ _bridge: l1standardBridgeProxy });
save("OptimismMintableERC20Factory", address(factory)); save("OptimismMintableERC20Factory", address(factory));
console.log("OptimismMintableERC20Factory deployed at %s", address(factory)); console.log("OptimismMintableERC20Factory deployed at %s", address(factory));
...@@ -660,9 +653,8 @@ contract Deploy is Deployer { ...@@ -660,9 +653,8 @@ contract Deploy is Deployer {
console.log("Deploying L1StandardBridge implementation"); console.log("Deploying L1StandardBridge implementation");
address l1CrossDomainMessengerProxy = mustGetAddress("L1CrossDomainMessengerProxy"); address l1CrossDomainMessengerProxy = mustGetAddress("L1CrossDomainMessengerProxy");
L1StandardBridge bridge = new L1StandardBridge{ salt: _implSalt() }({ L1StandardBridge bridge =
_messenger: payable(l1CrossDomainMessengerProxy) new L1StandardBridge{ salt: _implSalt() }({ _messenger: payable(l1CrossDomainMessengerProxy) });
});
save("L1StandardBridge", address(bridge)); save("L1StandardBridge", address(bridge));
console.log("L1StandardBridge deployed at %s", address(bridge)); console.log("L1StandardBridge deployed at %s", address(bridge));
...@@ -681,9 +673,7 @@ contract Deploy is Deployer { ...@@ -681,9 +673,7 @@ contract Deploy is Deployer {
function deployL1ERC721Bridge() public broadcast returns (address addr_) { function deployL1ERC721Bridge() public broadcast returns (address addr_) {
console.log("Deploying L1ERC721Bridge implementation"); console.log("Deploying L1ERC721Bridge implementation");
address l1CrossDomainMessengerProxy = mustGetAddress("L1CrossDomainMessengerProxy"); address l1CrossDomainMessengerProxy = mustGetAddress("L1CrossDomainMessengerProxy");
L1ERC721Bridge bridge = new L1ERC721Bridge{ salt: _implSalt() }({ L1ERC721Bridge bridge = new L1ERC721Bridge{ salt: _implSalt() }({ _messenger: l1CrossDomainMessengerProxy });
_messenger: l1CrossDomainMessengerProxy
});
save("L1ERC721Bridge", address(bridge)); save("L1ERC721Bridge", address(bridge));
console.log("L1ERC721Bridge deployed at %s", address(bridge)); console.log("L1ERC721Bridge deployed at %s", address(bridge));
......
...@@ -91,9 +91,7 @@ contract DeployPeriphery is Deployer { ...@@ -91,9 +91,7 @@ contract DeployPeriphery is Deployer {
save("ProxyAdmin", preComputedAddress); save("ProxyAdmin", preComputedAddress);
addr_ = preComputedAddress; addr_ = preComputedAddress;
} else { } else {
ProxyAdmin admin = new ProxyAdmin{ salt: salt }({ ProxyAdmin admin = new ProxyAdmin{ salt: salt }({ _owner: msg.sender });
_owner: msg.sender
});
require(admin.owner() == msg.sender); require(admin.owner() == msg.sender);
save("ProxyAdmin", address(admin)); save("ProxyAdmin", address(admin));
...@@ -114,9 +112,7 @@ contract DeployPeriphery is Deployer { ...@@ -114,9 +112,7 @@ contract DeployPeriphery is Deployer {
save("FaucetProxy", preComputedAddress); save("FaucetProxy", preComputedAddress);
addr_ = preComputedAddress; addr_ = preComputedAddress;
} else { } else {
Proxy proxy = new Proxy{ salt: salt }({ Proxy proxy = new Proxy{ salt: salt }({ _admin: proxyAdmin });
_admin: proxyAdmin
});
address admin = address(uint160(uint256(vm.load(address(proxy), OWNER_KEY)))); address admin = address(uint160(uint256(vm.load(address(proxy), OWNER_KEY))));
require(admin == proxyAdmin); require(admin == proxyAdmin);
......
...@@ -137,7 +137,7 @@ ...@@ -137,7 +137,7 @@
}, },
"src/universal/OptimismMintableERC20Factory.sol": { "src/universal/OptimismMintableERC20Factory.sol": {
"initCodeHash": "0x786f4d03cf19cf3af728966a8b22385e178e2021f20b410032c195bbc57e1e7c", "initCodeHash": "0x786f4d03cf19cf3af728966a8b22385e178e2021f20b410032c195bbc57e1e7c",
"sourceCodeHash": "0x723c294abec447081df4a87104e9ae6c0a1f14cc76499be734008d850eae3a0f" "sourceCodeHash": "0x76556319925ee2bbec0eeaddcce8904b602507ed5edbcc82a1afe920b46f1840"
}, },
"src/universal/OptimismMintableERC721.sol": { "src/universal/OptimismMintableERC721.sol": {
"initCodeHash": "0xb400f430acf4d65bee9635e4935a6e1e3a0284fc50aea40ad8b7818dc826f31c", "initCodeHash": "0xb400f430acf4d65bee9635e4935a6e1e3a0284fc50aea40ad8b7818dc826f31c",
...@@ -145,7 +145,7 @@ ...@@ -145,7 +145,7 @@
}, },
"src/universal/OptimismMintableERC721Factory.sol": { "src/universal/OptimismMintableERC721Factory.sol": {
"initCodeHash": "0x5504069cb1377405bf5c6f1b37ea02057fdb452cf85922cc83dffd5390cad7da", "initCodeHash": "0x5504069cb1377405bf5c6f1b37ea02057fdb452cf85922cc83dffd5390cad7da",
"sourceCodeHash": "0x89cab3bfb4a6a6146336585216c78f20733219ac6973e7fc1cb49c43c060662d" "sourceCodeHash": "0xf8f2f0f6bc3cdbacbb1ef8b3fa31897a1eb749af0ba14b19b0cbc1cf0e6271f8"
}, },
"src/universal/StorageSetter.sol": { "src/universal/StorageSetter.sol": {
"initCodeHash": "0xb656d2aa6aff3e6435e747a0c23236d1b66f1f5c0b45e4b1a10d290a90223c5a", "initCodeHash": "0xb656d2aa6aff3e6435e747a0c23236d1b66f1f5c0b45e4b1a10d290a90223c5a",
......
...@@ -99,7 +99,7 @@ contract OptimismMintableERC20Factory is ISemver { ...@@ -99,7 +99,7 @@ contract OptimismMintableERC20Factory is ISemver {
bytes32 salt = keccak256(abi.encode(_remoteToken, _name, _symbol, _decimals)); bytes32 salt = keccak256(abi.encode(_remoteToken, _name, _symbol, _decimals));
address localToken = address localToken =
address(new OptimismMintableERC20{salt: salt}(BRIDGE, _remoteToken, _name, _symbol, _decimals)); address(new OptimismMintableERC20{ salt: salt }(BRIDGE, _remoteToken, _name, _symbol, _decimals));
// Emit the old event too for legacy support. // Emit the old event too for legacy support.
emit StandardL2TokenCreated(_remoteToken, localToken); emit StandardL2TokenCreated(_remoteToken, localToken);
......
...@@ -52,7 +52,7 @@ contract OptimismMintableERC721Factory is ISemver { ...@@ -52,7 +52,7 @@ contract OptimismMintableERC721Factory is ISemver {
bytes32 salt = keccak256(abi.encode(_remoteToken, _name, _symbol)); bytes32 salt = keccak256(abi.encode(_remoteToken, _name, _symbol));
address localToken = address localToken =
address(new OptimismMintableERC721{salt: salt}(BRIDGE, REMOTE_CHAIN_ID, _remoteToken, _name, _symbol)); address(new OptimismMintableERC721{ salt: salt }(BRIDGE, REMOTE_CHAIN_ID, _remoteToken, _name, _symbol));
isOptimismMintableERC721[localToken] = true; isOptimismMintableERC721[localToken] = true;
emit OptimismMintableERC721Created(localToken, _remoteToken, msg.sender); emit OptimismMintableERC721Created(localToken, _remoteToken, msg.sender);
......
...@@ -71,7 +71,7 @@ contract L2OutputOracle_constructor_Test is CommonTest { ...@@ -71,7 +71,7 @@ contract L2OutputOracle_constructor_Test is CommonTest {
new L2OutputOracle({ new L2OutputOracle({
_submissionInterval: 0, _submissionInterval: 0,
_l2BlockTime: l2BlockTime, _l2BlockTime: l2BlockTime,
_startingBlockNumber: startingBlockNumber, _startingBlockNumber: startingBlockNumber,
_startingTimestamp: block.timestamp, _startingTimestamp: block.timestamp,
_proposer: proposer, _proposer: proposer,
_challenger: challenger, _challenger: challenger,
......
...@@ -103,7 +103,11 @@ contract SequencerFeeVault_L2Withdrawal_Test is CommonTest { ...@@ -103,7 +103,11 @@ contract SequencerFeeVault_L2Withdrawal_Test is CommonTest {
vm.etch( vm.etch(
EIP1967Helper.getImplementation(Predeploys.SEQUENCER_FEE_WALLET), EIP1967Helper.getImplementation(Predeploys.SEQUENCER_FEE_WALLET),
address( address(
new SequencerFeeVault(deploy.cfg().sequencerFeeVaultRecipient(), deploy.cfg().sequencerFeeVaultMinimumWithdrawalAmount(), FeeVault.WithdrawalNetwork.L2) new SequencerFeeVault(
deploy.cfg().sequencerFeeVaultRecipient(),
deploy.cfg().sequencerFeeVaultMinimumWithdrawalAmount(),
FeeVault.WithdrawalNetwork.L2
)
).code ).code
); );
......
...@@ -371,12 +371,12 @@ contract LivenessModule_RemoveOwnersFuzz_Test is LivenessModule_TestInit { ...@@ -371,12 +371,12 @@ contract LivenessModule_RemoveOwnersFuzz_Test is LivenessModule_TestInit {
safeInstance = _setupSafe(keys, threshold); safeInstance = _setupSafe(keys, threshold);
livenessGuard = new LivenessGuard(safeInstance.safe); livenessGuard = new LivenessGuard(safeInstance.safe);
livenessModule = new LivenessModule({ livenessModule = new LivenessModule({
_safe: safeInstance.safe, _safe: safeInstance.safe,
_livenessGuard: livenessGuard, _livenessGuard: livenessGuard,
_livenessInterval: livenessInterval, _livenessInterval: livenessInterval,
_minOwners: minOwners_, _minOwners: minOwners_,
_fallbackOwner: fallbackOwner _fallbackOwner: fallbackOwner
}); });
safeInstance.setGuard(address(livenessGuard)); safeInstance.setGuard(address(livenessGuard));
safeInstance.enableModule(address(livenessModule)); safeInstance.enableModule(address(livenessModule));
......
...@@ -992,11 +992,7 @@ contract FaultDisputeGame_ResolvesCorrectly_IncorrectRootFuzz is OneVsOne_Arena ...@@ -992,11 +992,7 @@ contract FaultDisputeGame_ResolvesCorrectly_IncorrectRootFuzz is OneVsOne_Arena
uint256 snapshot = vm.snapshot(); uint256 snapshot = vm.snapshot();
GamePlayer honest = new HonestPlayer(ABSOLUTE_PRESTATE); GamePlayer honest = new HonestPlayer(ABSOLUTE_PRESTATE);
GamePlayer dishonest = new VariableDivergentPlayer( GamePlayer dishonest = new VariableDivergentPlayer(ABSOLUTE_PRESTATE, _dishonestTraceLength, i);
ABSOLUTE_PRESTATE,
_dishonestTraceLength,
i
);
super.init(dishonest, honest, _dishonestTraceLength - 1); super.init(dishonest, honest, _dishonestTraceLength - 1);
// Play the game until a step is forced. // Play the game until a step is forced.
...@@ -1023,11 +1019,7 @@ contract FaultDisputeGame_ResolvesCorrectly_CorrectRootFuzz is OneVsOne_Arena { ...@@ -1023,11 +1019,7 @@ contract FaultDisputeGame_ResolvesCorrectly_CorrectRootFuzz is OneVsOne_Arena {
uint256 snapshot = vm.snapshot(); uint256 snapshot = vm.snapshot();
GamePlayer honest = new HonestPlayer(ABSOLUTE_PRESTATE); GamePlayer honest = new HonestPlayer(ABSOLUTE_PRESTATE);
GamePlayer dishonest = new VariableDivergentPlayer( GamePlayer dishonest = new VariableDivergentPlayer(ABSOLUTE_PRESTATE, _dishonestTraceLength, i);
ABSOLUTE_PRESTATE,
_dishonestTraceLength,
i
);
super.init(honest, dishonest, 15); super.init(honest, dishonest, 15);
// Play the game until a step is forced. // Play the game until a step is forced.
......
...@@ -55,8 +55,8 @@ contract OutputBisectionGame_Init is DisputeGameFactory_Init { ...@@ -55,8 +55,8 @@ contract OutputBisectionGame_Init is DisputeGameFactory_Init {
_absolutePrestate: absolutePrestate, _absolutePrestate: absolutePrestate,
_genesisBlockNumber: GENESIS_BLOCK_NUMBER, _genesisBlockNumber: GENESIS_BLOCK_NUMBER,
_genesisOutputRoot: GENESIS_OUTPUT_ROOT, _genesisOutputRoot: GENESIS_OUTPUT_ROOT,
_maxGameDepth: 2**3, _maxGameDepth: 2 ** 3,
_splitDepth: 2**2, _splitDepth: 2 ** 2,
_gameDuration: Duration.wrap(7 days), _gameDuration: Duration.wrap(7 days),
_vm: _vm _vm: _vm
}); });
...@@ -111,7 +111,7 @@ contract OutputBisectionGame_Test is OutputBisectionGame_Init { ...@@ -111,7 +111,7 @@ contract OutputBisectionGame_Test is OutputBisectionGame_Init {
_absolutePrestate: ABSOLUTE_PRESTATE, _absolutePrestate: ABSOLUTE_PRESTATE,
_genesisBlockNumber: GENESIS_BLOCK_NUMBER, _genesisBlockNumber: GENESIS_BLOCK_NUMBER,
_genesisOutputRoot: GENESIS_OUTPUT_ROOT, _genesisOutputRoot: GENESIS_OUTPUT_ROOT,
_maxGameDepth: 2**3, _maxGameDepth: 2 ** 3,
_splitDepth: _splitDepth, _splitDepth: _splitDepth,
_gameDuration: Duration.wrap(7 days), _gameDuration: Duration.wrap(7 days),
_vm: alphabetVM _vm: alphabetVM
...@@ -127,7 +127,7 @@ contract OutputBisectionGame_Test is OutputBisectionGame_Init { ...@@ -127,7 +127,7 @@ contract OutputBisectionGame_Test is OutputBisectionGame_Init {
_absolutePrestate: ABSOLUTE_PRESTATE, _absolutePrestate: ABSOLUTE_PRESTATE,
_genesisBlockNumber: GENESIS_BLOCK_NUMBER, _genesisBlockNumber: GENESIS_BLOCK_NUMBER,
_genesisOutputRoot: GENESIS_OUTPUT_ROOT, _genesisOutputRoot: GENESIS_OUTPUT_ROOT,
_maxGameDepth: 2**3, _maxGameDepth: 2 ** 3,
_splitDepth: _splitDepth, _splitDepth: _splitDepth,
_gameDuration: Duration.wrap(7 days), _gameDuration: Duration.wrap(7 days),
_vm: alphabetVM _vm: alphabetVM
......
...@@ -50,11 +50,7 @@ contract Faucet_Initializer is Test { ...@@ -50,11 +50,7 @@ contract Faucet_Initializer is Test {
vm.deal(address(faucetContractAdmin), 5 ether); vm.deal(address(faucetContractAdmin), 5 ether);
vm.deal(address(nonAdmin), 5 ether); vm.deal(address(nonAdmin), 5 ether);
optimistNftFam = new AdminFaucetAuthModule( optimistNftFam = new AdminFaucetAuthModule(faucetAuthAdmin, optimistNftFamName, optimistNftFamVersion);
faucetAuthAdmin,
optimistNftFamName,
optimistNftFamVersion
);
githubFam = new AdminFaucetAuthModule(faucetAuthAdmin, githubFamName, githubFamVersion); githubFam = new AdminFaucetAuthModule(faucetAuthAdmin, githubFamName, githubFamVersion);
faucetHelper = new FaucetHelper(); faucetHelper = new FaucetHelper();
......
...@@ -173,10 +173,8 @@ contract Optimist_Initializer is Test { ...@@ -173,10 +173,8 @@ contract Optimist_Initializer is Test {
vm.expectEmit(true, true, false, false); vm.expectEmit(true, true, false, false);
emit Initialized(1); emit Initialized(1);
optimistInviter = new OptimistInviter({ optimistInviter =
_inviteGranter: eve_inviteGranter, new OptimistInviter({ _inviteGranter: eve_inviteGranter, _attestationStation: attestationStation });
_attestationStation: attestationStation
});
optimistInviter.initialize("OptimistInviter"); optimistInviter.initialize("OptimistInviter");
......
...@@ -112,10 +112,7 @@ contract OptimistAllowlist_Initializer is Test { ...@@ -112,10 +112,7 @@ contract OptimistAllowlist_Initializer is Test {
optimistInviter.initialize("OptimistInviter"); optimistInviter.initialize("OptimistInviter");
optimistAllowlist = new OptimistAllowlist( optimistAllowlist = new OptimistAllowlist(
attestationStation, attestationStation, alice_allowlistAttestor, sally_coinbaseQuestAttestor, address(optimistInviter)
alice_allowlistAttestor,
sally_coinbaseQuestAttestor,
address(optimistInviter)
); );
optimistInviterHelper = new OptimistInviterHelper(optimistInviter, "OptimistInviter"); optimistInviterHelper = new OptimistInviterHelper(optimistInviter, "OptimistInviter");
......
...@@ -23,13 +23,7 @@ contract OptimismMintableERC721_Test is Bridge_Initializer { ...@@ -23,13 +23,7 @@ contract OptimismMintableERC721_Test is Bridge_Initializer {
// Set up the token pair. // Set up the token pair.
L1NFT = new ERC721("L1NFT", "L1T"); L1NFT = new ERC721("L1NFT", "L1T");
L2NFT = new OptimismMintableERC721( L2NFT = new OptimismMintableERC721(address(l2ERC721Bridge), 1, address(L1NFT), "L2NFT", "L2T");
address(l2ERC721Bridge),
1,
address(L1NFT),
"L2NFT",
"L2T"
);
// Label the addresses for nice traces. // Label the addresses for nice traces.
vm.label(address(L1NFT), "L1ERC721Token"); vm.label(address(L1NFT), "L1ERC721Token");
......
...@@ -60,10 +60,7 @@ contract StandardBridge_Stateless_Test is CommonTest { ...@@ -60,10 +60,7 @@ contract StandardBridge_Stateless_Test is CommonTest {
function setUp() public override { function setUp() public override {
super.setUp(); super.setUp();
bridge = new StandardBridgeTester({ bridge = new StandardBridgeTester({ _messenger: payable(address(0)), _otherBridge: payable(address(0)) });
_messenger: payable(address(0)),
_otherBridge: payable(address(0))
});
mintable = new OptimismMintableERC20({ mintable = new OptimismMintableERC20({
_bridge: address(0), _bridge: address(0),
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment