Commit 24c78db4 authored by norswap's avatar norswap Committed by GitHub

Merge pull request #62 from mariobyn/ns/replaced-transfer-with-call

Replaced transfer with call 
parents 50997ddc c1268e23
...@@ -48,8 +48,9 @@ contract Challenge { ...@@ -48,8 +48,9 @@ contract Challenge {
fallback() external payable {} fallback() external payable {}
receive() external payable {} receive() external payable {}
function withdraw() external { function withdraw() external {
require(msg.sender == owner); require(msg.sender == owner, "not owner");
owner.transfer(address(this).balance); (bool sent, ) = owner.call{value: address(this).balance}("");
require(sent, "Failed to send Ether");
} }
// create challenge // create challenge
...@@ -211,8 +212,9 @@ contract Challenge { ...@@ -211,8 +212,9 @@ contract Challenge {
require(stepState == c.assertedState[c.R], "wrong asserted state for challenger"); require(stepState == c.assertedState[c.R], "wrong asserted state for challenger");
// pay out bounty!! // pay out bounty!!
c.challenger.transfer(address(this).balance); (bool sent, ) = c.challenger.call{value: address(this).balance}("");
require(sent, "Failed to send Ether");
emit ChallengerWins(challengeId); emit ChallengerWins(challengeId);
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment