Commit 2901c666 authored by Matthew Slipper's avatar Matthew Slipper

ci: Remove legacy labels

In the past, we used the `SR-Risk` and `C-Protocol-Critical` labels to require specific engineers to review PRs touching sensitive code:

- `SR-Risk` would tag @maurelian whenever legacy mainnet smart contracts were touched.
- `C-Protocol-Critical` would tag @tynes or @smartcontracts whenever smart contracts or `l2geth` were touched.

Since launching Bedrock, the `SR-Risk` label was removed from the `labeler` workflow, so it was never being applied. `C-Protocol-Critical` was still being applied, however it had no effect apart from blocking Mergify and pinging Mark/Kelvin unnecessarily since it is `CODEOWNERS` and not the label that prevents merge.

Given that we've started using `CODEOWNERS` and the fact that the labels were broken, this PR removes these legacy labels altogether.
parent e8b50b37
---
C-Protocol-Critical:
- 'packages/contracts-bedrock/**/*.sol'
...@@ -13,18 +13,6 @@ pull_request_rules: ...@@ -13,18 +13,6 @@ pull_request_rules:
- "label!=multiple-reviewers" - "label!=multiple-reviewers"
- "label!=mergify-ignore" - "label!=mergify-ignore"
- "base=develop" - "base=develop"
- or:
- and:
- "label!=SR-Risk"
- "label!=C-Protocol-Critical"
- and:
- "label=SR-Risk"
- "approved-reviews-by=maurelian"
- and:
- "label=C-Protocol-Critical"
- or:
- "approved-reviews-by=tynes"
- "approved-reviews-by=smartcontracts"
actions: actions:
queue: queue:
name: default name: default
...@@ -47,28 +35,6 @@ pull_request_rules: ...@@ -47,28 +35,6 @@ pull_request_rules:
label: label:
remove: remove:
- on-merge-train - on-merge-train
- name: Handle security critical PRs
conditions:
- "label=SR-Risk"
actions:
request_reviews:
users:
- "maurelian"
comment:
message: |
Hey there @{{author}}! You flagged this PR as security critical. To make review easier, please add a comment describing
1. The risks present in this PR.
2. The mitigations you have added to try and reduce those risks.
- name: Request protocol critical reviewers
conditions:
- label=C-Protocol-Critical
actions:
request_reviews:
users:
- tynes
- smartcontracts
random_count: 1
- name: Ask to resolve conflict - name: Ask to resolve conflict
conditions: conditions:
- conflict - conflict
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment