Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
N
nebula
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
exchain
nebula
Commits
2d6cdaf3
Unverified
Commit
2d6cdaf3
authored
May 16, 2024
by
Roman Dovgan
Committed by
GitHub
May 16, 2024
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fixed typos (#9634)
Co-authored-by:
smartcontracts
<
kelvin@optimism.io
>
parent
9eb5f880
Changes
10
Hide whitespace changes
Inline
Side-by-side
Showing
10 changed files
with
17 additions
and
17 deletions
+17
-17
readwrite.go
op-chain-ops/cmd/receipt-reference-builder/readwrite.go
+1
-1
batch_test.go
op-chain-ops/safe/batch_test.go
+2
-2
service.go
op-conductor/conductor/service.go
+1
-1
asyncgossiper.go
op-node/rollup/async/asyncgossiper.go
+2
-2
engine_consolidate_test.go
op-node/rollup/derive/engine_consolidate_test.go
+4
-4
frame_test.go
op-node/rollup/derive/frame_test.go
+1
-1
abi_test.go
op-proposer/proposer/abi_test.go
+1
-1
ssz_test.go
op-service/eth/ssz_test.go
+2
-2
txmgr_test.go
op-service/txmgr/txmgr_test.go
+1
-1
L2StandardBridge.t.sol
packages/contracts-bedrock/test/L2/L2StandardBridge.t.sol
+2
-2
No files found.
op-chain-ops/cmd/receipt-reference-builder/readwrite.go
View file @
2d6cdaf3
...
...
@@ -47,7 +47,7 @@ func (w jsonAggregateReaderWriter) readAggregate(f string) (aggregate, error) {
type
gobAggregateReaderWriter
struct
{}
// writeAggregate writes the aggregate to a file in gob format
// if the output file is not specified, it will cre
e
ate a file based on the block range
// if the output file is not specified, it will create a file based on the block range
func
(
w
gobAggregateReaderWriter
)
writeAggregate
(
a
aggregate
,
o
string
)
error
{
if
o
==
""
{
o
=
fmt
.
Sprintf
(
"%d.%d-%d.gob"
,
a
.
ChainID
,
a
.
First
,
a
.
Last
)
...
...
op-chain-ops/safe/batch_test.go
View file @
2d6cdaf3
...
...
@@ -70,8 +70,8 @@ func TestBatchAddCallFinalizeWithdrawalTransaction(t *testing.T) {
require
.
JSONEq
(
t
,
string
(
expected
),
string
(
serialized
))
}
// TestBatchAddCallDe
spos
tTransaction ensures that simple calls can be serialized correctly.
func
TestBatchAddCallDe
s
positTransaction
(
t
*
testing
.
T
)
{
// TestBatchAddCallDe
posi
tTransaction ensures that simple calls can be serialized correctly.
func
TestBatchAddCallDepositTransaction
(
t
*
testing
.
T
)
{
file
,
err
:=
os
.
ReadFile
(
"testdata/portal-abi.json"
)
require
.
NoError
(
t
,
err
)
portalABI
,
err
:=
abi
.
JSON
(
bytes
.
NewReader
(
file
))
...
...
op-conductor/conductor/service.go
View file @
2d6cdaf3
...
...
@@ -576,7 +576,7 @@ func (oc *OpConductor) action() {
break
}
// 2. we're here beca
s
use an healthy leader became unhealthy itself
// 2. we're here because an healthy leader became unhealthy itself
// then we should try to stop sequencing locally and transfer leadership.
var
result
*
multierror
.
Error
// Try to stop sequencer first, but since sequencer is not healthy, we may not be able to stop it.
...
...
op-node/rollup/async/asyncgossiper.go
View file @
2d6cdaf3
...
...
@@ -40,13 +40,13 @@ type SimpleAsyncGossiper struct {
}
// To avoid import cycles, we define a new Network interface here
// this interface is compat
a
ble with driver.Network
// this interface is compat
i
ble with driver.Network
type
Network
interface
{
PublishL2Payload
(
ctx
context
.
Context
,
payload
*
eth
.
ExecutionPayloadEnvelope
)
error
}
// To avoid import cycles, we define a new Metrics interface here
// this interface is compat
a
ble with driver.Metrics
// this interface is compat
i
ble with driver.Metrics
type
Metrics
interface
{
RecordPublishingError
()
}
...
...
op-node/rollup/derive/engine_consolidate_test.go
View file @
2d6cdaf3
...
...
@@ -107,7 +107,7 @@ func mismatchedParentHashArgs() args {
return
args
}
func
createMis
t
matchedPrevRandao
()
args
{
func
createMismatchedPrevRandao
()
args
{
args
:=
ecotoneArgs
()
args
.
attrs
.
PrevRandao
=
eth
.
Bytes32
(
common
.
HexToHash
(
"0xabc"
))
return
args
...
...
@@ -126,7 +126,7 @@ func createNilGasLimit() args {
return
args
}
func
createMis
t
matchedTimestamp
()
args
{
func
createMismatchedTimestamp
()
args
{
args
:=
ecotoneArgs
()
val
:=
eth
.
Uint64Quantity
(
2000
)
args
.
attrs
.
Timestamp
=
val
...
...
@@ -178,7 +178,7 @@ func TestAttributesMatch(t *testing.T) {
},
{
shouldMatch
:
false
,
args
:
createMis
t
matchedPrevRandao
(),
args
:
createMismatchedPrevRandao
(),
},
{
shouldMatch
:
false
,
...
...
@@ -190,7 +190,7 @@ func TestAttributesMatch(t *testing.T) {
},
{
shouldMatch
:
false
,
args
:
createMis
t
matchedTimestamp
(),
args
:
createMismatchedTimestamp
(),
},
}
...
...
op-node/rollup/derive/frame_test.go
View file @
2d6cdaf3
...
...
@@ -224,7 +224,7 @@ func randomFrame(rng *rand.Rand, opts ...frameOpt) *Frame {
IsLast
:
testutils
.
RandomBool
(
rng
),
}
// eva
ulau
te options
// eva
lua
te options
for
_
,
opt
:=
range
opts
{
opt
(
rng
,
frame
)
}
...
...
op-proposer/proposer/abi_test.go
View file @
2d6cdaf3
...
...
@@ -80,7 +80,7 @@ func TestManualABIPacking(t *testing.T) {
txData
,
err
:=
proposeL2OutputTxData
(
l2ooAbi
,
output
)
require
.
NoError
(
t
,
err
)
// set a gas limit to disable gas estimation. The invariant
e
s that the L2OO tries to uphold
// set a gas limit to disable gas estimation. The invariants that the L2OO tries to uphold
// are not maintained in this test.
opts
.
GasLimit
=
100
_000
tx
,
err
:=
l2oo
.
ProposeL2Output
(
...
...
op-service/eth/ssz_test.go
View file @
2d6cdaf3
...
...
@@ -427,7 +427,7 @@ func TestMarshalUnmarshalExecutionPayloadEnvelopes(t *testing.T) {
ExecutionPayload
:
createPayloadWithWithdrawals
(
&
types
.
Withdrawals
{}),
}
missingExecutionPayl
ao
d
:=
&
ExecutionPayloadEnvelope
{
missingExecutionPayl
oa
d
:=
&
ExecutionPayloadEnvelope
{
ParentBeaconBlockRoot
:
&
hash
,
ExecutionPayload
:
nil
,
}
...
...
@@ -439,7 +439,7 @@ func TestMarshalUnmarshalExecutionPayloadEnvelopes(t *testing.T) {
}{
{
"ValidInputSucceeds"
,
validInput
,
nil
},
{
"MissingHashFailsToSerialize"
,
missingHash
,
ErrMissingData
},
{
"MissingExecutionDataFailsToSerialize"
,
missingExecutionPayl
ao
d
,
ErrMissingData
},
{
"MissingExecutionDataFailsToSerialize"
,
missingExecutionPayl
oa
d
,
ErrMissingData
},
}
for
_
,
test
:=
range
tests
{
...
...
op-service/txmgr/txmgr_test.go
View file @
2d6cdaf3
...
...
@@ -305,7 +305,7 @@ func (*mockBackend) ChainID(ctx context.Context) (*big.Int, error) {
// TransactionReceipt queries the mockBackend for a mined txHash. If none is found, nil is returned
// for both return values. Otherwise, it returns a receipt containing the txHash, the gasFeeCap
// used in GasUsed, and the blobFeeCap in Cumul
u
ativeGasUsed to make the values accessible from our
// used in GasUsed, and the blobFeeCap in CumulativeGasUsed to make the values accessible from our
// test framework.
func
(
b
*
mockBackend
)
TransactionReceipt
(
ctx
context
.
Context
,
txHash
common
.
Hash
)
(
*
types
.
Receipt
,
error
)
{
b
.
mu
.
RLock
()
...
...
packages/contracts-bedrock/test/L2/L2StandardBridge.t.sol
View file @
2d6cdaf3
...
...
@@ -520,7 +520,7 @@ contract L2StandardBridge_BridgeERC20To_Test is PreBridgeERC20To {
}
contract L2StandardBridge_Bridge_Test is Bridge_Initializer {
/// @dev Tests that `finalizeBridgeETH` reverts if the rec
e
ipient is the other bridge.
/// @dev Tests that `finalizeBridgeETH` reverts if the recipient is the other bridge.
function test_finalizeBridgeETH_sendToSelf_reverts() external {
vm.mockCall(
address(l2StandardBridge.messenger()),
...
...
@@ -533,7 +533,7 @@ contract L2StandardBridge_Bridge_Test is Bridge_Initializer {
l2StandardBridge.finalizeBridgeETH{ value: 100 }(alice, address(l2StandardBridge), 100, hex"");
}
/// @dev Tests that `finalizeBridgeETH` reverts if the rec
e
ipient is the messenger.
/// @dev Tests that `finalizeBridgeETH` reverts if the recipient is the messenger.
function test_finalizeBridgeETH_sendToMessenger_reverts() external {
vm.mockCall(
address(l2StandardBridge.messenger()),
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment