Commit 31f517a2 authored by Liam Horne's avatar Liam Horne Committed by GitHub

refactor: improve logging for batch submission timeout scenarios (#1120)

parent 735cd78f
---
'@eth-optimism/batch-submitter': patch
---
Improved logging of batch submission timeout logs
...@@ -143,15 +143,16 @@ export abstract class BatchSubmitter { ...@@ -143,15 +143,16 @@ export abstract class BatchSubmitter {
protected _shouldSubmitBatch(batchSizeInBytes: number): boolean { protected _shouldSubmitBatch(batchSizeInBytes: number): boolean {
const currentTimestamp = Date.now() const currentTimestamp = Date.now()
const isTimeoutReached =
this.lastBatchSubmissionTimestamp + this.maxBatchSubmissionTime <=
currentTimestamp
if (batchSizeInBytes < this.minTxSize) { if (batchSizeInBytes < this.minTxSize) {
if (!isTimeoutReached) { const timeSinceLastSubmission =
currentTimestamp - this.lastBatchSubmissionTimestamp
if (timeSinceLastSubmission < this.maxBatchSubmissionTime) {
this.logger.info( this.logger.info(
'Skipping batch submission. Batch too small & max submission timeout not reached.', 'Skipping batch submission. Batch too small & max submission timeout not reached.',
{ {
batchSizeInBytes, batchSizeInBytes,
timeSinceLastSubmission,
maxBatchSubmissionTime: this.maxBatchSubmissionTime,
minTxSize: this.minTxSize, minTxSize: this.minTxSize,
lastBatchSubmissionTimestamp: this.lastBatchSubmissionTimestamp, lastBatchSubmissionTimestamp: this.lastBatchSubmissionTimestamp,
currentTimestamp, currentTimestamp,
...@@ -161,6 +162,8 @@ export abstract class BatchSubmitter { ...@@ -161,6 +162,8 @@ export abstract class BatchSubmitter {
} }
this.logger.info('Timeout reached, proceeding with batch submission.', { this.logger.info('Timeout reached, proceeding with batch submission.', {
batchSizeInBytes, batchSizeInBytes,
timeSinceLastSubmission,
maxBatchSubmissionTime: this.maxBatchSubmissionTime,
lastBatchSubmissionTimestamp: this.lastBatchSubmissionTimestamp, lastBatchSubmissionTimestamp: this.lastBatchSubmissionTimestamp,
currentTimestamp, currentTimestamp,
}) })
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment