Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
N
nebula
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
exchain
nebula
Commits
31f517a2
Unverified
Commit
31f517a2
authored
Jun 21, 2021
by
Liam Horne
Committed by
GitHub
Jun 21, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
refactor: improve logging for batch submission timeout scenarios (#1120)
parent
735cd78f
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
12 additions
and
4 deletions
+12
-4
short-badgers-itch.md
.changeset/short-badgers-itch.md
+5
-0
batch-submitter.ts
...es/batch-submitter/src/batch-submitter/batch-submitter.ts
+7
-4
No files found.
.changeset/short-badgers-itch.md
0 → 100644
View file @
31f517a2
---
'
@eth-optimism/batch-submitter'
:
patch
---
Improved logging of batch submission timeout logs
packages/batch-submitter/src/batch-submitter/batch-submitter.ts
View file @
31f517a2
...
@@ -143,15 +143,16 @@ export abstract class BatchSubmitter {
...
@@ -143,15 +143,16 @@ export abstract class BatchSubmitter {
protected
_shouldSubmitBatch
(
batchSizeInBytes
:
number
):
boolean
{
protected
_shouldSubmitBatch
(
batchSizeInBytes
:
number
):
boolean
{
const
currentTimestamp
=
Date
.
now
()
const
currentTimestamp
=
Date
.
now
()
const
isTimeoutReached
=
this
.
lastBatchSubmissionTimestamp
+
this
.
maxBatchSubmissionTime
<=
currentTimestamp
if
(
batchSizeInBytes
<
this
.
minTxSize
)
{
if
(
batchSizeInBytes
<
this
.
minTxSize
)
{
if
(
!
isTimeoutReached
)
{
const
timeSinceLastSubmission
=
currentTimestamp
-
this
.
lastBatchSubmissionTimestamp
if
(
timeSinceLastSubmission
<
this
.
maxBatchSubmissionTime
)
{
this
.
logger
.
info
(
this
.
logger
.
info
(
'
Skipping batch submission. Batch too small & max submission timeout not reached.
'
,
'
Skipping batch submission. Batch too small & max submission timeout not reached.
'
,
{
{
batchSizeInBytes
,
batchSizeInBytes
,
timeSinceLastSubmission
,
maxBatchSubmissionTime
:
this
.
maxBatchSubmissionTime
,
minTxSize
:
this
.
minTxSize
,
minTxSize
:
this
.
minTxSize
,
lastBatchSubmissionTimestamp
:
this
.
lastBatchSubmissionTimestamp
,
lastBatchSubmissionTimestamp
:
this
.
lastBatchSubmissionTimestamp
,
currentTimestamp
,
currentTimestamp
,
...
@@ -161,6 +162,8 @@ export abstract class BatchSubmitter {
...
@@ -161,6 +162,8 @@ export abstract class BatchSubmitter {
}
}
this
.
logger
.
info
(
'
Timeout reached, proceeding with batch submission.
'
,
{
this
.
logger
.
info
(
'
Timeout reached, proceeding with batch submission.
'
,
{
batchSizeInBytes
,
batchSizeInBytes
,
timeSinceLastSubmission
,
maxBatchSubmissionTime
:
this
.
maxBatchSubmissionTime
,
lastBatchSubmissionTimestamp
:
this
.
lastBatchSubmissionTimestamp
,
lastBatchSubmissionTimestamp
:
this
.
lastBatchSubmissionTimestamp
,
currentTimestamp
,
currentTimestamp
,
})
})
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment